Title: [141184] trunk/Source/WebCore
- Revision
- 141184
- Author
- tha...@chromium.org
- Date
- 2013-01-29 16:57:56 -0800 (Tue, 29 Jan 2013)
Log Message
[chromium] Do not mark translation-unit-local functions as extern "C"
https://bugs.webkit.org/show_bug.cgi?id=108218
Reviewed by Adam Barth.
Requested by darin in https://bugs.webkit.org/show_bug.cgi?id=107845
This also allows enabling -Wreturn-type-c-linkage again, but I'd like to
wait for the next clang roll (which tweaks this warning) before undoing
r140800 (which removed that warning).
No behavior change.
* bindings/v8/npruntime.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (141183 => 141184)
--- trunk/Source/WebCore/ChangeLog 2013-01-30 00:57:34 UTC (rev 141183)
+++ trunk/Source/WebCore/ChangeLog 2013-01-30 00:57:56 UTC (rev 141184)
@@ -1,3 +1,19 @@
+2013-01-29 Nico Weber <tha...@chromium.org>
+
+ [chromium] Do not mark translation-unit-local functions as extern "C"
+ https://bugs.webkit.org/show_bug.cgi?id=108218
+
+ Reviewed by Adam Barth.
+
+ Requested by darin in https://bugs.webkit.org/show_bug.cgi?id=107845
+ This also allows enabling -Wreturn-type-c-linkage again, but I'd like to
+ wait for the next clang roll (which tweaks this warning) before undoing
+ r140800 (which removed that warning).
+
+ No behavior change.
+
+ * bindings/v8/npruntime.cpp:
+
2013-01-29 Geoffrey Garen <gga...@apple.com>
Removed GGC because it has been disabled for a long time
Modified: trunk/Source/WebCore/bindings/v8/npruntime.cpp (141183 => 141184)
--- trunk/Source/WebCore/bindings/v8/npruntime.cpp 2013-01-30 00:57:34 UTC (rev 141183)
+++ trunk/Source/WebCore/bindings/v8/npruntime.cpp 2013-01-30 00:57:56 UTC (rev 141184)
@@ -332,6 +332,7 @@
memcpy((void*)variant->value.stringValue.UTF8Characters, value->UTF8Characters, sizeof(NPUTF8) * value->UTF8Length);
}
+} // extern "C"
// NPN_Registry
//
@@ -370,6 +371,8 @@
return objectMap;
}
+extern "C" {
+
void _NPN_RegisterObject(NPObject* npObject, NPObject* owner)
{
ASSERT(npObject);
@@ -458,4 +461,4 @@
return liveObjectMap().find(npObject) != liveObjectMap().end();
}
-} // extern "C"
+} // extern "C"
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
