Title: [141278] trunk/Source/WebCore
Revision
141278
Author
simon.fra...@apple.com
Date
2013-01-30 09:39:44 -0800 (Wed, 30 Jan 2013)

Log Message

Temporarily disable assertions related to clip rect computation in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=108265

Reviewed by Dean Jackson.

These assertions are killing the test bots, so disable them temporarily
until we figure out the underlying bug (tracked by https://bugs.webkit.org/show_bug.cgi?id=103432).

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (141277 => 141278)


--- trunk/Source/WebCore/ChangeLog	2013-01-30 17:15:18 UTC (rev 141277)
+++ trunk/Source/WebCore/ChangeLog	2013-01-30 17:39:44 UTC (rev 141278)
@@ -1,3 +1,16 @@
+2013-01-30  Simon Fraser  <simon.fra...@apple.com>
+
+        Temporarily disable assertions related to clip rect computation in RenderLayer
+        https://bugs.webkit.org/show_bug.cgi?id=108265
+
+        Reviewed by Dean Jackson.
+
+        These assertions are killing the test bots, so disable them temporarily
+        until we figure out the underlying bug (tracked by https://bugs.webkit.org/show_bug.cgi?id=103432).
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::updateLayerPositionsAfterScroll):
+
 2013-01-30  Elliott Sprehn  <espr...@chromium.org>
 
         Element::areAuthorShadowsAllowed should be private

Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (141277 => 141278)


--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2013-01-30 17:15:18 UTC (rev 141277)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2013-01-30 17:39:44 UTC (rev 141278)
@@ -762,8 +762,9 @@
         computeRepaintRects(renderer()->containerForRepaint(), geometryMap);
     } else {
         // Check that our cached rects are correct.
-        ASSERT(m_repaintRect == renderer()->clippedOverflowRectForRepaint(renderer()->containerForRepaint()));
-        ASSERT(m_outlineBox == renderer()->outlineBoundsForRepaint(renderer()->containerForRepaint(), geometryMap));
+        // FIXME: re-enable these assertions when the issue with table cells is resolved: https://bugs.webkit.org/show_bug.cgi?id=103432
+        // ASSERT(m_repaintRect == renderer()->clippedOverflowRectForRepaint(renderer()->containerForRepaint()));
+        // ASSERT(m_outlineBox == renderer()->outlineBoundsForRepaint(renderer()->containerForRepaint(), geometryMap));
     }
     
     for (RenderLayer* child = firstChild(); child; child = child->nextSibling())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to