Title: [141351] trunk/Source/WebCore
- Revision
- 141351
- Author
- jsb...@chromium.org
- Date
- 2013-01-30 17:31:12 -0800 (Wed, 30 Jan 2013)
Log Message
IndexedDB: Remove speculative dispatchEvent crash fix now that root cause is addressed
https://bugs.webkit.org/show_bug.cgi?id=108131
Reviewed by Tony Chang.
A patch was landed in r140027 to prevent a null pointer crash in
IDBRequest::dispatchEvent and confirm the source of the crash (which
we couldn't repro locally). Following confirmation from user reports,
the root cause was tracked down to a race condition in MessageQueue,
and was fixed in r140483. This patch is no longer needed, and there's
always been an ASSERT in place to catch regressions while debugging.
No new tests - no behavior change.
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent): Remove extraneous test.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (141350 => 141351)
--- trunk/Source/WebCore/ChangeLog 2013-01-31 01:26:22 UTC (rev 141350)
+++ trunk/Source/WebCore/ChangeLog 2013-01-31 01:31:12 UTC (rev 141351)
@@ -1,3 +1,22 @@
+2013-01-30 Joshua Bell <jsb...@chromium.org>
+
+ IndexedDB: Remove speculative dispatchEvent crash fix now that root cause is addressed
+ https://bugs.webkit.org/show_bug.cgi?id=108131
+
+ Reviewed by Tony Chang.
+
+ A patch was landed in r140027 to prevent a null pointer crash in
+ IDBRequest::dispatchEvent and confirm the source of the crash (which
+ we couldn't repro locally). Following confirmation from user reports,
+ the root cause was tracked down to a race condition in MessageQueue,
+ and was fixed in r140483. This patch is no longer needed, and there's
+ always been an ASSERT in place to catch regressions while debugging.
+
+ No new tests - no behavior change.
+
+ * Modules/indexeddb/IDBRequest.cpp:
+ (WebCore::IDBRequest::dispatchEvent): Remove extraneous test.
+
2013-01-30 Joe Mason <jma...@rim.com>
[BlackBerry] Store both proxy and host credentials simultaneously for NetworkJob
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (141350 => 141351)
--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2013-01-31 01:26:22 UTC (rev 141350)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2013-01-31 01:31:12 UTC (rev 141351)
@@ -441,13 +441,6 @@
ASSERT(event->target() == this);
ASSERT_WITH_MESSAGE(m_readyState < DONE, "When dispatching event %s, m_readyState < DONE(%d), was %d", event->type().string().utf8().data(), DONE, m_readyState);
- // FIXME: This method should not be called if stop() was previously called,
- // but there are crash reports (no local repro) indicating a null pointer
- // deference in the following DOMRequestState::Scope constructor. If this
- // resolves the crashes, track down the root cause, otherwise back this out.
- if (m_contextStopped)
- return false;
-
DOMRequestState::Scope scope(m_requestState);
if (event->type() != eventNames().blockedEvent)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
