Title: [141628] trunk/Tools
- Revision
- 141628
- Author
- roger_f...@apple.com
- Date
- 2013-02-01 12:36:30 -0800 (Fri, 01 Feb 2013)
Log Message
Fix test scripts for EWS bots to get them running once and for all.
https://bugs.webkit.org/show_bug.cgi?id=108422
Reviewed by Timothy Horton.
Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
However, we build in Debug only on the EWS Windows bots, which caused the build to fail.
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.options):
(RunTests.run):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (141627 => 141628)
--- trunk/Tools/ChangeLog 2013-02-01 20:27:05 UTC (rev 141627)
+++ trunk/Tools/ChangeLog 2013-02-01 20:36:30 UTC (rev 141628)
@@ -1,3 +1,18 @@
+2013-01-31 Roger Fong <roger_f...@apple.com>
+
+ Fix test scripts for EWS bots to get them running once and for all.
+ https://bugs.webkit.org/show_bug.cgi?id=108422
+
+ Reviewed by Timothy Horton.
+
+ Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
+ runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
+ However, we build in Debug only on the EWS Windows bots, which caused the build to fail.
+
+ * Scripts/webkitpy/tool/steps/runtests.py:
+ (RunTests.options):
+ (RunTests.run):
+
2013-02-01 Nico Weber <tha...@chromium.org>
[chromium] Build webkit with enable_web_intents set to 0.
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (141627 => 141628)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2013-02-01 20:27:05 UTC (rev 141627)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2013-02-01 20:36:30 UTC (rev 141628)
@@ -43,6 +43,7 @@
@classmethod
def options(cls):
return AbstractStep.options() + [
+ Options.build_style,
Options.test,
Options.non_interactive,
Options.quiet,
@@ -87,11 +88,18 @@
"--no-new-test-results",
"--no-show-results",
"--exit-after-n-failures=%s" % self.NON_INTERACTIVE_FAILURE_LIMIT_COUNT,
- "--quiet",
])
+ if self._options.build_style == "release":
+ args.append("--release")
+ elif self._options.build_style == "debug":
+ args.append("--debug")
+
+ # old-run-webkit-tests does not support --skip-failing-tests
+ # Using --quiet one Windows fails when we try to use /dev/null, disabling for now until we find a fix
if sys.platform != "cygwin":
args.append("--skip-failing-test")
+ args.append("--quiet")
if self._options.quiet:
args.append("--quiet")
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
