Title: [142010] branches/chromium/1364/Source/WebKit/chromium
- Revision
- 142010
- Author
- k...@chromium.org
- Date
- 2013-02-06 10:56:35 -0800 (Wed, 06 Feb 2013)
Log Message
Merge 141540
> [Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
> https://bugs.webkit.org/show_bug.cgi?id=108543
>
> Patch by Aurimas Liutikas <auri...@chromium.org> on 2013-01-31
> Reviewed by Ryosuke Niwa.
>
> Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
>
> * src/WebViewImpl.cpp:
> (WebKit::WebViewImpl::setCompositionFromExistingText):
> * tests/WebViewTest.cpp:
> Re-enabling the test
TBR=commit-qu...@webkit.org
Review URL: https://codereview.chromium.org/12233004
Modified Paths
Diff
Modified: branches/chromium/1364/Source/WebKit/chromium/ChangeLog (142009 => 142010)
--- branches/chromium/1364/Source/WebKit/chromium/ChangeLog 2013-02-06 18:54:06 UTC (rev 142009)
+++ branches/chromium/1364/Source/WebKit/chromium/ChangeLog 2013-02-06 18:56:35 UTC (rev 142010)
@@ -1,3 +1,210 @@
+2013-01-31 Aurimas Liutikas <auri...@chromium.org>
+
+ [Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
+ https://bugs.webkit.org/show_bug.cgi?id=108543
+
+ Reviewed by Ryosuke Niwa.
+
+ Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::setCompositionFromExistingText):
+ * tests/WebViewTest.cpp:
+ Re-enabling the test
+
+2013-01-31 Hajime Morrita <morr...@google.com>
+
+ Unreviewed, followup fix for r141535.
+
+ * tests/WebFrameTest.cpp:
+
+2013-01-31 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed. Rolled Chromium DEPS to r180023. Requested by
+ thakis_ via sheriffbot.
+
+ * DEPS:
+
+2013-01-31 Hajime Morrita <morr...@google.com>
+
+ Unreviewed, disabling failing test.
+
+ * tests/WebFrameTest.cpp:
+
+2013-01-31 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r141479.
+ http://trac.webkit.org/changeset/141479
+ https://bugs.webkit.org/show_bug.cgi?id=108564
+
+ breaks chromium test (Requested by morrita on #webkit).
+
+ * public/WebViewClient.h:
+ * src/EditorClientImpl.cpp:
+ (WebKit::EditorClientImpl::respondToChangedSelection):
+
+2013-01-31 Alec Flett <alecfl...@chromium.org>
+
+ IndexedDB: remove old transaction backend bootstrap code
+ https://bugs.webkit.org/show_bug.cgi?id=103923
+
+ Reviewed by Dimitri Glazkov.
+
+ Remove all deprecated WebKit APIs from
+ the IDB backend.
+
+ * WebKit.gyp:
+ * public/WebIDBCallbacks.h:
+ (WebKit):
+ * public/WebIDBDatabase.h:
+ (WebKit):
+ * public/WebIDBTransaction.h: Removed.
+ * public/WebIDBTransactionCallbacks.h: Removed.
+ * src/AssertMatchingEnums.cpp:
+ * src/IDBCallbacksProxy.cpp:
+ * src/IDBDatabaseBackendProxy.cpp:
+ * src/IDBDatabaseBackendProxy.h:
+ (IDBDatabaseBackendProxy):
+ * src/IDBTransactionBackendProxy.cpp: Removed.
+ * src/IDBTransactionBackendProxy.h: Removed.
+ * src/IDBTransactionCallbacksProxy.cpp: Removed.
+ * src/IDBTransactionCallbacksProxy.h: Removed.
+ * src/WebIDBCallbacksImpl.cpp:
+ * src/WebIDBDatabaseImpl.cpp:
+ (WebKit):
+ * src/WebIDBDatabaseImpl.h:
+ (WebKit):
+ (WebIDBDatabaseImpl):
+ * src/WebIDBTransactionCallbacksImpl.cpp: Removed.
+ * src/WebIDBTransactionCallbacksImpl.h: Removed.
+ * src/WebIDBTransactionImpl.cpp: Removed.
+ * src/WebIDBTransactionImpl.h: Removed.
+ * tests/IDBAbortOnCorruptTest.cpp:
+ * tests/IDBDatabaseBackendTest.cpp:
+
+2013-01-31 Rouslan Solomakhin <rous...@chromium.org>
+
+ [Chromium] Select multi-word misspelling on context click
+ https://bugs.webkit.org/show_bug.cgi?id=108509
+
+ Reviewed by Tony Chang.
+
+ * src/ContextMenuClientImpl.cpp:
+ (WebKit):
+ (WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
+ (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.
+
+2013-01-31 Florin Malita <fmal...@chromium.org>
+
+ [Chromium] Unreviewed gardening.
+
+ WebViewTest.SetCompositionFromExistingText failing after r141479.
+
+ * tests/WebViewTest.cpp:
+
+2013-01-31 Alexandre Elias <ael...@chromium.org>
+
+ [chromium] Rework page scale factor limits initialization
+ https://bugs.webkit.org/show_bug.cgi?id=108446
+
+ Reviewed by James Robinson.
+
+ When loading a page with viewportEnabled, both the limits
+ specified by the viewport tag and the content width need to be
+ considered before we initialize the minimum page scale (and
+ pageScaleFactor itself usually to the same value). The timing has
+ proven tricky to get correct.
+
+ This patch simplifies the flow by computing the
+ limits only at the end of layouts and at no other time. In combination
+ with https://bugs.webkit.org/show_bug.cgi?id=107922 which sets
+ needsLayout() appropriately, this results in a more robust and easy
+ to understand sequence.
+
+ Fixes FixedLayoutInitializeAtMinimumPageScale test.
+
+ * src/ChromeClientImpl.cpp:
+ (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::WebViewImpl):
+ (WebKit::WebViewImpl::resize):
+ (WebKit::WebViewImpl::setPageScaleFactorLimits):
+ (WebKit::WebViewImpl::computePageScaleFactorLimits):
+ (WebKit::WebViewImpl::layoutUpdated):
+ (WebKit::WebViewImpl::didChangeContentsSize):
+ * src/WebViewImpl.h:
+ (WebKit::WebViewImpl::setInitialPageScaleFactor):
+ (WebViewImpl):
+ * tests/WebFrameTest.cpp:
+
+2013-01-31 Aurimas Liutikas <auri...@chromium.org>
+
+ Editor::m_compositionNode not updated on HTMLInputElement::setValue()
+ https://bugs.webkit.org/show_bug.cgi?id=107737
+
+ Reviewed by Ryosuke Niwa.
+
+ * public/WebViewClient.h:
+ (WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
+ Adding a callback to let the WebViewClient know that the composition has been cancelled.
+ * src/EditorClientImpl.cpp:
+ (WebKit::EditorClientImpl::respondToChangedSelection):
+ Adding a call composition if it is no longer valid.
+
+2013-01-31 Mark Pilgrim <pilg...@chromium.org>
+
+ [Chromium] Move LocalizedStrings to WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=108488
+
+ Reviewed by Adam Barth.
+
+ Part of a larger refactoring series; see tracking bug 106829.
+
+ * WebKit.gyp:
+ * src/LocalizedStrings.cpp: Removed.
+
+2013-01-31 Enrica Casucci <enr...@apple.com>
+
+ WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
+ https://bugs.webkit.org/show_bug.cgi?id=108396.
+ <rdar://problem/12920461>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Adds stub implementation for WebKit of the new EditorClient methods.
+
+ * src/EditorClientImpl.cpp:
+ (WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
+ (WebKit::EditorClientImpl::getClientPasteboardDataForRange):
+ * src/EditorClientImpl.h:
+
+2013-01-31 Chris Hopman <cjhop...@chromium.org>
+
+ [chromium] Make selection handling work in applyPageScaleInCompositor mode
+ https://bugs.webkit.org/show_bug.cgi?id=107831
+
+ Reviewed by Ryosuke Niwa.
+
+ These functions expect a window point. When in
+ applyPageScaleFactorInCompositor mode, the points need to be unscaled
+ by the page scale factor.
+
+ * src/WebFrameImpl.cpp:
+ (WebKit::WebFrameImpl::selectRange):
+ (WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
+
+2013-01-31 Tom Sepez <tse...@chromium.org>
+
+ [v8] Enable binding integrity on mac
+ https://bugs.webkit.org/show_bug.cgi?id=108500
+
+ Reviewed by Adam Barth.
+
+ Patch is correct if existing tests pass without new crashes.
+
+ * features.gypi:
+ Set ENABLE_BINDING_INTEGRITY=1 when OS=="mac"
+
2013-01-31 Dan Alcantara <dfalcant...@chromium.org>
WebFrameTest.DisambiguationPopup is failing
Modified: branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp (142009 => 142010)
--- branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-02-06 18:54:06 UTC (rev 142009)
+++ branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-02-06 18:56:35 UTC (rev 142010)
@@ -2430,6 +2430,8 @@
String text = editor->selectedText();
focused->document()->execCommand("delete", true);
editor->setComposition(text, CompositionUnderlineVectorBuilder(underlines), 0, 0);
+ // Need to set setIgnoreCompositionSelectionChange(true) again because setComposition resets it to false.
+ editor->setIgnoreCompositionSelectionChange(true);
editor->setSelectionOffsets(location, location + length);
editor->setIgnoreCompositionSelectionChange(false);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
