Title: [142107] trunk/Source/WebCore
- Revision
- 142107
- Author
- [email protected]
- Date
- 2013-02-07 05:56:05 -0800 (Thu, 07 Feb 2013)
Log Message
Web Inspector: Closure compilation fixes
https://bugs.webkit.org/show_bug.cgi?id=109131
Reviewed by Yury Semikhatsky.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
* inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):
* inspector/front-end/IsolatedFileSystemModel.js:
(WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):
* inspector/front-end/SidebarPane.js:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (142106 => 142107)
--- trunk/Source/WebCore/ChangeLog 2013-02-07 13:51:17 UTC (rev 142106)
+++ trunk/Source/WebCore/ChangeLog 2013-02-07 13:56:05 UTC (rev 142107)
@@ -1,3 +1,18 @@
+2013-02-07 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: Closure compilation fixes
+ https://bugs.webkit.org/show_bug.cgi?id=109131
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/ElementsPanel.js:
+ (WebInspector.ElementsPanel):
+ * inspector/front-end/FileSystemMapping.js:
+ (WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):
+ * inspector/front-end/IsolatedFileSystemModel.js:
+ (WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):
+ * inspector/front-end/SidebarPane.js:
+
2013-02-07 Kentaro Hara <[email protected]>
Unreviewed, rolling out r142077.
Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (142106 => 142107)
--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2013-02-07 13:51:17 UTC (rev 142106)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2013-02-07 13:56:05 UTC (rev 142107)
@@ -86,7 +86,7 @@
this.sidebarPanes.domBreakpoints = WebInspector.domBreakpointsSidebarPane;
this.sidebarPanes.eventListeners = new WebInspector.EventListenersSidebarPane();
- this.sidebarPanes.styles.setShowCallback(this.updateStyles.bind(this));
+ this.sidebarPanes.styles.setShowCallback(this.updateStyles.bind(this, false));
this.sidebarPanes.metrics.setShowCallback(this.updateMetrics.bind(this));
this.sidebarPanes.properties.setShowCallback(this.updateProperties.bind(this));
this.sidebarPanes.eventListeners.setShowCallback(this.updateEventListeners.bind(this));
Modified: trunk/Source/WebCore/inspector/front-end/FileSystemMapping.js (142106 => 142107)
--- trunk/Source/WebCore/inspector/front-end/FileSystemMapping.js 2013-02-07 13:51:17 UTC (rev 142106)
+++ trunk/Source/WebCore/inspector/front-end/FileSystemMapping.js 2013-02-07 13:56:05 UTC (rev 142107)
@@ -49,7 +49,7 @@
/**
* @param {string} fileSystemPath
* @param {string} filePath
- * @return {string}
+ * @return {?string}
*/
uriForFile: function(fileSystemPath, filePath) { },
@@ -120,7 +120,7 @@
/**
* @param {string} fileSystemPath
- * @return {?string}
+ * @return {string}
*/
addFileSystemMapping: function(fileSystemPath)
{
@@ -198,7 +198,7 @@
this._cachedURIPrefixes = this._cachedURIPrefixes || {};
if (this._cachedURIPrefixes.hasOwnProperty(pathPrefix))
return this._cachedURIPrefixes[pathPrefix];
- var uriPrefix;
+ var uriPrefix = null;
for (var id in this._fileSystemPaths) {
var fileSystemPath = this._fileSystemPaths[id];
if (pathPrefix.startsWith(fileSystemPath + "/")) {
Modified: trunk/Source/WebCore/inspector/front-end/IsolatedFileSystemModel.js (142106 => 142107)
--- trunk/Source/WebCore/inspector/front-end/IsolatedFileSystemModel.js 2013-02-07 13:51:17 UTC (rev 142106)
+++ trunk/Source/WebCore/inspector/front-end/IsolatedFileSystemModel.js 2013-02-07 13:56:05 UTC (rev 142107)
@@ -156,7 +156,8 @@
_fileSystemRemoved: function(fileSystemPath)
{
var fileSystemId = this._fileSystemMapping.fileSystemId(fileSystemPath);
- this._workspace.removeProject(fileSystemId);
+ if (fileSystemId)
+ this._workspace.removeProject(fileSystemId);
this._fileSystemMapping.removeFileSystemMapping(fileSystemPath);
delete this._fileSystems[fileSystemPath];
if (this._removeFileSystemCallback) {
Modified: trunk/Source/WebCore/inspector/front-end/SidebarPane.js (142106 => 142107)
--- trunk/Source/WebCore/inspector/front-end/SidebarPane.js 2013-02-07 13:51:17 UTC (rev 142106)
+++ trunk/Source/WebCore/inspector/front-end/SidebarPane.js 2013-02-07 13:56:05 UTC (rev 142107)
@@ -51,7 +51,7 @@
},
/**
- * @param {function} callback
+ * @param {function()} callback
*/
prepareContent: function(callback)
{
@@ -72,7 +72,7 @@
},
/**
- * @param {function} callback
+ * @param {function()} callback
* @return {boolean}
*/
setExpandCallback: function(callback)
@@ -84,7 +84,7 @@
},
/**
- * @param {function} callback
+ * @param {function()} callback
*/
setShowCallback: function(callback)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
