Diff
Modified: trunk/Source/WebCore/ChangeLog (142894 => 142895)
--- trunk/Source/WebCore/ChangeLog 2013-02-14 19:17:12 UTC (rev 142894)
+++ trunk/Source/WebCore/ChangeLog 2013-02-14 19:22:10 UTC (rev 142895)
@@ -1,3 +1,30 @@
+2013-02-14 Chris Fleizach <[email protected]>
+
+ Remove Leopard Accessibility support from WebCore (now that no port builds on Leopard)
+ https://bugs.webkit.org/show_bug.cgi?id=90250
+
+ Reviewed by Eric Seidel.
+
+ The Leopard era checks for accessibility lists and accessibility tables can be removed now.
+
+ * accessibility/AccessibilityARIAGrid.cpp:
+ (WebCore):
+ * accessibility/AccessibilityARIAGrid.h:
+ (AccessibilityARIAGrid):
+ (WebCore::AccessibilityARIAGrid::isTableExposableThroughAccessibility):
+ * accessibility/AccessibilityList.cpp:
+ (WebCore::AccessibilityList::computeAccessibilityIsIgnored):
+ * accessibility/AccessibilityList.h:
+ * accessibility/AccessibilityTable.cpp:
+ (WebCore::AccessibilityTable::AccessibilityTable):
+ (WebCore::AccessibilityTable::init):
+ * accessibility/AccessibilityTable.h:
+ (AccessibilityTable):
+ * accessibility/mac/AXObjectCacheMac.mm:
+ (WebCore::AXObjectCache::postPlatformNotification):
+ * accessibility/mac/WebAccessibilityObjectWrapper.mm:
+ (createAccessibilityRoleMap):
+
2013-02-14 Bear Travis <[email protected]>
Make outside-shape the default value for shape-inside
Modified: trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp (142894 => 142895)
--- trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp 2013-02-14 19:17:12 UTC (rev 142894)
+++ trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.cpp 2013-02-14 19:22:10 UTC (rev 142895)
@@ -49,16 +49,6 @@
{
}
-void AccessibilityARIAGrid::init()
-{
- AccessibilityTable::init();
-#if ACCESSIBILITY_TABLES
- m_isAccessibilityTable = true;
-#else
- m_isAccessibilityTable = false;
-#endif
-}
-
PassRefPtr<AccessibilityARIAGrid> AccessibilityARIAGrid::create(RenderObject* renderer)
{
return adoptRef(new AccessibilityARIAGrid(renderer));
Modified: trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.h (142894 => 142895)
--- trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.h 2013-02-14 19:17:12 UTC (rev 142894)
+++ trunk/Source/WebCore/accessibility/AccessibilityARIAGrid.h 2013-02-14 19:22:10 UTC (rev 142895)
@@ -45,8 +45,6 @@
static PassRefPtr<AccessibilityARIAGrid> create(RenderObject*);
virtual ~AccessibilityARIAGrid();
- virtual void init();
-
virtual bool isAriaTable() const { return true; }
virtual void addChildren();
@@ -57,6 +55,7 @@
// ARIA treegrids and grids support selected rows.
virtual bool supportsSelectedRows() { return true; }
virtual bool isMultiSelectable() const { return true; }
+ virtual bool isTableExposableThroughAccessibility() const { return true; }
bool addTableCellChild(AccessibilityObject*, HashSet<AccessibilityObject*>& appendedRows, unsigned& columnCount);
};
Modified: trunk/Source/WebCore/accessibility/AccessibilityList.cpp (142894 => 142895)
--- trunk/Source/WebCore/accessibility/AccessibilityList.cpp 2013-02-14 19:17:12 UTC (rev 142894)
+++ trunk/Source/WebCore/accessibility/AccessibilityList.cpp 2013-02-14 19:22:10 UTC (rev 142895)
@@ -61,13 +61,8 @@
if (decision == IgnoreObject)
return true;
- // lists don't appear on tiger/leopard on the mac
-#if ACCESSIBILITY_LISTS
return false;
-#else
- return true;
-#endif
-}
+}
bool AccessibilityList::isUnorderedList() const
{
Modified: trunk/Source/WebCore/accessibility/AccessibilityList.h (142894 => 142895)
--- trunk/Source/WebCore/accessibility/AccessibilityList.h 2013-02-14 19:17:12 UTC (rev 142894)
+++ trunk/Source/WebCore/accessibility/AccessibilityList.h 2013-02-14 19:22:10 UTC (rev 142895)
@@ -29,12 +29,6 @@
#ifndef AccessibilityList_h
#define AccessibilityList_h
-#if PLATFORM(MAC) && !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
-#define ACCESSIBILITY_LISTS 0
-#else
-#define ACCESSIBILITY_LISTS 1
-#endif
-
#include "AccessibilityRenderObject.h"
namespace WebCore {
Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.cpp (142894 => 142895)
--- trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2013-02-14 19:17:12 UTC (rev 142894)
+++ trunk/Source/WebCore/accessibility/AccessibilityTable.cpp 2013-02-14 19:22:10 UTC (rev 142895)
@@ -48,8 +48,9 @@
using namespace HTMLNames;
AccessibilityTable::AccessibilityTable(RenderObject* renderer)
- : AccessibilityRenderObject(renderer),
- m_headerContainer(0)
+ : AccessibilityRenderObject(renderer)
+ , m_headerContainer(0)
+ , m_isAccessibilityTable(true)
{
}
@@ -60,11 +61,7 @@
void AccessibilityTable::init()
{
AccessibilityRenderObject::init();
-#if ACCESSIBILITY_TABLES
m_isAccessibilityTable = isTableExposableThroughAccessibility();
-#else
- m_isAccessibilityTable = false;
-#endif
}
PassRefPtr<AccessibilityTable> AccessibilityTable::create(RenderObject* renderer)
Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.h (142894 => 142895)
--- trunk/Source/WebCore/accessibility/AccessibilityTable.h 2013-02-14 19:17:12 UTC (rev 142894)
+++ trunk/Source/WebCore/accessibility/AccessibilityTable.h 2013-02-14 19:22:10 UTC (rev 142895)
@@ -32,12 +32,6 @@
#include "AccessibilityRenderObject.h"
#include <wtf/Forward.h>
-#if PLATFORM(MAC) && !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
-#define ACCESSIBILITY_TABLES 0
-#else
-#define ACCESSIBILITY_TABLES 1
-#endif
-
namespace WebCore {
class AccessibilityTableCell;
@@ -86,10 +80,10 @@
AccessibilityChildrenVector m_columns;
RefPtr<AccessibilityObject> m_headerContainer;
- mutable bool m_isAccessibilityTable;
+ bool m_isAccessibilityTable;
bool hasARIARole() const;
- bool isTableExposableThroughAccessibility() const;
+ virtual bool isTableExposableThroughAccessibility() const;
virtual bool computeAccessibilityIsIgnored() const;
};
Modified: trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm (142894 => 142895)
--- trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2013-02-14 19:17:12 UTC (rev 142894)
+++ trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm 2013-02-14 19:22:10 UTC (rev 142895)
@@ -77,12 +77,8 @@
macNotification = NSAccessibilityFocusedUIElementChangedNotification;
break;
case AXAutocorrectionOccured:
-#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070
macNotification = @"AXAutocorrectionOccurred";
break;
-#else
- return;
-#endif
case AXFocusedUIElementChanged:
macNotification = NSAccessibilityFocusedUIElementChangedNotification;
break;
@@ -113,14 +109,12 @@
case AXRowCountChanged:
macNotification = NSAccessibilityRowCountChangedNotification;
break;
-#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1060
case AXRowExpanded:
macNotification = NSAccessibilityRowExpandedNotification;
break;
case AXRowCollapsed:
macNotification = NSAccessibilityRowCollapsedNotification;
break;
-#endif
// Does not exist on Mac.
case AXCheckedStateChanged:
default:
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm (142894 => 142895)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm 2013-02-14 19:17:12 UTC (rev 142894)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm 2013-02-14 19:22:10 UTC (rev 142895)
@@ -1593,11 +1593,7 @@
{ HeadingRole, @"AXHeading" },
{ ListBoxRole, NSAccessibilityListRole },
{ ListBoxOptionRole, NSAccessibilityStaticTextRole },
-#if ACCESSIBILITY_TABLES
{ CellRole, NSAccessibilityCellRole },
-#else
- { CellRole, NSAccessibilityGroupRole },
-#endif
{ TableHeaderContainerRole, NSAccessibilityGroupRole },
{ RowHeaderRole, NSAccessibilityGroupRole },
{ DefinitionRole, NSAccessibilityGroupRole },
