Title: [143767] trunk/Source/WebKit/blackberry
- Revision
- 143767
- Author
- mifen...@rim.com
- Date
- 2013-02-22 11:59:12 -0800 (Fri, 22 Feb 2013)
Log Message
[BlackBerry] Accept key events even when composing region is active.
https://bugs.webkit.org/show_bug.cgi?id=110617
Reviewed by Rob Buis.
PR 293598.
Don't reject key events that arrive when composing region is active,
this can prevent navigation events from firing, instead end
the composition and process the key.
Reviewed Internally by Nima Ghanavatian.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (143766 => 143767)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-02-22 19:53:35 UTC (rev 143766)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-02-22 19:59:12 UTC (rev 143767)
@@ -1,3 +1,21 @@
+2013-02-22 Mike Fenton <mifen...@rim.com>
+
+ [BlackBerry] Accept key events even when composing region is active.
+ https://bugs.webkit.org/show_bug.cgi?id=110617
+
+ Reviewed by Rob Buis.
+
+ PR 293598.
+
+ Don't reject key events that arrive when composing region is active,
+ this can prevent navigation events from firing, instead end
+ the composition and process the key.
+
+ Reviewed Internally by Nima Ghanavatian.
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::updateFormState):
+
2013-02-22 Carlos Garcia Campos <cargar...@rim.com>
[BlackBerry] Rename first/second to key/value in HashMap iterators
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (143766 => 143767)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-02-22 19:53:35 UTC (rev 143766)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-02-22 19:59:12 UTC (rev 143767)
@@ -1686,7 +1686,7 @@
// while composing text. If IMF has failed, we should have already finished the
// composition manually. There is a caveat for KeyUp which is explained above.
if (!changeIsPartOfComposition && compositionActive())
- return false;
+ removeAttributedTextMarker();
ProcessingChangeGuard guard(this);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
