Title: [143902] trunk/Source/WebCore
- Revision
- 143902
- Author
- [email protected]
- Date
- 2013-02-25 03:45:27 -0800 (Mon, 25 Feb 2013)
Log Message
Web Inspector: [Network] Timeline bars and dividers are positioned in different coordinate systems.
https://bugs.webkit.org/show_bug.cgi?id=109943
Reviewed by Pavel Feldman.
Look at network log: red bar (on load) is positioned to the right of
the last required load.
This is incorrect. For exmaple, in case of short event it should be
positioned in the center of the bar.
* inspector/front-end/DataGrid.js:
Fix - hidden columns can have non-zero width.
* inspector/front-end/NetworkPanel.js: Use correct width for calculator.
* inspector/front-end/networkLogView.css: Removed parasite paddinds.
Extracted common absolute "paddings".
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (143901 => 143902)
--- trunk/Source/WebCore/ChangeLog 2013-02-25 11:31:09 UTC (rev 143901)
+++ trunk/Source/WebCore/ChangeLog 2013-02-25 11:45:27 UTC (rev 143902)
@@ -1,3 +1,22 @@
+2013-02-25 Eugene Klyuchnikov <[email protected]>
+
+ Web Inspector: [Network] Timeline bars and dividers are positioned in different coordinate systems.
+ https://bugs.webkit.org/show_bug.cgi?id=109943
+
+ Reviewed by Pavel Feldman.
+
+ Look at network log: red bar (on load) is positioned to the right of
+ the last required load.
+
+ This is incorrect. For exmaple, in case of short event it should be
+ positioned in the center of the bar.
+
+ * inspector/front-end/DataGrid.js:
+ Fix - hidden columns can have non-zero width.
+ * inspector/front-end/NetworkPanel.js: Use correct width for calculator.
+ * inspector/front-end/networkLogView.css: Removed parasite paddinds.
+ Extracted common absolute "paddings".
+
2013-02-25 Keishi Hattori <[email protected]>
Add list view for new calendar picker
Modified: trunk/Source/WebCore/inspector/front-end/DataGrid.js (143901 => 143902)
--- trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-02-25 11:31:09 UTC (rev 143901)
+++ trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-02-25 11:45:27 UTC (rev 143902)
@@ -688,6 +688,10 @@
previousResizer.rightNeighboringColumnIndex = i;
previousResizer = resizer;
} else {
+ if (previousResizer && previousResizer._position !== left) {
+ previousResizer._position = left;
+ previousResizer.style.left = left + "px";
+ }
resizer.style.setProperty("display", "none");
resizer.leftNeighboringColumnIndex = 0;
resizer.rightNeighboringColumnIndex = 0;
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (143901 => 143902)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-02-25 11:31:09 UTC (rev 143901)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-02-25 11:45:27 UTC (rev 143902)
@@ -559,7 +559,6 @@
if (timelineColumn.ordinal === this._dataGrid.resizers[i].rightNeighboringColumnIndex) {
// Position timline grid location.
this._timelineGrid.element.style.left = this._dataGrid.resizers[i].style.left;
- this._timelineGrid.element.style.right = "18px";
}
}
@@ -568,7 +567,7 @@
this._scheduleRefresh();
proceed = false;
} else {
- this.calculator.setDisplayWindow(this._timelineGrid.element.clientWidth);
+ this.calculator.setDisplayWindow(this._timelineGrid.dividersElement.clientWidth);
proceed = this._timelineGrid.updateDividers(this.calculator);
}
if (!proceed)
Modified: trunk/Source/WebCore/inspector/front-end/networkLogView.css (143901 => 143902)
--- trunk/Source/WebCore/inspector/front-end/networkLogView.css 2013-02-25 11:31:09 UTC (rev 143901)
+++ trunk/Source/WebCore/inspector/front-end/networkLogView.css 2013-02-25 11:45:27 UTC (rev 143902)
@@ -216,7 +216,7 @@
.network-graph-side {
position: relative;
height: 36px;
- padding: 0 5px;
+ padding: 0;
white-space: nowrap;
margin-top: 1px;
border-top: 1px solid transparent;
@@ -227,10 +227,16 @@
position: absolute;
top: 0;
bottom: 0;
- right: 8px;
- left: 9px;
}
+.network-graph-bar-area,
+.network-timeline-grid .resources-dividers,
+.network-timeline-grid .resources-event-dividers,
+.network-timeline-grid .resources-dividers-label-bar {
+ right: 12px;
+ left: 12px;
+}
+
.network-graph-label {
position: absolute;
top: 0;
@@ -381,10 +387,20 @@
top: 0;
bottom: 0;
left: 0;
- right: 0;
+ right: 14px; /* Keep in sync with td.corner width */
pointer-events: none;
}
+.network-log-grid.data-grid .timeline-column,
+.network.panel .data-grid th.timeline-column {
+ border-right: none;
+}
+
+.data-grid td.timeline-column {
+ padding-left: 0;
+ padding-right: 0;
+}
+
.network-event-divider-padding {
position: absolute;
width: 8px;
@@ -429,7 +445,7 @@
}
.network-timeline-grid .resources-divider-label {
- top: 0px;
+ top: 0;
margin-top: -4px;
color: black;
}
@@ -467,7 +483,6 @@
left: 0;
right: 0;
bottom: 0;
- margin-right: -14px;
background-color: rgb(101, 111, 130);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
