Title: [144129] trunk/Source
- Revision
- 144129
- Author
- jam...@google.com
- Date
- 2013-02-26 17:09:52 -0800 (Tue, 26 Feb 2013)
Log Message
[chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
https://bugs.webkit.org/show_bug.cgi?id=110928
Reviewed by Adrienne Walker.
Source/Platform:
* chromium/public/WebLayerTreeViewClient.h:
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
* tests/WebLayerTreeViewTestCommon.h:
Modified Paths
Diff
Modified: trunk/Source/Platform/ChangeLog (144128 => 144129)
--- trunk/Source/Platform/ChangeLog 2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/Platform/ChangeLog 2013-02-27 01:09:52 UTC (rev 144129)
@@ -1,5 +1,14 @@
2013-02-26 James Robinson <jam...@chromium.org>
+ [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
+ https://bugs.webkit.org/show_bug.cgi?id=110928
+
+ Reviewed by Adrienne Walker.
+
+ * chromium/public/WebLayerTreeViewClient.h:
+
+2013-02-26 James Robinson <jam...@chromium.org>
+
[chromium] Remove unused WebLayerTreeViewClient calls
https://bugs.webkit.org/show_bug.cgi?id=110923
Modified: trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h (144128 => 144129)
--- trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h 2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h 2013-02-27 01:09:52 UTC (rev 144129)
@@ -37,17 +37,6 @@
class WebLayerTreeViewClient {
public:
- // Indicates to the embedder that the compositor is about to begin a
- // frame. This is is a signal to flow control mechanisms that a frame is
- // beginning. This call will be followed by updateAnimations and then
- // layout, which should be used for actual animation or tree manipulation
- // tasks. FIXME: make pure virtual once upstream deps are satisfied.
- virtual void willBeginFrame() { }
-
- // Indicates that main thread tasks associated with frame rendering have completed.
- // Issued unconditionally, even if the context was lost in the process.
- virtual void didBeginFrame() { }
-
// Updates animation and layout. These are called before the compositing
// pass so that layers can be updated at the given frame time.
virtual void updateAnimations(double monotonicFrameBeginTime) = 0;
Modified: trunk/Source/WebKit/chromium/ChangeLog (144128 => 144129)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-02-27 01:09:52 UTC (rev 144129)
@@ -1,3 +1,14 @@
+2013-02-26 James Robinson <jam...@chromium.org>
+
+ [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
+ https://bugs.webkit.org/show_bug.cgi?id=110928
+
+ Reviewed by Adrienne Walker.
+
+ * src/WebViewImpl.cpp:
+ * src/WebViewImpl.h:
+ * tests/WebLayerTreeViewTestCommon.h:
+
2013-02-26 Alpha Lam <hc...@chromium.org>
[chromium] GIFImageDecoderTest.parseAndDecodeByteByByte failing on Android
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (144128 => 144129)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2013-02-27 01:09:52 UTC (rev 144129)
@@ -1831,17 +1831,6 @@
#endif
}
-void WebViewImpl::willBeginFrame()
-{
- m_client->willBeginCompositorFrame();
-}
-
-void WebViewImpl::didBeginFrame()
-{
- if (m_devToolsAgent)
- m_devToolsAgent->didComposite();
-}
-
void WebViewImpl::updateAnimations(double monotonicFrameBeginTime)
{
#if ENABLE(REQUEST_ANIMATION_FRAME)
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (144128 => 144129)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2013-02-27 01:09:52 UTC (rev 144129)
@@ -315,8 +315,6 @@
virtual void setContinuousPaintingEnabled(bool);
// WebLayerTreeViewClient
- virtual void willBeginFrame();
- virtual void didBeginFrame();
virtual void updateAnimations(double monotonicFrameBeginTime);
virtual void applyScrollAndScale(const WebSize&, float);
virtual WebCompositorOutputSurface* createOutputSurface() OVERRIDE;
Modified: trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h (144128 => 144129)
--- trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h 2013-02-27 01:05:07 UTC (rev 144128)
+++ trunk/Source/WebKit/chromium/tests/WebLayerTreeViewTestCommon.h 2013-02-27 01:09:52 UTC (rev 144129)
@@ -37,8 +37,6 @@
public:
MOCK_METHOD0(scheduleComposite, void());
virtual void updateAnimations(double frameBeginTime) OVERRIDE { }
- MOCK_METHOD0(willBeginFrame, void());
- MOCK_METHOD0(didBeginFrame, void());
virtual void layout() OVERRIDE { }
virtual void applyScrollAndScale(const WebSize& scrollDelta, float scaleFactor) OVERRIDE { }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
