Title: [144250] trunk/Source/WebCore
Revision
144250
Author
aba...@webkit.org
Date
2013-02-27 16:17:27 -0800 (Wed, 27 Feb 2013)

Log Message

Use FeatureObserver to see how often web sites use multipart main documents
https://bugs.webkit.org/show_bug.cgi?id=111015

Reviewed by Nate Chapin.

Multipart main documents add sigificant complexity to the loader.  It
would be interesting to know how often this complexity is used.

* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived):
* page/FeatureObserver.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (144249 => 144250)


--- trunk/Source/WebCore/ChangeLog	2013-02-27 23:50:41 UTC (rev 144249)
+++ trunk/Source/WebCore/ChangeLog	2013-02-28 00:17:27 UTC (rev 144250)
@@ -1,3 +1,17 @@
+2013-02-27  Adam Barth  <aba...@webkit.org>
+
+        Use FeatureObserver to see how often web sites use multipart main documents
+        https://bugs.webkit.org/show_bug.cgi?id=111015
+
+        Reviewed by Nate Chapin.
+
+        Multipart main documents add sigificant complexity to the loader.  It
+        would be interesting to know how often this complexity is used.
+
+        * loader/MainResourceLoader.cpp:
+        (WebCore::MainResourceLoader::responseReceived):
+        * page/FeatureObserver.h:
+
 2013-02-27  James Simonsen  <simon...@chromium.org>
 
         [chromium] Lower priority of preloaded images

Modified: trunk/Source/WebCore/loader/MainResourceLoader.cpp (144249 => 144250)


--- trunk/Source/WebCore/loader/MainResourceLoader.cpp	2013-02-27 23:50:41 UTC (rev 144249)
+++ trunk/Source/WebCore/loader/MainResourceLoader.cpp	2013-02-28 00:17:27 UTC (rev 144250)
@@ -39,6 +39,7 @@
 #include "Document.h"
 #include "DocumentLoadTiming.h"
 #include "DocumentLoader.h"
+#include "FeatureObserver.h"
 #include "FormState.h"
 #include "Frame.h"
 #include "FrameLoader.h"
@@ -427,8 +428,10 @@
         m_resource->clear();
     }
     
-    if (r.isMultipart())
+    if (r.isMultipart()) {
+        FeatureObserver::observe(m_documentLoader->frame()->document(), FeatureObserver::MultipartMainResource);
         m_loadingMultipartContent = true;
+    }
         
     // The additional processing can do anything including possibly removing the last
     // reference to this object; one example of this is 3266216.

Modified: trunk/Source/WebCore/page/FeatureObserver.h (144249 => 144250)


--- trunk/Source/WebCore/page/FeatureObserver.h	2013-02-27 23:50:41 UTC (rev 144249)
+++ trunk/Source/WebCore/page/FeatureObserver.h	2013-02-28 00:17:27 UTC (rev 144250)
@@ -45,7 +45,7 @@
     enum Feature {
         PageDestruction,
         LegacyNotifications,
-        UnusedSlot01, // Prior to 10/2012, we used this slot for LegacyBlobBuilder.
+        MultipartMainResource,
         PrefixedIndexedDB,
         WorkerStart,
         SharedWorkerStart,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to