Title: [144518] trunk/Source/WebKit/chromium
- Revision
- 144518
- Author
- commit-qu...@webkit.org
- Date
- 2013-03-01 17:05:07 -0800 (Fri, 01 Mar 2013)
Log Message
[chromium] Revert r143827 to restore WebHelperPluginImpl's call to frameDetached()
https://bugs.webkit.org/show_bug.cgi?id=111232
Patch by David Dorwin <ddor...@chromium.org> on 2013-03-01
Reviewed by Adam Barth.
This patch reverts r143827, which causes a crash in failure conditions:
http://crbug.com/178848
* src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::destoryPage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (144517 => 144518)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-03-02 01:04:29 UTC (rev 144517)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-02 01:05:07 UTC (rev 144518)
@@ -1,3 +1,16 @@
+2013-03-01 David Dorwin <ddor...@chromium.org>
+
+ [chromium] Revert r143827 to restore WebHelperPluginImpl's call to frameDetached()
+ https://bugs.webkit.org/show_bug.cgi?id=111232
+
+ Reviewed by Adam Barth.
+
+ This patch reverts r143827, which causes a crash in failure conditions:
+ http://crbug.com/178848
+
+ * src/WebHelperPluginImpl.cpp:
+ (WebKit::WebHelperPluginImpl::destoryPage):
+
2013-03-01 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r144422 and r144424.
Modified: trunk/Source/WebKit/chromium/src/WebHelperPluginImpl.cpp (144517 => 144518)
--- trunk/Source/WebKit/chromium/src/WebHelperPluginImpl.cpp 2013-03-02 01:04:29 UTC (rev 144517)
+++ trunk/Source/WebKit/chromium/src/WebHelperPluginImpl.cpp 2013-03-02 01:05:07 UTC (rev 144518)
@@ -209,6 +209,9 @@
if (!m_page)
return;
+ if (m_page->mainFrame())
+ m_page->mainFrame()->loader()->frameDetached();
+
m_page.clear();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
