Diff
Modified: trunk/Tools/ChangeLog (144730 => 144731)
--- trunk/Tools/ChangeLog 2013-03-05 07:33:23 UTC (rev 144730)
+++ trunk/Tools/ChangeLog 2013-03-05 07:42:51 UTC (rev 144731)
@@ -1,3 +1,25 @@
+2013-03-04 Jochen Eisinger <joc...@chromium.org>
+
+ Run the bindings generation tests on EWS and CQ bots
+ https://bugs.webkit.org/show_bug.cgi?id=111358
+
+ Reviewed by Adam Barth.
+
+ The tests are super fast and not flaky.
+
+ * Scripts/webkitpy/common/config/ports.py:
+ (DeprecatedPort.run_bindings_tests_command):
+ * Scripts/webkitpy/common/config/ports_mock.py:
+ (MockPort.run_webkit_tests_command):
+ (MockPort):
+ (MockPort.run_bindings_tests_command):
+ * Scripts/webkitpy/tool/commands/download_unittest.py:
+ * Scripts/webkitpy/tool/steps/runtests.py:
+ (RunTests.run):
+ * Scripts/webkitpy/tool/steps/runtests_unittest.py:
+ (RunTestsTest.test_webkit_run_unit_tests):
+ * Scripts/webkitpy/tool/steps/steps_unittest.py:
+
2013-03-04 Eric Seidel <e...@webkit.org>
run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (144730 => 144731)
--- trunk/Tools/Scripts/webkitpy/common/config/ports.py 2013-03-05 07:33:23 UTC (rev 144730)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py 2013-03-05 07:42:51 UTC (rev 144731)
@@ -117,7 +117,10 @@
def run_perl_unittests_command(self):
return self.script_shell_command("test-webkitperl")
+ def run_bindings_tests_command(self):
+ return self.script_shell_command("run-bindings-tests")
+
class MacPort(DeprecatedPort):
port_flag_name = "mac"
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py (144730 => 144731)
--- trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py 2013-03-05 07:33:23 UTC (rev 144730)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports_mock.py 2013-03-05 07:42:51 UTC (rev 144731)
@@ -57,3 +57,6 @@
def run_webkit_tests_command(self):
return ['mock-run-webkit-tests']
+
+ def run_bindings_tests_command(self):
+ return ['mock-run-bindings-tests']
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (144730 => 144731)
--- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2013-03-05 07:33:23 UTC (rev 144730)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2013-03-05 07:42:51 UTC (rev 144731)
@@ -99,6 +99,7 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
+Running bindings generation tests
Running WebKit unit tests
Running run-webkit-tests
"""
@@ -140,6 +141,7 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
+Running bindings generation tests
Running WebKit unit tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -167,6 +169,8 @@
MOCK run_and_throw_if_fail: ['mock-test-webkitperl'], cwd=/mock-checkout
Running _javascript_Core tests
MOCK run_and_throw_if_fail: ['mock-run-javacriptcore-tests'], cwd=/mock-checkout
+Running bindings generation tests
+MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
Running WebKit unit tests
MOCK run_and_throw_if_fail: ['mock-run-webkit-unit-tests'], cwd=/mock-checkout
Running run-webkit-tests
@@ -183,6 +187,7 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
+Running bindings generation tests
Running WebKit unit tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -214,6 +219,7 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
+Running bindings generation tests
Running WebKit unit tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -231,6 +237,7 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
+Running bindings generation tests
Running WebKit unit tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -241,6 +248,7 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
+Running bindings generation tests
Running WebKit unit tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -258,6 +266,7 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
+Running bindings generation tests
Running WebKit unit tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -268,6 +277,7 @@
Running Python unit tests
Running Perl unit tests
Running _javascript_Core tests
+Running bindings generation tests
Running WebKit unit tests
Running run-webkit-tests
Committed r49824: <http://trac.webkit.org/changeset/49824>
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (144730 => 144731)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2013-03-05 07:33:23 UTC (rev 144730)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py 2013-03-05 07:42:51 UTC (rev 144731)
@@ -71,6 +71,15 @@
_log.info("Running _javascript_Core tests")
self._tool.executive.run_and_throw_if_fail(_javascript_core_tests_command, quiet=True, cwd=self._tool.scm().checkout_root)
+ bindings_tests_command = self._tool.deprecated_port().run_bindings_tests_command()
+ if bindings_tests_command:
+ _log.info("Running bindings generation tests")
+ args = bindings_tests_command
+ try:
+ self._tool.executive.run_and_throw_if_fail(args, cwd=self._tool.scm().checkout_root)
+ except ScriptError, e:
+ _log.info("Error running run-bindings-tests: %s" % e.message_with_output())
+
webkit_unit_tests_command = self._tool.deprecated_port().run_webkit_unit_tests_command()
if webkit_unit_tests_command:
_log.info("Running WebKit unit tests")
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py (144730 => 144731)
--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py 2013-03-05 07:33:23 UTC (rev 144730)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py 2013-03-05 07:42:51 UTC (rev 144731)
@@ -38,7 +38,9 @@
tool._deprecated_port.run_python_unittests_command = lambda: None
tool._deprecated_port.run_perl_unittests_command = lambda: None
step = RunTests(tool, MockOptions(test=True, non_interactive=True, quiet=False))
- expected_logs = """Running WebKit unit tests
+ expected_logs = """Running bindings generation tests
+MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
+Running WebKit unit tests
MOCK run_and_throw_if_fail: ['mock-run-webkit-unit-tests'], cwd=/mock-checkout
Running run-webkit-tests
MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--quiet', '--skip-failing-tests'], cwd=/mock-checkout
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py (144730 => 144731)
--- trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2013-03-05 07:33:23 UTC (rev 144730)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py 2013-03-05 07:42:51 UTC (rev 144731)
@@ -109,6 +109,8 @@
MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitperl'], cwd=/mock-checkout
Running _javascript_Core tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/run-_javascript_core-tests'], cwd=/mock-checkout
+Running bindings generation tests
+MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests'], cwd=/mock-checkout
Running run-webkit-tests
MOCK run_and_throw_if_fail: ['Tools/Scripts/run-webkit-tests', '--quiet'], cwd=/mock-checkout
"""
