Title: [145111] trunk/LayoutTests
Revision
145111
Author
jsb...@chromium.org
Date
2013-03-07 11:40:36 -0800 (Thu, 07 Mar 2013)

Log Message

IndexedDB: Make test behavior deterministic in multiprocess ports
https://bugs.webkit.org/show_bug.cgi?id=111643

Reviewed by Tony Chang.

Root cause is documented in wkbug.com/111642 but as a stop-gap - ensure
that this test doesn't fail flakily in multiprocess ports by moving the
last part of the test out of a limbo zone.

* storage/indexeddb/resources/index-multientry.js: Run subsequent part of
test in open's "success" handler rather than transaction's "complete" handler.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (145110 => 145111)


--- trunk/LayoutTests/ChangeLog	2013-03-07 19:20:27 UTC (rev 145110)
+++ trunk/LayoutTests/ChangeLog	2013-03-07 19:40:36 UTC (rev 145111)
@@ -1,3 +1,17 @@
+2013-03-07  Joshua Bell  <jsb...@chromium.org>
+
+        IndexedDB: Make test behavior deterministic in multiprocess ports
+        https://bugs.webkit.org/show_bug.cgi?id=111643
+
+        Reviewed by Tony Chang.
+
+        Root cause is documented in wkbug.com/111642 but as a stop-gap - ensure
+        that this test doesn't fail flakily in multiprocess ports by moving the
+        last part of the test out of a limbo zone.
+
+        * storage/indexeddb/resources/index-multientry.js: Run subsequent part of
+        test in open's "success" handler rather than transaction's "complete" handler.
+
 2013-03-06  Ojan Vafai  <o...@chromium.org>
 
         Recalculate borders at the beginning of table layout

Modified: trunk/LayoutTests/storage/indexeddb/resources/index-multientry.js (145110 => 145111)


--- trunk/LayoutTests/storage/indexeddb/resources/index-multientry.js	2013-03-07 19:20:27 UTC (rev 145110)
+++ trunk/LayoutTests/storage/indexeddb/resources/index-multientry.js	2013-03-07 19:40:36 UTC (rev 145111)
@@ -136,9 +136,9 @@
         evalAndLog("db = event.target.result");
         evalAndLog("trans = event.target.transaction");
         trans._onabort_ = unexpectedAbortCallback;
-        trans._oncomplete_ = function() { verifyIndexes('index-new', finishJSTest); };
 
         store = evalAndLog("store = trans.objectStore('store')");
         evalAndLog("store.createIndex('index-new', 'x', {multiEntry: true})");
     };
+    request._onsuccess_ = function() { verifyIndexes('index-new', finishJSTest); };
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to