Title: [145493] trunk/Source/WebCore
- Revision
- 145493
- Author
- commit-qu...@webkit.org
- Date
- 2013-03-12 00:46:42 -0700 (Tue, 12 Mar 2013)
Log Message
Need to notify ScrollingCoordinator when frame scrollbars are destroyed
https://bugs.webkit.org/show_bug.cgi?id=112104
Patch by Tien-Ren Chen <trc...@chromium.org> on 2013-03-12
Reviewed by James Robinson.
Need to notify ScrollingCoordinatorChromium whenever m_layerForHorizontalScrollbar /
m_layerForVerticalScrollbar changes, for correct lifetime management.
No new tests. Difficult to test lifetime management internal to ScrollingCoordinatorChromium.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::destroyRootLayer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (145492 => 145493)
--- trunk/Source/WebCore/ChangeLog 2013-03-12 07:34:29 UTC (rev 145492)
+++ trunk/Source/WebCore/ChangeLog 2013-03-12 07:46:42 UTC (rev 145493)
@@ -1,3 +1,18 @@
+2013-03-12 Tien-Ren Chen <trc...@chromium.org>
+
+ Need to notify ScrollingCoordinator when frame scrollbars are destroyed
+ https://bugs.webkit.org/show_bug.cgi?id=112104
+
+ Reviewed by James Robinson.
+
+ Need to notify ScrollingCoordinatorChromium whenever m_layerForHorizontalScrollbar /
+ m_layerForVerticalScrollbar changes, for correct lifetime management.
+
+ No new tests. Difficult to test lifetime management internal to ScrollingCoordinatorChromium.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::destroyRootLayer):
+
2013-03-11 Simon Fraser <simon.fra...@apple.com>
We'll get there eventually.
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (145492 => 145493)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2013-03-12 07:34:29 UTC (rev 145492)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2013-03-12 07:46:42 UTC (rev 145493)
@@ -2690,6 +2690,8 @@
if (m_layerForHorizontalScrollbar) {
m_layerForHorizontalScrollbar->removeFromParent();
m_layerForHorizontalScrollbar = nullptr;
+ if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())
+ scrollingCoordinator->scrollableAreaScrollbarLayerDidChange(m_renderView->frameView(), HorizontalScrollbar);
if (Scrollbar* horizontalScrollbar = m_renderView->frameView()->verticalScrollbar())
m_renderView->frameView()->invalidateScrollbar(horizontalScrollbar, IntRect(IntPoint(0, 0), horizontalScrollbar->frameRect().size()));
}
@@ -2697,6 +2699,8 @@
if (m_layerForVerticalScrollbar) {
m_layerForVerticalScrollbar->removeFromParent();
m_layerForVerticalScrollbar = nullptr;
+ if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator())
+ scrollingCoordinator->scrollableAreaScrollbarLayerDidChange(m_renderView->frameView(), VerticalScrollbar);
if (Scrollbar* verticalScrollbar = m_renderView->frameView()->verticalScrollbar())
m_renderView->frameView()->invalidateScrollbar(verticalScrollbar, IntRect(IntPoint(0, 0), verticalScrollbar->frameRect().size()));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
