Title: [145534] trunk/Source/WebKit/blackberry
- Revision
- 145534
- Author
- commit-qu...@webkit.org
- Date
- 2013-03-12 05:29:32 -0700 (Tue, 12 Mar 2013)
Log Message
[BlackBerry] SelectionHandler: fix truncated line
https://bugs.webkit.org/show_bug.cgi?id=112133
Patch by Alberto Garcia <agar...@igalia.com> on 2013-03-12
Reviewed by Carlos Garcia Campos.
One of the calls to fatFingersResult.nodeAsElementIfApplicable()
was somehow truncated when the selection start animation was
upstreamed in r144640.
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (145533 => 145534)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-03-12 12:29:03 UTC (rev 145533)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-03-12 12:29:32 UTC (rev 145534)
@@ -1,5 +1,19 @@
2013-03-12 Alberto Garcia <agar...@igalia.com>
+ [BlackBerry] SelectionHandler: fix truncated line
+ https://bugs.webkit.org/show_bug.cgi?id=112133
+
+ Reviewed by Carlos Garcia Campos.
+
+ One of the calls to fatFingersResult.nodeAsElementIfApplicable()
+ was somehow truncated when the selection start animation was
+ upstreamed in r144640.
+
+ * WebKitSupport/SelectionHandler.cpp:
+ (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
+
+2013-03-12 Alberto Garcia <agar...@igalia.com>
+
[BlackBerry] Fix visible_units.h includes
https://bugs.webkit.org/show_bug.cgi?id=112131
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (145533 => 145534)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-03-12 12:29:03 UTC (rev 145533)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-03-12 12:29:32 UTC (rev 145534)
@@ -648,7 +648,7 @@
FatFingersResult fatFingersResult = m_webPage->m_touchEventHandler->lastFatFingersResult();
if (selectNodeIfFatFingersResultIsLink(fatFingersResult))
return;
- if (!fatFingersResult.resultMatches(location, FatFingers::Text) || !fatFingersResult.positionWasAdjusted() || !fatFingersResult.nodeAsElem
+ if (!fatFingersResult.resultMatches(location, FatFingers::Text) || !fatFingersResult.positionWasAdjusted() || !fatFingersResult.nodeAsElementIfApplicable())
fatFingersResult = FatFingers(m_webPage, location, FatFingers::Text).findBestPoint();
if (!fatFingersResult.positionWasAdjusted()) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
