Title: [146031] trunk/Source/WebKit/chromium
- Revision
- 146031
- Author
- aba...@webkit.org
- Date
- 2013-03-17 20:28:29 -0700 (Sun, 17 Mar 2013)
Log Message
[Chromium] Remove unused WebNode::hasEventListeners API
https://bugs.webkit.org/show_bug.cgi?id=112529
Reviewed by James Robinson.
This API no longer has any callers and can be removed.
* public/WebNode.h:
* src/WebNode.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (146030 => 146031)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-03-18 02:21:26 UTC (rev 146030)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-18 03:28:29 UTC (rev 146031)
@@ -1,3 +1,15 @@
+2013-03-17 Adam Barth <aba...@webkit.org>
+
+ [Chromium] Remove unused WebNode::hasEventListeners API
+ https://bugs.webkit.org/show_bug.cgi?id=112529
+
+ Reviewed by James Robinson.
+
+ This API no longer has any callers and can be removed.
+
+ * public/WebNode.h:
+ * src/WebNode.cpp:
+
2013-03-16 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r145898.
Modified: trunk/Source/WebKit/chromium/public/WebNode.h (146030 => 146031)
--- trunk/Source/WebKit/chromium/public/WebNode.h 2013-03-18 02:21:26 UTC (rev 146030)
+++ trunk/Source/WebKit/chromium/public/WebNode.h 2013-03-18 03:28:29 UTC (rev 146031)
@@ -107,8 +107,6 @@
WEBKIT_EXPORT bool isFocusable() const;
WEBKIT_EXPORT bool isContentEditable() const;
WEBKIT_EXPORT bool isElementNode() const;
- // hasEventListeners only works with a small set of eventTypes.
- WEBKIT_EXPORT bool hasEventListeners(const WebString& eventType) const;
// addEventListener only works with a small set of eventTypes.
WEBKIT_EXPORT void addEventListener(const WebString& eventType, WebDOMEventListener* listener, bool useCapture);
WEBKIT_EXPORT bool dispatchEvent(const WebDOMEvent&);
Modified: trunk/Source/WebKit/chromium/src/WebNode.cpp (146030 => 146031)
--- trunk/Source/WebKit/chromium/src/WebNode.cpp 2013-03-18 02:21:26 UTC (rev 146030)
+++ trunk/Source/WebKit/chromium/src/WebNode.cpp 2013-03-18 03:28:29 UTC (rev 146031)
@@ -178,18 +178,6 @@
return m_private->isElementNode();
}
-bool WebNode::hasEventListeners(const WebString& eventType) const
-{
- // FIXME: "permissionrequest" seems like an implementation detail of the
- // the browser plug-in. Perhaps the browser plug-in should have
- // a more special-purpose mechanism?
- // See http://code.google.com/p/chromium/issues/detail?id=189561
-
- // Please do not add more eventTypes to this list without an API review.
- RELEASE_ASSERT(eventType == "permissionrequest");
- return m_private->hasEventListeners(eventType);
-}
-
void WebNode::addEventListener(const WebString& eventType, WebDOMEventListener* listener, bool useCapture)
{
// Please do not add more eventTypes to this list without an API review.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
