Modified: trunk/Source/WebCore/ChangeLog (146329 => 146330)
--- trunk/Source/WebCore/ChangeLog 2013-03-20 11:50:58 UTC (rev 146329)
+++ trunk/Source/WebCore/ChangeLog 2013-03-20 11:51:27 UTC (rev 146330)
@@ -1,3 +1,30 @@
+2013-03-20 Ilya Tikhonovsky <loi...@chromium.org>
+
+ Web Inspector: OverviewGrid rename classes according to names of js classes.
+ https://bugs.webkit.org/show_bug.cgi?id=112786
+
+ Reviewed by Yury Semikhatsky.
+
+ It is a part of meta bug 'extract OverviewGrid from TimelineOverviewPane'.
+ As the last step it renames timeline-...... classes to overview-grid-...... classes
+ and moves them to inspectorCommon.css
+
+ * inspector/front-end/OverviewGrid.js:
+ (WebInspector.OverviewGrid):
+ (WebInspector.OverviewGrid.Window):
+ (WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
+ (WebInspector.OverviewGrid.WindowSelector):
+ (WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):
+ * inspector/front-end/inspectorCommon.css:
+ (.overview-grid-window-selector):
+ (.overview-grid-window):
+ (.overview-grid-dividers-background):
+ (.overview-grid-window-rulers):
+ (.overview-grid-window-resizer):
+ * inspector/front-end/timelinePanel.css:
+ (.timeline-frame-overview .overview-grid-window):
+ (.timeline-frame-overview .overview-grid-dividers-background):
+
2013-03-20 Dmitry Zvorygin <zvory...@chromium.org>
Web Inspector: Switch Drawer animation from _javascript_ to CSS transitions.
Modified: trunk/Source/WebCore/inspector/front-end/OverviewGrid.js (146329 => 146330)
--- trunk/Source/WebCore/inspector/front-end/OverviewGrid.js 2013-03-20 11:50:58 UTC (rev 146329)
+++ trunk/Source/WebCore/inspector/front-end/OverviewGrid.js 2013-03-20 11:51:27 UTC (rev 146330)
@@ -45,7 +45,7 @@
this.element.appendChild(this._grid.element);
- this._window = new WebInspector.OverviewGrid.Window(this.element, this._grid.dividersLabelBarElement, prefix);
+ this._window = new WebInspector.OverviewGrid.Window(this.element, this._grid.dividersLabelBarElement);
}
WebInspector.OverviewGrid.prototype = {
@@ -163,13 +163,11 @@
* @extends {WebInspector.Object}
* @param {Element} parentElement
* @param {Element} dividersLabelBarElement
- * @param {string} prefix
*/
-WebInspector.OverviewGrid.Window = function(parentElement, dividersLabelBarElement, prefix)
+WebInspector.OverviewGrid.Window = function(parentElement, dividersLabelBarElement)
{
this._parentElement = parentElement;
this._dividersLabelBarElement = dividersLabelBarElement;
- this._prefix = prefix;
WebInspector.installDragHandle(this._parentElement, this._startWindowSelectorDragging.bind(this), this._windowSelectorDragging.bind(this), this._endWindowSelectorDragging.bind(this), "ew-resize");
WebInspector.installDragHandle(this._dividersLabelBarElement, this._startWindowDragging.bind(this), this._windowDragging.bind(this), this._endWindowDragging.bind(this), "ew-resize");
@@ -181,25 +179,25 @@
this._parentElement.addEventListener("dblclick", this._resizeWindowMaximum.bind(this), true);
this._overviewWindowElement = document.createElement("div");
- this._overviewWindowElement.className = prefix + "-overview-window";
+ this._overviewWindowElement.className = "overview-grid-window";
parentElement.appendChild(this._overviewWindowElement);
this._overviewWindowBordersElement = document.createElement("div");
- this._overviewWindowBordersElement.className = prefix + "-overview-window-rulers";
+ this._overviewWindowBordersElement.className = "overview-grid-window-rulers";
parentElement.appendChild(this._overviewWindowBordersElement);
var overviewDividersBackground = document.createElement("div");
- overviewDividersBackground.className = prefix + "-overview-dividers-background";
+ overviewDividersBackground.className = "overview-grid-dividers-background";
parentElement.appendChild(overviewDividersBackground);
this._leftResizeElement = document.createElement("div");
- this._leftResizeElement.className = prefix + "-window-resizer";
+ this._leftResizeElement.className = "overview-grid-window-resizer";
this._leftResizeElement.style.left = 0;
parentElement.appendChild(this._leftResizeElement);
WebInspector.installDragHandle(this._leftResizeElement, null, this._leftResizeElementDragging.bind(this), null, "ew-resize");
this._rightResizeElement = document.createElement("div");
- this._rightResizeElement.className = prefix + "-window-resizer " + prefix + "-window-resizer-right";
+ this._rightResizeElement.className = "overview-grid-window-resizer overview-grid-window-resizer-right";
this._rightResizeElement.style.right = 0;
parentElement.appendChild(this._rightResizeElement);
WebInspector.installDragHandle(this._rightResizeElement, null, this._rightResizeElementDragging.bind(this), null, "ew-resize");
@@ -248,7 +246,7 @@
_startWindowSelectorDragging: function(event)
{
var position = event.pageX - this._parentElement.offsetLeft;
- this._overviewWindowSelector = new WebInspector.OverviewGrid.WindowSelector(this._parentElement, position, this._prefix);
+ this._overviewWindowSelector = new WebInspector.OverviewGrid.WindowSelector(this._parentElement, position);
return true;
},
@@ -440,15 +438,13 @@
/**
* @constructor
- * @param {string} prefix
*/
-WebInspector.OverviewGrid.WindowSelector = function(parent, position, prefix)
+WebInspector.OverviewGrid.WindowSelector = function(parent, position)
{
- this._prefix = prefix;
this._startPosition = position;
this._width = parent.offsetWidth;
this._windowSelector = document.createElement("div");
- this._windowSelector.className = prefix + "-window-selector";
+ this._windowSelector.className = "overview-grid-window-selector";
this._windowSelector.style.left = this._startPosition + "px";
this._windowSelector.style.right = this._width - this._startPosition + + "px";
parent.appendChild(this._windowSelector);
@@ -458,7 +454,7 @@
_createSelectorElement: function(parent, left, width, height)
{
var selectorElement = document.createElement("div");
- selectorElement.className = this._prefix + "-window-selector";
+ selectorElement.className = "overview-grid-window-selector";
selectorElement.style.left = left + "px";
selectorElement.style.width = width + "px";
selectorElement.style.top = "0px";
Modified: trunk/Source/WebCore/inspector/front-end/inspectorCommon.css (146329 => 146330)
--- trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2013-03-20 11:50:58 UTC (rev 146329)
+++ trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2013-03-20 11:51:27 UTC (rev 146330)
@@ -125,7 +125,57 @@
white-space: nowrap;
}
+.overview-grid-window-selector {
+ position: absolute;
+ top: 0;
+ bottom: 0;
+ background-color: rgba(125, 173, 217, 0.5);
+ z-index: 250;
+}
+.overview-grid-window {
+ background-color: white;
+ position: absolute;
+ left: 0;
+ right: 0;
+ top: 0;
+ bottom: 60px;
+ z-index: 150;
+}
+
+.overview-grid-dividers-background {
+ left: 0%;
+ right: 0%;
+ top: 0px;
+ bottom: 60px;
+ background-color: black;
+ position: absolute;
+}
+
+.overview-grid-window-rulers {
+ top: 0;
+ bottom: 0;
+ position: absolute;
+ opacity: 0.2;
+ border-right: 1px solid black;
+ border-left: 1px solid black;
+ z-index: 150;
+}
+
+.overview-grid-window-resizer {
+ position: absolute;
+ top: 0px;
+ bottom: 60px;
+ width: 5px;
+ margin-left: -3px;
+ margin-right: -2px;
+ background-color: rgb(153, 153, 153);
+ z-index: 500;
+ cursor: ew-resize;
+ -webkit-border-radius: 2px;
+ -webkit-box-shadow: white 1px 0 0, white -1px 0 0, white 0 1px 0, white 0 -1px 0;
+}
+
/* Network timing is shared between popover and network item view pane */
.network-timing-row {
Modified: trunk/Source/WebCore/inspector/front-end/timelinePanel.css (146329 => 146330)
--- trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2013-03-20 11:50:58 UTC (rev 146329)
+++ trunk/Source/WebCore/inspector/front-end/timelinePanel.css 2013-03-20 11:51:27 UTC (rev 146330)
@@ -88,65 +88,14 @@
pointer-events: auto;
}
-.timeline-window-selector {
- position: absolute;
- top: 0;
+.timeline-frame-overview .overview-grid-window {
bottom: 0;
- background-color: rgba(125, 173, 217, 0.5);
- z-index: 250;
}
-.timeline-overview-window {
- background-color: white;
- position: absolute;
- left: 0;
- right: 0;
- top: 0;
- bottom: 60px;
- z-index: 150;
-}
-
-.timeline-frame-overview .timeline-overview-window {
+.timeline-frame-overview .overview-grid-dividers-background {
bottom: 0;
}
-.timeline-overview-dividers-background {
- left: 0%;
- right: 0%;
- top: 0px;
- bottom: 60px;
- background-color: black;
- position: absolute;
-}
-
-.timeline-frame-overview .timeline-overview-dividers-background {
- bottom: 0;
-}
-
-.timeline-overview-window-rulers {
- top: 0;
- bottom: 0;
- position: absolute;
- opacity: 0.2;
- border-right: 1px solid black;
- border-left: 1px solid black;
- z-index: 150;
-}
-
-.timeline-window-resizer {
- position: absolute;
- top: 0px;
- bottom: 60px;
- width: 5px;
- margin-left: -3px;
- margin-right: -2px;
- background-color: rgb(153, 153, 153);
- z-index: 500;
- cursor: ew-resize;
- -webkit-border-radius: 2px;
- -webkit-box-shadow: white 1px 0 0, white -1px 0 0, white 0 1px 0, white 0 -1px 0;
-}
-
#timeline-overview-grid #resources-graphs {
position: absolute;
top: 0;
