Title: [146799] releases/WebKitGTK/webkit-2.0/Source/WebKit2
Revision
146799
Author
carlo...@webkit.org
Date
2013-03-25 12:57:13 -0700 (Mon, 25 Mar 2013)

Log Message

[WK2][GTK] MiniBrowser won't play video in <embed> tag
https://bugs.webkit.org/show_bug.cgi?id=113107

Reviewed by Martin Robinson.

The wrong clip region is used for windowed plugins, because it's
translated to window frame coords again.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange): Do not move
the current clip region.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.0/Source/WebKit2/ChangeLog (146798 => 146799)


--- releases/WebKitGTK/webkit-2.0/Source/WebKit2/ChangeLog	2013-03-25 19:45:41 UTC (rev 146798)
+++ releases/WebKitGTK/webkit-2.0/Source/WebKit2/ChangeLog	2013-03-25 19:57:13 UTC (rev 146799)
@@ -1,3 +1,17 @@
+2013-03-25  Carlos Garcia Campos  <cgar...@igalia.com>
+
+        [WK2][GTK] MiniBrowser won't play video in <embed> tag
+        https://bugs.webkit.org/show_bug.cgi?id=113107
+
+        Reviewed by Martin Robinson.
+
+        The wrong clip region is used for windowed plugins, because it's
+        translated to window frame coords again.
+
+        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+        (WebKit::NetscapePlugin::platformGeometryDidChange): Do not move
+        the current clip region.
+
 2013-03-25  Dominique Leuenberger  <dims...@opensuse.org>
 
         E: webkitgtk3 missing-sentinel Source/[...]/TestMain.cpp:47 g_build_filename takes a NULL sentinel.

Modified: releases/WebKitGTK/webkit-2.0/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (146798 => 146799)


--- releases/WebKitGTK/webkit-2.0/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp	2013-03-25 19:45:41 UTC (rev 146798)
+++ releases/WebKitGTK/webkit-2.0/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp	2013-03-25 19:57:13 UTC (rev 146799)
@@ -312,9 +312,7 @@
 #if PLATFORM(GTK)
         windowID = static_cast<uint64_t>(GDK_WINDOW_XID(gtk_plug_get_socket_window(GTK_PLUG(m_platformPluginWidget))));
 #endif
-        IntRect clipRect(m_clipRect);
-        clipRect.move(-m_frameRectInWindowCoordinates.x(), -m_frameRectInWindowCoordinates.y());
-        controller()->windowedPluginGeometryDidChange(m_frameRectInWindowCoordinates, clipRect, windowID);
+        controller()->windowedPluginGeometryDidChange(m_frameRectInWindowCoordinates, m_clipRect, windowID);
         return;
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to