Title: [146896] trunk
- Revision
- 146896
- Author
- morr...@google.com
- Date
- 2013-03-26 09:14:59 -0700 (Tue, 26 Mar 2013)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=113164
Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML
Source/WebCore:
These APIs also create new elements thus should have V8DeliverCustomElementCallbacks attribute.
Reviewed by Dimitri Glazkov.
Test: Updated lifecycle-ready-creation-api.html.
* html/HTMLElement.idl:
LayoutTests:
Reviewed by Dimitri Glazkov.
* fast/dom/custom/lifecycle-ready-creation-api-expected.txt:
* fast/dom/custom/lifecycle-ready-creation-api.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (146895 => 146896)
--- trunk/LayoutTests/ChangeLog 2013-03-26 16:10:02 UTC (rev 146895)
+++ trunk/LayoutTests/ChangeLog 2013-03-26 16:14:59 UTC (rev 146896)
@@ -1,3 +1,13 @@
+2013-03-26 Hajime Morrita <morr...@google.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=113164
+ Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML
+
+ Reviewed by Dimitri Glazkov.
+
+ * fast/dom/custom/lifecycle-ready-creation-api-expected.txt:
+ * fast/dom/custom/lifecycle-ready-creation-api.html:
+
2013-03-26 Jochen Eisinger <joc...@chromium.org>
Fix incorrect test name in content shell expectations
Modified: trunk/LayoutTests/fast/dom/custom/lifecycle-ready-creation-api-expected.txt (146895 => 146896)
--- trunk/LayoutTests/fast/dom/custom/lifecycle-ready-creation-api-expected.txt 2013-03-26 16:10:02 UTC (rev 146895)
+++ trunk/LayoutTests/fast/dom/custom/lifecycle-ready-creation-api-expected.txt 2013-03-26 16:14:59 UTC (rev 146896)
@@ -19,6 +19,8 @@
PASS importedBar.callbacksCalled is true
PASS importedBar.firstChild.callbacksCalled is true
PASS window.callbacksCalled is ['DIV', 'X-FOO']
+PASS window.callbacksCalled is ['X-FOO']
+PASS window.callbacksCalled is ['X-FOO']
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/dom/custom/lifecycle-ready-creation-api.html (146895 => 146896)
--- trunk/LayoutTests/fast/dom/custom/lifecycle-ready-creation-api.html 2013-03-26 16:10:02 UTC (rev 146895)
+++ trunk/LayoutTests/fast/dom/custom/lifecycle-ready-creation-api.html 2013-03-26 16:14:59 UTC (rev 146896)
@@ -56,6 +56,18 @@
shouldBeTrue("importedBar.firstChild.callbacksCalled");
shouldBe("window.callbacksCalled", "['DIV', 'X-FOO']");
+window.callbacksCalled = [];
+var toBeReplaced = document.createElement("div");
+document.body.appendChild(toBeReplaced);
+toBeReplaced.outerHTML = "<x-foo></x-foo>";
+shouldBe("window.callbacksCalled", "['X-FOO']");
+
+window.callbacksCalled = [];
+var insertionPlaceHolder = document.createElement("div");
+document.body.appendChild(insertionPlaceHolder);
+insertionPlaceHolder.insertAdjacentHTML("beforebegin", "<x-foo></x-foo>");
+shouldBe("window.callbacksCalled", "['X-FOO']");
+
</script>
<script src=""
</body>
Modified: trunk/Source/WebCore/ChangeLog (146895 => 146896)
--- trunk/Source/WebCore/ChangeLog 2013-03-26 16:10:02 UTC (rev 146895)
+++ trunk/Source/WebCore/ChangeLog 2013-03-26 16:14:59 UTC (rev 146896)
@@ -1,3 +1,16 @@
+2013-03-26 Hajime Morrita <morr...@google.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=113164
+ Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML
+
+ These APIs also create new elements thus should have V8DeliverCustomElementCallbacks attribute.
+
+ Reviewed by Dimitri Glazkov.
+
+ Test: Updated lifecycle-ready-creation-api.html.
+
+ * html/HTMLElement.idl:
+
2013-03-26 Ilya Tikhonovsky <loi...@chromium.org>
Unreviewed. WebInspector: remove unnecessary method.
Modified: trunk/Source/WebCore/html/HTMLElement.idl (146895 => 146896)
--- trunk/Source/WebCore/html/HTMLElement.idl 2013-03-26 16:10:02 UTC (rev 146895)
+++ trunk/Source/WebCore/html/HTMLElement.idl 2013-03-26 16:14:59 UTC (rev 146896)
@@ -43,7 +43,7 @@
setter raises(DOMException);
[TreatNullAs=NullString] attribute DOMString innerText
setter raises(DOMException);
- [TreatNullAs=NullString] attribute DOMString outerHTML
+ [TreatNullAs=NullString, V8DeliverCustomElementCallbacks] attribute DOMString outerHTML
setter raises(DOMException);
[TreatNullAs=NullString] attribute DOMString outerText
setter raises(DOMException);
@@ -51,6 +51,7 @@
Element insertAdjacentElement(in [Optional=DefaultIsUndefined] DOMString where,
in [Optional=DefaultIsUndefined] Element element)
raises(DOMException);
+ [V8DeliverCustomElementCallbacks]
void insertAdjacentHTML(in [Optional=DefaultIsUndefined] DOMString where,
in [Optional=DefaultIsUndefined] DOMString html)
raises(DOMException);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
