Diff
Modified: trunk/Source/WebCore/ChangeLog (147028 => 147029)
--- trunk/Source/WebCore/ChangeLog 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/ChangeLog 2013-03-28 00:13:12 UTC (rev 147029)
@@ -1,3 +1,40 @@
+2013-03-27 Charles Wei <charles....@torchmobile.com.cn>
+
+ Remove build warning for unused function parameters in indexeddb.
+ https://bugs.webkit.org/show_bug.cgi?id=113043
+
+ Reviewed by Tony Chang.
+
+ No new tests, just remove build warning.
+
+ * Modules/indexeddb/IDBCallbacks.h:
+ (WebCore::IDBCallbacks::onBlocked):
+ (WebCore::IDBCallbacks::onUpgradeNeeded):
+ * Modules/indexeddb/IDBCursor.cpp:
+ (WebCore::IDBCursor::stringToDirection):
+ * Modules/indexeddb/IDBCursor.h:
+ (IDBCursor):
+ * Modules/indexeddb/IDBCursorBackendImpl.cpp:
+ (WebCore::IDBCursorBackendImpl::prefetchReset):
+ * Modules/indexeddb/IDBDatabase.cpp:
+ (WebCore::IDBDatabase::transaction):
+ * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
+ (WebCore::IDBDatabaseBackendImpl::setIndexesReady):
+ * Modules/indexeddb/IDBIndex.cpp:
+ (WebCore::IDBIndex::openCursor):
+ (WebCore::IDBIndex::openKeyCursor):
+ * Modules/indexeddb/IDBLevelDBCoding.cpp:
+ (IDBLevelDBCoding):
+ * Modules/indexeddb/IDBObjectStore.cpp:
+ (WebCore):
+ (WebCore::IDBObjectStore::openCursor):
+ * Modules/indexeddb/IDBTransaction.cpp:
+ (WebCore::IDBTransaction::stringToMode):
+ * Modules/indexeddb/IDBTransaction.h:
+ (IDBTransaction):
+ * inspector/InspectorIndexedDBAgent.cpp:
+ (WebCore):
+
2013-03-27 Sergey Ryazanov <se...@chromium.org>
REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBCallbacks.h (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBCallbacks.h 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBCallbacks.h 2013-03-28 00:13:12 UTC (rev 147029)
@@ -68,9 +68,9 @@
// From IDBCursor.advance()/continue()
virtual void onSuccessWithPrefetch(const Vector<RefPtr<IDBKey> >& keys, const Vector<RefPtr<IDBKey> >& primaryKeys, const Vector<RefPtr<SharedBuffer> >& values) = 0;
// From IDBFactory.open()/deleteDatabase()
- virtual void onBlocked(int64_t existingVersion) { ASSERT_NOT_REACHED(); }
+ virtual void onBlocked(int64_t /* existingVersion */) { ASSERT_NOT_REACHED(); }
// From IDBFactory.open()
- virtual void onUpgradeNeeded(int64_t oldVersion, PassRefPtr<IDBDatabaseBackendInterface>, const IDBDatabaseMetadata&) { ASSERT_NOT_REACHED(); }
+ virtual void onUpgradeNeeded(int64_t /* oldVersion */, PassRefPtr<IDBDatabaseBackendInterface>, const IDBDatabaseMetadata&) { ASSERT_NOT_REACHED(); }
virtual void onSuccess(PassRefPtr<IDBDatabaseBackendInterface>, const IDBDatabaseMetadata&) { ASSERT_NOT_REACHED(); }
};
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBCursor.cpp 2013-03-28 00:13:12 UTC (rev 147029)
@@ -297,7 +297,7 @@
return index->objectStore();
}
-IndexedDB::CursorDirection IDBCursor::stringToDirection(const String& directionString, ScriptExecutionContext* context, ExceptionCode& ec)
+IndexedDB::CursorDirection IDBCursor::stringToDirection(const String& directionString, ExceptionCode& ec)
{
if (directionString == IDBCursor::directionNext())
return IndexedDB::CursorNext;
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBCursor.h (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBCursor.h 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBCursor.h 2013-03-28 00:13:12 UTC (rev 147029)
@@ -55,7 +55,7 @@
static const AtomicString& directionPrev();
static const AtomicString& directionPrevUnique();
- static IndexedDB::CursorDirection stringToDirection(const String& modeString, ScriptExecutionContext*, ExceptionCode&);
+ static IndexedDB::CursorDirection stringToDirection(const String& modeString, ExceptionCode&);
static const AtomicString& directionToString(unsigned short mode);
static PassRefPtr<IDBCursor> create(PassRefPtr<IDBCursorBackendInterface>, IndexedDB::CursorDirection, IDBRequest*, IDBAny* source, IDBTransaction*);
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp 2013-03-28 00:13:12 UTC (rev 147029)
@@ -220,7 +220,7 @@
m_callbacks->onSuccessWithPrefetch(foundKeys, foundPrimaryKeys, foundValues);
}
-void IDBCursorBackendImpl::prefetchReset(int usedPrefetches, int unusedPrefetches)
+void IDBCursorBackendImpl::prefetchReset(int usedPrefetches, int)
{
IDB_TRACE("IDBCursorBackendImpl::prefetchReset");
m_cursor = m_savedCursor;
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp 2013-03-28 00:13:12 UTC (rev 147029)
@@ -230,7 +230,7 @@
return 0;
}
- IndexedDB::TransactionMode mode = IDBTransaction::stringToMode(modeString, context, ec);
+ IndexedDB::TransactionMode mode = IDBTransaction::stringToMode(modeString, ec);
if (ec)
return 0;
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp 2013-03-28 00:13:12 UTC (rev 147029)
@@ -915,7 +915,7 @@
}
}
-void IDBDatabaseBackendImpl::setIndexesReady(int64_t transactionId, int64_t objectStoreId, const Vector<int64_t>& indexIds)
+void IDBDatabaseBackendImpl::setIndexesReady(int64_t transactionId, int64_t, const Vector<int64_t>& indexIds)
{
IDB_TRACE("IDBObjectStoreBackendImpl::setIndexesReady");
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBIndex.cpp 2013-03-28 00:13:12 UTC (rev 147029)
@@ -67,7 +67,7 @@
ec = IDBDatabaseException::TransactionInactiveError;
return 0;
}
- IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, context, ec);
+ IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, ec);
if (ec)
return 0;
@@ -122,7 +122,7 @@
ec = IDBDatabaseException::TransactionInactiveError;
return 0;
}
- IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, context, ec);
+ IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, ec);
if (ec)
return 0;
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp 2013-03-28 00:13:12 UTC (rev 147029)
@@ -726,7 +726,7 @@
namespace {
template<typename KeyType>
-int compare(const LevelDBSlice& a, const LevelDBSlice& b, bool ignoreDuplicates, bool& ok)
+int compare(const LevelDBSlice& a, const LevelDBSlice& b, bool, bool& ok)
{
KeyType keyA;
KeyType keyB;
@@ -749,7 +749,7 @@
}
template<>
-int compare<ExistsEntryKey>(const LevelDBSlice& a, const LevelDBSlice& b, bool ignoreDuplicates, bool& ok)
+int compare<ExistsEntryKey>(const LevelDBSlice& a, const LevelDBSlice& b, bool, bool& ok)
{
KeyPrefix prefixA;
KeyPrefix prefixB;
@@ -772,7 +772,7 @@
}
template<>
-int compare<ObjectStoreDataKey>(const LevelDBSlice& a, const LevelDBSlice& b, bool ignoreDuplicates, bool& ok)
+int compare<ObjectStoreDataKey>(const LevelDBSlice& a, const LevelDBSlice& b, bool, bool& ok)
{
KeyPrefix prefixA;
KeyPrefix prefixB;
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp 2013-03-28 00:13:12 UTC (rev 147029)
@@ -320,7 +320,7 @@
{
}
- virtual void handleEvent(ScriptExecutionContext* context, Event* event)
+ virtual void handleEvent(ScriptExecutionContext*, Event* event)
{
ASSERT(event->type() == eventNames().successEvent);
EventTarget* target = event->target();
@@ -504,7 +504,7 @@
ec = IDBDatabaseException::TransactionInactiveError;
return 0;
}
- IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, context, ec);
+ IndexedDB::CursorDirection direction = IDBCursor::stringToDirection(directionString, ec);
if (ec)
return 0;
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp 2013-03-28 00:13:12 UTC (rev 147029)
@@ -336,7 +336,7 @@
return m_hasPendingActivity && !m_contextStopped;
}
-IndexedDB::TransactionMode IDBTransaction::stringToMode(const String& modeString, ScriptExecutionContext* context, ExceptionCode& ec)
+IndexedDB::TransactionMode IDBTransaction::stringToMode(const String& modeString, ExceptionCode& ec)
{
if (modeString.isNull()
|| modeString == IDBTransaction::modeReadOnly())
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h (147028 => 147029)
--- trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.h 2013-03-28 00:13:12 UTC (rev 147029)
@@ -62,7 +62,7 @@
static const AtomicString& modeReadOnlyLegacy();
static const AtomicString& modeReadWriteLegacy();
- static IndexedDB::TransactionMode stringToMode(const String&, ScriptExecutionContext*, ExceptionCode&);
+ static IndexedDB::TransactionMode stringToMode(const String&, ExceptionCode&);
static const AtomicString& modeToString(IndexedDB::TransactionMode);
IDBDatabaseBackendInterface* backendDB() const;
Modified: trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp (147028 => 147029)
--- trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2013-03-28 00:11:41 UTC (rev 147028)
+++ trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp 2013-03-28 00:13:12 UTC (rev 147029)
@@ -202,7 +202,7 @@
RefPtr<ExecutableWithDatabase> m_executableWithDatabase;
};
-void ExecutableWithDatabase::start(IDBFactory* idbFactory, SecurityOrigin* securityOrigin, const String& databaseName)
+void ExecutableWithDatabase::start(IDBFactory* idbFactory, SecurityOrigin*, const String& databaseName)
{
RefPtr<OpenDatabaseCallback> callback = OpenDatabaseCallback::create(this);
ExceptionCode ec = 0;
