Title: [147523] trunk/Source/WebCore
- Revision
- 147523
- Author
- cfleiz...@apple.com
- Date
- 2013-04-02 23:56:15 -0700 (Tue, 02 Apr 2013)
Log Message
clean up static casts in WebAccessibilityObjectWrapperMac.mm to methods like toAccessibilityList()
https://bugs.webkit.org/show_bug.cgi?id=113828
Reviewed by Tim Horton.
static_cast changed to toAccessibilityList().
* accessibility/AccessibilityList.h:
(WebCore::toAccessibilityList):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (147522 => 147523)
--- trunk/Source/WebCore/ChangeLog 2013-04-03 06:52:47 UTC (rev 147522)
+++ trunk/Source/WebCore/ChangeLog 2013-04-03 06:56:15 UTC (rev 147523)
@@ -1,3 +1,18 @@
+2013-04-02 Chris Fleizach <cfleiz...@apple.com>
+
+ clean up static casts in WebAccessibilityObjectWrapperMac.mm to methods like toAccessibilityList()
+ https://bugs.webkit.org/show_bug.cgi?id=113828
+
+ Reviewed by Tim Horton.
+
+ static_cast changed to toAccessibilityList().
+
+ * accessibility/AccessibilityList.h:
+ (WebCore::toAccessibilityList):
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper subrole]):
+ (-[WebAccessibilityObjectWrapper roleDescription]):
+
2013-04-02 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r147370.
Modified: trunk/Source/WebCore/accessibility/AccessibilityList.h (147522 => 147523)
--- trunk/Source/WebCore/accessibility/AccessibilityList.h 2013-04-03 06:52:47 UTC (rev 147522)
+++ trunk/Source/WebCore/accessibility/AccessibilityList.h 2013-04-03 06:56:15 UTC (rev 147523)
@@ -51,6 +51,12 @@
virtual bool computeAccessibilityIsIgnored() const;
};
+inline AccessibilityList* toAccessibilityList(AccessibilityObject* object)
+{
+ ASSERT_WITH_SECURITY_IMPLICATION(!object || object->isList());
+ return static_cast<AccessibilityList*>(object);
+}
+
} // namespace WebCore
#endif // AccessibilityList_h
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (147522 => 147523)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2013-04-03 06:52:47 UTC (rev 147522)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2013-04-03 06:56:15 UTC (rev 147523)
@@ -1686,7 +1686,7 @@
return NSAccessibilityOutlineRowSubrole;
if (m_object->isList()) {
- AccessibilityList* listObject = static_cast<AccessibilityList*>(m_object);
+ AccessibilityList* listObject = toAccessibilityList(m_object);
if (listObject->isUnorderedList() || listObject->isOrderedList())
return NSAccessibilityContentListSubrole;
if (listObject->isDescriptionList())
@@ -1882,7 +1882,7 @@
// Only returning for DL (not UL or OL) because description changed with HTML5 from 'definition list' to
// superset 'description list' and does not return the same values in AX API on some OS versions.
if (m_object->isList()) {
- AccessibilityList* listObject = static_cast<AccessibilityList*>(m_object);
+ AccessibilityList* listObject = toAccessibilityList(m_object);
if (listObject->isDescriptionList())
return AXDescriptionListText();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
