Title: [148118] trunk/Source/WebCore
Revision
148118
Author
par...@webkit.org
Date
2013-04-10 11:50:15 -0700 (Wed, 10 Apr 2013)

Log Message

Replace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114352

Reviewed by Timothy Hatcher.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

* page/Console.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (148117 => 148118)


--- trunk/Source/WebCore/ChangeLog	2013-04-10 18:48:01 UTC (rev 148117)
+++ trunk/Source/WebCore/ChangeLog	2013-04-10 18:50:15 UTC (rev 148118)
@@ -1,3 +1,14 @@
+2013-04-10  Patrick Gansterer  <par...@webkit.org>
+
+        Replace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditional attribute
+        https://bugs.webkit.org/show_bug.cgi?id=114352
+
+        Reviewed by Timothy Hatcher.
+
+        The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.
+
+        * page/Console.idl:
+
 2013-04-10  Alexandru Chiculita  <ach...@adobe.com>
 
         Layers with opacity and blur filters are reported as opaque to the compositor

Modified: trunk/Source/WebCore/page/Console.idl (148117 => 148118)


--- trunk/Source/WebCore/page/Console.idl	2013-04-10 18:48:01 UTC (rev 148117)
+++ trunk/Source/WebCore/page/Console.idl	2013-04-10 18:50:15 UTC (rev 148118)
@@ -44,14 +44,12 @@
     [CallWith=ScriptArguments|ScriptState] void count();
     [CallWith=ScriptArguments] void markTimeline();
 
-#if defined(ENABLE_JAVASCRIPT_DEBUGGER) && ENABLE_JAVASCRIPT_DEBUGGER
     // As per spec: http://www.w3.org/TR/WebIDL/#idl-sequence
     // "Sequences must not be used as the type of an attribute, constant or exception field."
     // FIXME: this will lead to BUG console.profiles !== console.profiles as profile will always returns new array.
-    readonly attribute ScriptProfile[] profiles;
-    [Custom] void profile(in DOMString title);
-    [Custom] void profileEnd(in DOMString title);
-#endif
+    [Conditional=_javascript__DEBUGGER] readonly attribute ScriptProfile[] profiles;
+    [Conditional=_javascript__DEBUGGER, Custom] void profile(in DOMString title);
+    [Conditional=_javascript__DEBUGGER, Custom] void profileEnd(in DOMString title);
 
     void time(in [TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString title);
     [CallWith=ScriptState] void timeEnd(in [TreatNullAs=NullString, TreatUndefinedAs=NullString] DOMString title);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to