Title: [148277] trunk/Source/WebKit/blackberry
- Revision
- 148277
- Author
- commit-qu...@webkit.org
- Date
- 2013-04-12 07:05:19 -0700 (Fri, 12 Apr 2013)
Log Message
[BlackBerry] Crash running layout tests
https://bugs.webkit.org/show_bug.cgi?id=114503
Patch by Carlos Garcia Campos <cgar...@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.
Hit an assertion in ~GuardedPointerBase when DRT is
deleted. DumpRenderTree class derives from
BlackBerry::Platform::LayoutTestClient that derives from
BlackBerry::Platform::GuardedPointerBase, so the DRT pointer
should no be released with delete but with
BlackBerry::Platform::deleteGuardedObject().
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (148276 => 148277)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-04-12 13:50:58 UTC (rev 148276)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-04-12 14:05:19 UTC (rev 148277)
@@ -490,7 +490,7 @@
m_proximityDetector = 0;
#if !defined(PUBLIC_BUILD) || !PUBLIC_BUILD
- delete m_dumpRenderTree;
+ BlackBerry::Platform::deleteGuardedObject(static_cast<DumpRenderTree*>(m_dumpRenderTree));
m_dumpRenderTree = 0;
#endif
Modified: trunk/Source/WebKit/blackberry/ChangeLog (148276 => 148277)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-04-12 13:50:58 UTC (rev 148276)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-04-12 14:05:19 UTC (rev 148277)
@@ -1,5 +1,22 @@
2013-04-12 Carlos Garcia Campos <cgar...@igalia.com>
+ [BlackBerry] Crash running layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=114503
+
+ Reviewed by Xan Lopez.
+
+ Hit an assertion in ~GuardedPointerBase when DRT is
+ deleted. DumpRenderTree class derives from
+ BlackBerry::Platform::LayoutTestClient that derives from
+ BlackBerry::Platform::GuardedPointerBase, so the DRT pointer
+ should no be released with delete but with
+ BlackBerry::Platform::deleteGuardedObject().
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
+
+2013-04-12 Carlos Garcia Campos <cgar...@igalia.com>
+
[BlackBerry] Crash running layout tests when WebPage is destroyed
https://bugs.webkit.org/show_bug.cgi?id=114497
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
