Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPageClient.h (148450 => 148451)
--- trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2013-04-15 17:59:50 UTC (rev 148450)
+++ trunk/Source/WebKit/blackberry/Api/WebPageClient.h 2013-04-15 18:02:55 UTC (rev 148451)
@@ -171,7 +171,7 @@
virtual void openPopupList(bool multiple, int size, const ScopeArray<BlackBerry::Platform::String>& labels, const bool* enableds, const int* itemType, const bool* selecteds) = 0;
virtual bool chooseFilenames(bool allowMultiple, const SharedArray<BlackBerry::Platform::String>& acceptTypes, const SharedArray<BlackBerry::Platform::String>& initialFiles, const BlackBerry::Platform::String& capture, SharedArray<BlackBerry::Platform::String>& chosenFiles) = 0;
- virtual WebPage* createWindow(int x, int y, int width, int height, unsigned flags, const BlackBerry::Platform::String& url, const BlackBerry::Platform::String& windowName) = 0;
+ virtual WebPage* createWindow(int x, int y, int width, int height, unsigned flags, const BlackBerry::Platform::String& url, const BlackBerry::Platform::String& windowName, bool userGesture) = 0;
virtual void scheduleCloseWindow() = 0;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (148450 => 148451)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-04-15 17:59:50 UTC (rev 148450)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-04-15 18:02:55 UTC (rev 148451)
@@ -1,3 +1,21 @@
+2013-04-15 Andy Chen <andc...@blackberry.com>
+
+ [BlackBerry] Forward userGesture when creating a new window
+ https://bugs.webkit.org/show_bug.cgi?id=114622
+
+ Reviewed by Rob Buis.
+
+ Client could use this info to decide whether the popup should
+ be blocked.
+ PR 291898
+ Reviewed internally by Mike Fenton
+
+ * Api/WebPageClient.h:
+ * WebCoreSupport/ChromeClientBlackBerry.cpp:
+ (WebCore::ChromeClientBlackBerry::createWindow):
+ * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+ (WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
+
2013-04-15 Xan Lopez <xlo...@igalia.com>
[BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (148450 => 148451)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2013-04-15 17:59:50 UTC (rev 148450)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2013-04-15 18:02:55 UTC (rev 148451)
@@ -260,7 +260,7 @@
if (features.dialog)
flags |= WebPageClient::FlagWindowIsDialog;
- WebPage* webPage = m_webPagePrivate->m_client->createWindow(x, y, width, height, flags, url.string(), request.frameName());
+ WebPage* webPage = m_webPagePrivate->m_client->createWindow(x, y, width, height, flags, url.string(), request.frameName(), ScriptController::processingUserGesture());
if (!webPage)
return 0;
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (148450 => 148451)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2013-04-15 17:59:50 UTC (rev 148450)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2013-04-15 18:02:55 UTC (rev 148451)
@@ -936,7 +936,7 @@
Frame* FrameLoaderClientBlackBerry::dispatchCreatePage(const NavigationAction& navigation)
{
- WebPage* webPage = m_webPagePrivate->m_client->createWindow(0, 0, -1, -1, WebPageClient::FlagWindowDefault, navigation.url().string(), BlackBerry::Platform::String::emptyString());
+ WebPage* webPage = m_webPagePrivate->m_client->createWindow(0, 0, -1, -1, WebPageClient::FlagWindowDefault, navigation.url().string(), BlackBerry::Platform::String::emptyString(), ScriptController::processingUserGesture());
if (!webPage)
return 0;
