Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (148666 => 148667)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-04-18 12:02:30 UTC (rev 148666)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-04-18 12:43:55 UTC (rev 148667)
@@ -1,3 +1,36 @@
+2013-04-18 Xuefei Ren <x...@blackberry.com>
+
+ removei build warning (unused parameter )
+ https://bugs.webkit.org/show_bug.cgi?id=114670
+
+ Reviewed by Rob Buis.
+
+ remove warning (unused parameter ) in
+ Source/WebKit/blackberry/WebCoreSupport
+
+ * WebCoreSupport/ChromeClientBlackBerry.cpp:
+ (WebCore::ChromeClientBlackBerry::mouseDidMoveOverElement):
+ (WebCore::ChromeClientBlackBerry::needTouchEvents):
+ (WebCore::ChromeClientBlackBerry::reachedMaxAppCacheSize):
+ * WebCoreSupport/DatePickerClient.cpp:
+ (WebCore::DatePickerClient::setValue):
+ * WebCoreSupport/EditorClientBlackBerry.cpp:
+ (WebCore::EditorClientBlackBerry::checkSpellingOfString):
+ (WebCore::EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord):
+ * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+ (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
+ (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveResponse):
+ (WebCore::FrameLoaderClientBlackBerry::shouldUseCredentialStorage):
+ * WebCoreSupport/InspectorClientBlackBerry.cpp:
+ (WebCore::InspectorClientBlackBerry::updateInspectorStateCookie):
+ * WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
+ (WebCore::NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange):
+ (WebCore::NetworkInfoClientBlackBerry::onCurrentCellularTypeChange):
+ * WebCoreSupport/SelectPopupClient.cpp:
+ (WebCore::SelectPopupClient::generateHTML):
+ * WebCoreSupport/UserMediaClientImpl.cpp:
+ (WebCore::UserMediaClientImpl::requestUserMedia):
+
2013-04-17 Nima Ghanavatian <nghanavat...@blackberry.com>
Clean up spellcheck state when changing focus.
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (148666 => 148667)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2013-04-18 12:02:30 UTC (rev 148666)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2013-04-18 12:43:55 UTC (rev 148667)
@@ -445,7 +445,7 @@
return windowPoint;
}
-void ChromeClientBlackBerry::mouseDidMoveOverElement(const HitTestResult& result, unsigned int modifierFlags)
+void ChromeClientBlackBerry::mouseDidMoveOverElement(const HitTestResult&, unsigned)
{
notImplemented();
}
@@ -667,12 +667,12 @@
}
#if ENABLE(TOUCH_EVENTS)
-void ChromeClientBlackBerry::needTouchEvents(bool value)
+void ChromeClientBlackBerry::needTouchEvents(bool)
{
}
#endif
-void ChromeClientBlackBerry::reachedMaxAppCacheSize(int64_t spaceNeeded)
+void ChromeClientBlackBerry::reachedMaxAppCacheSize(int64_t)
{
notImplemented();
}
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp (148666 => 148667)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp 2013-04-18 12:02:30 UTC (rev 148666)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp 2013-04-18 12:43:55 UTC (rev 148667)
@@ -138,7 +138,7 @@
closePopup();
}
-void DatePickerClient::setValue(const String& value)
+void DatePickerClient::setValue(const String&)
{
notImplemented();
}
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp (148666 => 148667)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp 2013-04-18 12:02:30 UTC (rev 148666)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.cpp 2013-04-18 12:43:55 UTC (rev 148667)
@@ -563,12 +563,12 @@
notImplemented();
}
-void EditorClientBlackBerry::checkSpellingOfString(const UChar* text, int textLength, int* misspellLocation, int* misspellLength)
+void EditorClientBlackBerry::checkSpellingOfString(const UChar*, int, int*, int*)
{
notImplemented();
}
-WTF::String EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord(const WTF::String& misspelledWord)
+WTF::String EditorClientBlackBerry::getAutoCorrectSuggestionForMisspelledWord(const WTF::String&)
{
notImplemented();
return WTF::String();
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (148666 => 148667)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2013-04-18 12:02:30 UTC (rev 148666)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp 2013-04-18 12:43:55 UTC (rev 148667)
@@ -264,7 +264,7 @@
delayPolicyCheckUntilFragmentExists(fragment, function);
}
-void FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function, const NavigationAction&, const ResourceRequest& request, PassRefPtr<FormState>, const String& frameName)
+void FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function, const NavigationAction&, const ResourceRequest& request, PassRefPtr<FormState>, const String&)
{
if (ScriptController::processingUserGesture() && !m_webPagePrivate->m_pluginMayOpenNewTab) {
(m_frame->loader()->policyChecker()->*function)(PolicyIgnore);
@@ -503,7 +503,7 @@
m_wasProvisionalLoadTriggeredByUserGesture = ScriptController::processingUserGesture();
}
-void FrameLoaderClientBlackBerry::dispatchDidReceiveResponse(DocumentLoader*, unsigned long identifier, const ResourceResponse& response)
+void FrameLoaderClientBlackBerry::dispatchDidReceiveResponse(DocumentLoader*, unsigned long, const ResourceResponse& response)
{
if (m_webPagePrivate->m_dumpRenderTree)
m_webPagePrivate->m_dumpRenderTree->didReceiveResponseForFrame(m_frame, response);
@@ -1009,7 +1009,7 @@
}
}
-bool FrameLoaderClientBlackBerry::shouldUseCredentialStorage(DocumentLoader* loader, long unsigned identifier)
+bool FrameLoaderClientBlackBerry::shouldUseCredentialStorage(DocumentLoader*, long unsigned)
{
#if ENABLE(BLACKBERRY_CREDENTIAL_PERSIST)
if (m_frame->page()->settings()->privateBrowsingEnabled())
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp (148666 => 148667)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp 2013-04-18 12:02:30 UTC (rev 148666)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp 2013-04-18 12:43:55 UTC (rev 148667)
@@ -103,7 +103,7 @@
return true;
}
-void InspectorClientBlackBerry::updateInspectorStateCookie(const String& cookie)
+void InspectorClientBlackBerry::updateInspectorStateCookie(const String&)
{
// If this is implemented, we should override and return true in InspectorStateClient::supportsInspectorStateUpdates().
notImplemented();
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/NetworkInfoClientBlackBerry.cpp (148666 => 148667)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/NetworkInfoClientBlackBerry.cpp 2013-04-18 12:02:30 UTC (rev 148666)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/NetworkInfoClientBlackBerry.cpp 2013-04-18 12:43:55 UTC (rev 148667)
@@ -99,7 +99,7 @@
return false;
}
-void NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange(BlackBerry::Platform::InternalNetworkConnectionType newInternalNetworkType)
+void NetworkInfoClientBlackBerry::onCurrentNetworkTypeChange(BlackBerry::Platform::InternalNetworkConnectionType)
{
if (m_isActive) {
RefPtr<NetworkInfo> newNetworkInfo = NetworkInfo::create(bandwidth(), metered());
@@ -107,7 +107,7 @@
}
}
-void NetworkInfoClientBlackBerry::onCurrentCellularTypeChange(BlackBerry::Platform::InternalCellularConnectionType newCellularType)
+void NetworkInfoClientBlackBerry::onCurrentCellularTypeChange(BlackBerry::Platform::InternalCellularConnectionType)
{
// Only dispatch to listeners if the current type is cellular.
if (BlackBerry::Platform::NetworkInfo::instance()->getCurrentNetworkType() == BlackBerry::Platform::NetworkTypeCellular && m_isActive) {
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp (148666 => 148667)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp 2013-04-18 12:02:30 UTC (rev 148666)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp 2013-04-18 12:43:55 UTC (rev 148667)
@@ -64,7 +64,7 @@
generateHTML(multiple, size, labels, enableds, itemType, selecteds);
}
-void SelectPopupClient::generateHTML(bool multiple, int size, const ScopeArray<BlackBerry::Platform::String>& labels, bool* enableds,
+void SelectPopupClient::generateHTML(bool, int size, const ScopeArray<BlackBerry::Platform::String>& labels, bool* enableds,
const int* itemType, bool* selecteds)
{
StringBuilder source;
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp (148666 => 148667)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp 2013-04-18 12:02:30 UTC (rev 148666)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/UserMediaClientImpl.cpp 2013-04-18 12:43:55 UTC (rev 148667)
@@ -113,7 +113,7 @@
delete this;
}
-void UserMediaClientImpl::requestUserMedia(PassRefPtr<UserMediaRequest> prpRequest, const MediaStreamSourceVector& audioSources, const MediaStreamSourceVector& videoSources)
+void UserMediaClientImpl::requestUserMedia(PassRefPtr<UserMediaRequest> prpRequest, const MediaStreamSourceVector&, const MediaStreamSourceVector&)
{
UserMediaRequest* request = prpRequest.get();
OwnPtr<WebUserMediaRequestClientImpl> requestClient = adoptPtr(new WebUserMediaRequestClientImpl(prpRequest));
