Title: [148685] trunk/Source/WebKit/blackberry
Revision
148685
Author
commit-qu...@webkit.org
Date
2013-04-18 10:55:21 -0700 (Thu, 18 Apr 2013)

Log Message

[BlackBerry] Should pass through an actual error code when calling notifyLoadFinished
https://bugs.webkit.org/show_bug.cgi?id=114815

Patch by Ed Baker <edba...@blackberry.com> on 2013-04-18
Reviewed by Rob Buis.

PR #318079

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::postProgressFinishedNotification):

Modified Paths

Diff

Modified: trunk/Source/WebKit/blackberry/ChangeLog (148684 => 148685)


--- trunk/Source/WebKit/blackberry/ChangeLog	2013-04-18 17:50:59 UTC (rev 148684)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2013-04-18 17:55:21 UTC (rev 148685)
@@ -1,3 +1,15 @@
+2013-04-18  Ed Baker  <edba...@blackberry.com>
+
+        [BlackBerry] Should pass through an actual error code when calling notifyLoadFinished
+        https://bugs.webkit.org/show_bug.cgi?id=114815
+
+        Reviewed by Rob Buis.
+
+        PR #318079
+
+        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
+        (WebCore::FrameLoaderClientBlackBerry::postProgressFinishedNotification):
+
 2013-04-18  Xuefei Ren  <x...@blackberry.com>
 
         remove build warning(unused parameter)

Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp (148684 => 148685)


--- trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp	2013-04-18 17:50:59 UTC (rev 148684)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp	2013-04-18 17:55:21 UTC (rev 148685)
@@ -901,8 +901,7 @@
     // we may need to call readyToRender now.
     readyToRender(false);
 
-    // FIXME: Send up a real status code.
-    m_webPagePrivate->m_client->notifyLoadFinished(m_loadError.isNull() ? 0 : -1);
+    m_webPagePrivate->m_client->notifyLoadFinished(m_loadError.isNull() ? 0 : m_loadError.errorCode());
 
     // Notify plugins that are waiting for the page to fully load before starting that
     // the load has completed.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to