Title: [149171] trunk/LayoutTests
- Revision
- 149171
- Author
- ch.du...@sisa.samsung.com
- Date
- 2013-04-26 02:16:34 -0700 (Fri, 26 Apr 2013)
Log Message
[Qt] REGRESSION(r149001): It made two fast/dom/DeviceMotion tests fail.
https://bugs.webkit.org/show_bug.cgi?id=115235
Reviewed by Kentaro Hara.
Update window-property.html test cases for DeviceMotion and DeviceOrientation.
The global constructors are no longer enumerable after r149001.
* fast/dom/DeviceMotion/script-tests/window-property.js:
* fast/dom/DeviceMotion/window-property-expected.txt:
* fast/dom/DeviceOrientation/script-tests/window-property.js:
* fast/dom/DeviceOrientation/window-property-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (149170 => 149171)
--- trunk/LayoutTests/ChangeLog 2013-04-26 07:29:19 UTC (rev 149170)
+++ trunk/LayoutTests/ChangeLog 2013-04-26 09:16:34 UTC (rev 149171)
@@ -1,3 +1,18 @@
+2013-04-26 Christophe Dumez <ch.du...@sisa.samsung.com>
+
+ [Qt] REGRESSION(r149001): It made two fast/dom/DeviceMotion tests fail.
+ https://bugs.webkit.org/show_bug.cgi?id=115235
+
+ Reviewed by Kentaro Hara.
+
+ Update window-property.html test cases for DeviceMotion and DeviceOrientation.
+ The global constructors are no longer enumerable after r149001.
+
+ * fast/dom/DeviceMotion/script-tests/window-property.js:
+ * fast/dom/DeviceMotion/window-property-expected.txt:
+ * fast/dom/DeviceOrientation/script-tests/window-property.js:
+ * fast/dom/DeviceOrientation/window-property-expected.txt:
+
2013-04-25 Mihnea Ovidenie <mih...@adobe.com>
[CSS Regions] Hit testing is broken for absolutely positioned regions that have overflow: hidden
Modified: trunk/LayoutTests/fast/dom/DeviceMotion/script-tests/window-property.js (149170 => 149171)
--- trunk/LayoutTests/fast/dom/DeviceMotion/script-tests/window-property.js 2013-04-26 07:29:19 UTC (rev 149170)
+++ trunk/LayoutTests/fast/dom/DeviceMotion/script-tests/window-property.js 2013-04-26 09:16:34 UTC (rev 149171)
@@ -1,17 +1,8 @@
description("Tests that the window.DeviceMotionEvent and window.ondevicemotion properties are present.");
-function hasDeviceMotionEventProperty()
-{
- for (var property in window) {
- if (property == "DeviceMotionEvent")
- return true;
- }
- return false;
-}
-
shouldBeTrue("typeof window.DeviceMotionEvent == 'object'");
shouldBeFalse("typeof window.DeviceMotionEvent == 'function'");
-shouldBeTrue("hasDeviceMotionEventProperty()");
+shouldBeFalse("window.propertyIsEnumerable('DeviceMotionEvent')");
shouldBeTrue("'DeviceMotionEvent' in window");
shouldBeTrue("window.hasOwnProperty('DeviceMotionEvent')");
Modified: trunk/LayoutTests/fast/dom/DeviceMotion/window-property-expected.txt (149170 => 149171)
--- trunk/LayoutTests/fast/dom/DeviceMotion/window-property-expected.txt 2013-04-26 07:29:19 UTC (rev 149170)
+++ trunk/LayoutTests/fast/dom/DeviceMotion/window-property-expected.txt 2013-04-26 09:16:34 UTC (rev 149171)
@@ -5,7 +5,7 @@
PASS typeof window.DeviceMotionEvent == 'object' is true
PASS typeof window.DeviceMotionEvent == 'function' is false
-PASS hasDeviceMotionEventProperty() is true
+PASS window.propertyIsEnumerable('DeviceMotionEvent') is false
PASS 'DeviceMotionEvent' in window is true
PASS window.hasOwnProperty('DeviceMotionEvent') is true
PASS typeof window._ondevicemotion_ == 'object' is true
Modified: trunk/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js (149170 => 149171)
--- trunk/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js 2013-04-26 07:29:19 UTC (rev 149170)
+++ trunk/LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js 2013-04-26 09:16:34 UTC (rev 149171)
@@ -1,17 +1,8 @@
description('Tests that the window.DeviceOrientationEvent and window.ondeviceorientation properties are present.');
-function hasDeviceOrientationEventProperty()
-{
- for (var property in window) {
- if (property == 'DeviceOrientationEvent')
- return true;
- }
- return false;
-}
-
shouldBeTrue("typeof window.DeviceOrientationEvent == 'object'");
shouldBeFalse("typeof window.DeviceOrientationEvent == 'function'");
-shouldBeTrue("hasDeviceOrientationEventProperty()");
+shouldBeFalse("window.propertyIsEnumerable('DeviceOrientationEvent')");
shouldBeTrue("'DeviceOrientationEvent' in window");
shouldBeTrue("window.hasOwnProperty('DeviceOrientationEvent')");
Modified: trunk/LayoutTests/fast/dom/DeviceOrientation/window-property-expected.txt (149170 => 149171)
--- trunk/LayoutTests/fast/dom/DeviceOrientation/window-property-expected.txt 2013-04-26 07:29:19 UTC (rev 149170)
+++ trunk/LayoutTests/fast/dom/DeviceOrientation/window-property-expected.txt 2013-04-26 09:16:34 UTC (rev 149171)
@@ -5,7 +5,7 @@
PASS typeof window.DeviceOrientationEvent == 'object' is true
PASS typeof window.DeviceOrientationEvent == 'function' is false
-PASS hasDeviceOrientationEventProperty() is true
+PASS window.propertyIsEnumerable('DeviceOrientationEvent') is false
PASS 'DeviceOrientationEvent' in window is true
PASS window.hasOwnProperty('DeviceOrientationEvent') is true
PASS typeof window._ondeviceorientation_ == 'object' is true
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
