Title: [149223] trunk/Source/WebCore
Revision
149223
Author
roger_f...@apple.com
Date
2013-04-26 16:45:41 -0700 (Fri, 26 Apr 2013)

Log Message

Uninflate caret rect.
http://bugs.webkit.org/show_bug.cgi?id=114997.
<rdar://problem/12629007>.

Reviewed by Timothy Horton.

Inflation was causing painting errors with focus rings.
It is no longer needed after disabling subpixel layout.

* editing/FrameSelection.cpp:
(WebCore::repaintCaretForLocalRect):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (149222 => 149223)


--- trunk/Source/WebCore/ChangeLog	2013-04-26 23:40:43 UTC (rev 149222)
+++ trunk/Source/WebCore/ChangeLog	2013-04-26 23:45:41 UTC (rev 149223)
@@ -1,5 +1,19 @@
 2013-04-26  Roger Fong  <roger_f...@apple.com>
 
+        Uninflate caret rect.
+        http://bugs.webkit.org/show_bug.cgi?id=114997.
+        <rdar://problem/12629007>.
+
+        Reviewed by Timothy Horton.
+
+        Inflation was causing painting errors with focus rings.
+        It is no longer needed after disabling subpixel layout.
+
+        * editing/FrameSelection.cpp:
+        (WebCore::repaintCaretForLocalRect):
+
+2013-04-26  Roger Fong  <roger_f...@apple.com>
+
         Unreviewed build fix.
 
         * platform/LayoutUnit.h:

Modified: trunk/Source/WebCore/editing/FrameSelection.cpp (149222 => 149223)


--- trunk/Source/WebCore/editing/FrameSelection.cpp	2013-04-26 23:40:43 UTC (rev 149222)
+++ trunk/Source/WebCore/editing/FrameSelection.cpp	2013-04-26 23:45:41 UTC (rev 149223)
@@ -1364,12 +1364,7 @@
     if (!caretPainter)
         return;
 
-    // FIXME: Need to over-paint 1 pixel to workaround some rounding problems.
-    // https://bugs.webkit.org/show_bug.cgi?id=108283
-    LayoutRect inflatedRect = rect;
-    inflatedRect.inflate(1);
-
-    caretPainter->repaintRectangle(inflatedRect);
+    caretPainter->repaintRectangle(rect);
 }
 
 bool FrameSelection::recomputeCaretRect()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to