Title: [149232] trunk
- Revision
- 149232
- Author
- jer.no...@apple.com
- Date
- 2013-04-26 22:30:40 -0700 (Fri, 26 Apr 2013)
Log Message
Video playback has corruption on the edges of the video
https://bugs.webkit.org/show_bug.cgi?id=115216
Reviewed by Simon Fraser.
Source/WebCore:
Test: media/video-poster-background.html
RenderImage correctly answers foregroundIsKnownToBeOpaqueInRect() method
when a poster image is displayed, but once the video begins playing and
the poster image is no longer displayed, RenderImage will continue to
answer 'true' even when the video does not occupy the entire render box.
Override foregroundIsKnownToBeOpaqueInRect() in order to more correctly
answer the question for the video layer.
* rendering/RenderImage.h: Make foregroundIsKnownToBeOpaqueInRect() protected
(vs. private).
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect): Added. Return
true if the rect parameter is entirely contained by the video box.
* rendering/RenderVideo.h:
LayoutTests:
* media/content/test.jpg: Added.
* media/video-poster-background-expected.html: Added.
* media/video-poster-background.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (149231 => 149232)
--- trunk/LayoutTests/ChangeLog 2013-04-27 04:41:12 UTC (rev 149231)
+++ trunk/LayoutTests/ChangeLog 2013-04-27 05:30:40 UTC (rev 149232)
@@ -1,3 +1,14 @@
+2013-04-26 Jer Noble <jer.no...@apple.com>
+
+ Video playback has corruption on the edges of the video
+ https://bugs.webkit.org/show_bug.cgi?id=115216
+
+ Reviewed by Simon Fraser.
+
+ * media/content/test.jpg: Added.
+ * media/video-poster-background-expected.html: Added.
+ * media/video-poster-background.html: Added.
+
2013-04-26 Roger Fong <roger_f...@apple.com>
Unreviewed. Skipping some more tests that still need rebaselining after disabling subpixel layout on mac.
Added: trunk/LayoutTests/media/content/counting.jpg (0 => 149232)
--- trunk/LayoutTests/media/content/counting.jpg (rev 0)
+++ trunk/LayoutTests/media/content/counting.jpg 2013-04-27 05:30:40 UTC (rev 149232)
@@ -0,0 +1,58 @@
+\xFF\xD8\xFF\xE0 JFIF H H \xFF\xE2\xB0ICC_PROFILE \xA0appl mntrRGB XYZ \xD5 acspAPPL \xF6\xD6 \xD3-appl desc icprt \x80 "wtpt \xA4 rXYZ \xB8 gXYZ \xCC bXYZ \xE0 rTRC \xF4 vcgt 0ndin 4 >chad t ,bTRC \xF4 gTRC \xF4 desc Composite NTSC text Copyright 2007 Apple Inc. XYZ \xF3Q \xCCXYZ j\x92 8\xC0 ~XYZ d\xA8 \xB4
+ aXYZ '\x9B 6 \xB8Mcurv \xF6 vcgt ndin 6 \xA1H W
+ O\ \x98R '\xAE \xEC P
+ T9 \xF6 \xF6 \xF6 sf32 B \xDE\xFF\xFF\xF3&