Title: [149443] trunk/Source/WebCore
- Revision
- 149443
- Author
- eric.carl...@apple.com
- Date
- 2013-05-01 11:55:32 -0700 (Wed, 01 May 2013)
Log Message
HTMLMediaElement::updateActiveTextTrackCues can do unnecessary work
https://bugs.webkit.org/show_bug.cgi?id=81856
Reviewed by Jer Noble.
No new tests, covered by existing tests.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests): Add an early return when there
is obviously no work to be done.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (149442 => 149443)
--- trunk/Source/WebCore/ChangeLog 2013-05-01 18:26:51 UTC (rev 149442)
+++ trunk/Source/WebCore/ChangeLog 2013-05-01 18:55:32 UTC (rev 149443)
@@ -1,3 +1,16 @@
+2013-05-01 Eric Carlson <eric.carl...@apple.com>
+
+ HTMLMediaElement::updateActiveTextTrackCues can do unnecessary work
+ https://bugs.webkit.org/show_bug.cgi?id=81856
+
+ Reviewed by Jer Noble.
+
+ No new tests, covered by existing tests.
+
+ * html/HTMLMediaElement.h:
+ (WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests): Add an early return when there
+ is obviously no work to be done.
+
2013-04-30 Jer Noble <jer.no...@apple.com>
Closed caption lines overlap
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (149442 => 149443)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2013-05-01 18:26:51 UTC (rev 149442)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2013-05-01 18:55:32 UTC (rev 149443)
@@ -415,7 +415,7 @@
void removeBehaviorRestriction(BehaviorRestrictions restriction) { m_restrictions &= ~restriction; }
#if ENABLE(VIDEO_TRACK)
- bool ignoreTrackDisplayUpdateRequests() const { return m_ignoreTrackDisplayUpdate > 0; }
+ bool ignoreTrackDisplayUpdateRequests() const { return m_ignoreTrackDisplayUpdate > 0 || !m_textTracks || !m_cueTree.size(); }
void beginIgnoringTrackDisplayUpdateRequests();
void endIgnoringTrackDisplayUpdateRequests();
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
