Title: [149706] trunk/Source/WebCore
- Revision
- 149706
- Author
- benja...@webkit.org
- Date
- 2013-05-07 18:42:59 -0700 (Tue, 07 May 2013)
Log Message
We should not ref() the RefPtr twice in CanvasStyle
Patch by Benjamin Poulain <bpoul...@apple.com> on 2013-05-07
Reviewed by Darin Adler.
* html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
We leak the ref of PassRefPtr, we should not ref() it a second time.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (149705 => 149706)
--- trunk/Source/WebCore/ChangeLog 2013-05-08 01:41:16 UTC (rev 149705)
+++ trunk/Source/WebCore/ChangeLog 2013-05-08 01:42:59 UTC (rev 149706)
@@ -1,3 +1,13 @@
+2013-05-07 Benjamin Poulain <bpoul...@apple.com>
+
+ We should not ref() the RefPtr twice in CanvasStyle
+
+ Reviewed by Darin Adler.
+
+ * html/canvas/CanvasStyle.cpp:
+ (WebCore::CanvasStyle::CanvasStyle):
+ We leak the ref of PassRefPtr, we should not ref() it a second time.
+
2013-05-07 Ryosuke Niwa <rn...@webkit.org>
Devirtualize Document class type checking
Modified: trunk/Source/WebCore/html/canvas/CanvasStyle.cpp (149705 => 149706)
--- trunk/Source/WebCore/html/canvas/CanvasStyle.cpp 2013-05-08 01:41:16 UTC (rev 149705)
+++ trunk/Source/WebCore/html/canvas/CanvasStyle.cpp 2013-05-08 01:42:59 UTC (rev 149706)
@@ -127,14 +127,12 @@
: m_type(Gradient)
, m_gradient(gradient.leakRef())
{
- m_gradient->ref();
}
CanvasStyle::CanvasStyle(PassRefPtr<CanvasPattern> pattern)
: m_type(ImagePattern)
, m_pattern(pattern.leakRef())
{
- m_pattern->ref();
}
CanvasStyle::~CanvasStyle()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
