Title: [149740] trunk
- Revision
- 149740
- Author
- ser...@webkit.org
- Date
- 2013-05-08 08:19:15 -0700 (Wed, 08 May 2013)
Log Message
Allow blank spaces before colon (:) on CSS variable definition
https://bugs.webkit.org/show_bug.cgi?id=115802
Reviewed by Darin Adler.
Source/WebCore:
Test: css3/css-variable-definition.html
Modified the grammar to allow blank spaces before the colon on CSS
variable definitions.
* css/CSSGrammar.y.in:
LayoutTests:
New test to check that spaces are allowed before the color on CSS
variable definitions.
* css3/css-variable-definition-expected.html: Added.
* css3/css-variable-definition.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (149739 => 149740)
--- trunk/LayoutTests/ChangeLog 2013-05-08 15:08:55 UTC (rev 149739)
+++ trunk/LayoutTests/ChangeLog 2013-05-08 15:19:15 UTC (rev 149740)
@@ -1,3 +1,16 @@
+2013-05-08 Sergio Villar Senin <svil...@igalia.com>
+
+ Allow blank spaces before colon (:) on CSS variable definition
+ https://bugs.webkit.org/show_bug.cgi?id=115802
+
+ Reviewed by Darin Adler.
+
+ New test to check that spaces are allowed before the color on CSS
+ variable definitions.
+
+ * css3/css-variable-definition-expected.html: Added.
+ * css3/css-variable-definition.html: Added.
+
2013-05-08 Zoltan Arvai <zar...@inf.u-szeged.hu>
[Qt] Unreviewed gardening after r149292.
Added: trunk/LayoutTests/css3/css-variable-definition-expected.html (0 => 149740)
--- trunk/LayoutTests/css3/css-variable-definition-expected.html (rev 0)
+++ trunk/LayoutTests/css3/css-variable-definition-expected.html 2013-05-08 15:19:15 UTC (rev 149740)
@@ -0,0 +1,14 @@
+<html>
+<style>
+ :root {
+ -webkit-var-mycolor: red;
+ }
+ div {
+ color: -webkit-var(mycolor);
+ }
+</style>
+<body>
+ <p>Check that a CSS variable definition accepts spaces before the ':'</p>
+ <div>This text should be red</div>
+</body>
+</html>
Added: trunk/LayoutTests/css3/css-variable-definition.html (0 => 149740)
--- trunk/LayoutTests/css3/css-variable-definition.html (rev 0)
+++ trunk/LayoutTests/css3/css-variable-definition.html 2013-05-08 15:19:15 UTC (rev 149740)
@@ -0,0 +1,14 @@
+<html>
+<style>
+ :root {
+ -webkit-var-mycolor : red;
+ }
+ div {
+ color: -webkit-var(mycolor);
+ }
+</style>
+<body>
+ <p>Check that a CSS variable definition accepts spaces before the ':'</p>
+ <div>This text should be red</div>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (149739 => 149740)
--- trunk/Source/WebCore/ChangeLog 2013-05-08 15:08:55 UTC (rev 149739)
+++ trunk/Source/WebCore/ChangeLog 2013-05-08 15:19:15 UTC (rev 149740)
@@ -1,3 +1,17 @@
+2013-05-08 Sergio Villar Senin <svil...@igalia.com>
+
+ Allow blank spaces before colon (:) on CSS variable definition
+ https://bugs.webkit.org/show_bug.cgi?id=115802
+
+ Reviewed by Darin Adler.
+
+ Test: css3/css-variable-definition.html
+
+ Modified the grammar to allow blank spaces before the colon on CSS
+ variable definitions.
+
+ * css/CSSGrammar.y.in:
+
2013-05-08 Gustavo Noronha Silva <gustavo.noro...@collabora.com>
[GStreamer] Does memory buffering even with preload set to none
Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (149739 => 149740)
--- trunk/Source/WebCore/css/CSSGrammar.y.in 2013-05-08 15:08:55 UTC (rev 149739)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in 2013-05-08 15:19:15 UTC (rev 149740)
@@ -1615,11 +1615,11 @@
;
declaration:
- VAR_DEFINITION ':' maybe_space expr prio {
+ VAR_DEFINITION maybe_space ':' maybe_space expr prio {
#if ENABLE_CSS_VARIABLES
- parser->storeVariableDeclaration($1, parser->sinkFloatingValueList($4), $5);
+ parser->storeVariableDeclaration($1, parser->sinkFloatingValueList($5), $6);
$$ = true;
- parser->markPropertyEnd($5, true);
+ parser->markPropertyEnd($6, true);
#else
$$ = false;
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
