Log Message
[Mac] captions menu is not positioned correctly in full-screen https://bugs.webkit.org/show_bug.cgi?id=116103
Update the positioning properties of the captions menu in full-screen following the fix for https://webkit.org/b/115968. Reviewed by Darin Adler. * css/fullscreenQuickTime.css: (video:-webkit-full-screen::-webkit-media-controls-closed-captions-container): Add 50px to the bottom position since we're now positioned relative to the media element, and use a calc() command to be right-aligned to the captions icon in the media controller. The max-width and max-height properties follow the same technique used for the non-full-screen mode.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (150074 => 150075)
--- trunk/Source/WebCore/ChangeLog 2013-05-14 17:40:53 UTC (rev 150074)
+++ trunk/Source/WebCore/ChangeLog 2013-05-14 17:44:37 UTC (rev 150075)
@@ -1,3 +1,20 @@
+2013-05-14 Antoine Quint <grao...@apple.com>
+
+ [Mac] captions menu is not positioned correctly in full-screen
+ https://bugs.webkit.org/show_bug.cgi?id=116103
+
+ Update the positioning properties of the captions menu in full-screen
+ following the fix for https://webkit.org/b/115968.
+
+ Reviewed by Darin Adler.
+
+ * css/fullscreenQuickTime.css:
+ (video:-webkit-full-screen::-webkit-media-controls-closed-captions-container):
+ Add 50px to the bottom position since we're now positioned relative to the
+ media element, and use a calc() command to be right-aligned to the captions
+ icon in the media controller. The max-width and max-height properties follow
+ the same technique used for the non-full-screen mode.
+
2013-05-14 Zan Dobersek <zdober...@igalia.com>
[GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
Modified: trunk/Source/WebCore/css/fullscreenQuickTime.css (150074 => 150075)
--- trunk/Source/WebCore/css/fullscreenQuickTime.css 2013-05-14 17:40:53 UTC (rev 150074)
+++ trunk/Source/WebCore/css/fullscreenQuickTime.css 2013-05-14 17:44:37 UTC (rev 150075)
@@ -168,10 +168,8 @@
}
video:-webkit-full-screen::-webkit-media-controls-closed-captions-container {
- bottom: 64px;
- right: 38px;
+ bottom: 114px;
+ right: -webkit-calc(50% - 183px); /* 183px is 221px (half the media controller's width) minus 38px (the right position of the captions icon). */
+ max-width: -webkit-calc(50% + 173px); /* right + 10px */
+ max-height: -webkit-calc(100% - 124px); /* bottom + 10px */
}
-
-video:-webkit-full-screen::-webkit-media-controls-closed-captions-track-list {
- max-height: 500px;
-}
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
