Title: [150257] trunk/Source/WebKit/blackberry
- Revision
- 150257
- Author
- mifen...@rim.com
- Date
- 2013-05-17 08:08:46 -0700 (Fri, 17 May 2013)
Log Message
[BlackBerry] Remove stale comment for select mouse handling.
https://bugs.webkit.org/show_bug.cgi?id=116309
Reviewed by Rob Buis.
PR 135935.
Remove a FIXME that has been invalidated by a change
to our touch -> mouse model.
Internally Rubberstamped by Genevieve Mak.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (150256 => 150257)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-05-17 14:33:39 UTC (rev 150256)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-05-17 15:08:46 UTC (rev 150257)
@@ -3962,10 +3962,6 @@
// because we use a pop up dialog to handle the actual selections. This prevents options from
// being selected prior to displaying the pop up dialog. The contents of the listbox are for
// display only.
- //
- // FIXME: We explicitly do not forward this event to WebCore so as to preserve symmetry with
- // the MouseEventReleased handling (below). This has the side-effect that mousedown events
- // are not fired for human generated mouse press events. See RIM Bug #1579.
// We do focus <select>/<option> on mouse down so that a Focus event is fired and have the
// element painted in its focus state on repaint.
@@ -3977,9 +3973,8 @@
} else
eventHandler->handleMousePressEvent(mouseEvent);
} else if (mouseEvent.type() == WebCore::PlatformEvent::MouseReleased) {
- // FIXME: For <select> and <options> elements, we explicitly do not forward this event to WebCore so
- // as to preserve symmetry with the MouseEventPressed handling (above). This has the side-effect that
- // mouseup events are not fired on such elements for human generated mouse release events. See RIM Bug #1579.
+ // Do not send the mouse event if this is a popup field as the mouse down has been
+ // suppressed and symmetry should be maintained.
if (!m_inputHandler->didNodeOpenPopup(node))
eventHandler->handleMouseReleaseEvent(mouseEvent);
}
Modified: trunk/Source/WebKit/blackberry/ChangeLog (150256 => 150257)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-05-17 14:33:39 UTC (rev 150256)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-05-17 15:08:46 UTC (rev 150257)
@@ -1,3 +1,20 @@
+2013-05-17 Mike Fenton <mifen...@rim.com>
+
+ [BlackBerry] Remove stale comment for select mouse handling.
+ https://bugs.webkit.org/show_bug.cgi?id=116309
+
+ Reviewed by Rob Buis.
+
+ PR 135935.
+
+ Remove a FIXME that has been invalidated by a change
+ to our touch -> mouse model.
+
+ Internally Rubberstamped by Genevieve Mak.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
+
2013-05-17 Alberto Garcia <agar...@igalia.com>
[BlackBerry] DumpRenderTreeSupport: fix build in setMockDeviceOrientation()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
