Title: [150272] trunk/Tools
- Revision
- 150272
- Author
- ddkil...@apple.com
- Date
- 2013-05-17 10:34:24 -0700 (Fri, 17 May 2013)
Log Message
Make filter-build-webkit testable using LoadAsModule
Part 1 of 3: <http://webkit.org/b/116247>
Reviewed by Benjamin Poulain.
* Scripts/filter-build-webkit: Change global variables that are
used in subroutines from 'my' to 'our' to make it possible to
evaluate the script in a package context in LoadAsModule.pm.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (150271 => 150272)
--- trunk/Tools/ChangeLog 2013-05-17 17:30:59 UTC (rev 150271)
+++ trunk/Tools/ChangeLog 2013-05-17 17:34:24 UTC (rev 150272)
@@ -1,3 +1,14 @@
+2013-05-17 David Kilzer <ddkil...@apple.com>
+
+ Make filter-build-webkit testable using LoadAsModule
+ Part 1 of 3: <http://webkit.org/b/116247>
+
+ Reviewed by Benjamin Poulain.
+
+ * Scripts/filter-build-webkit: Change global variables that are
+ used in subroutines from 'my' to 'our' to make it possible to
+ evaluate the script in a package context in LoadAsModule.pm.
+
2013-05-14 Sam Weinig <s...@webkit.org>
Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
Modified: trunk/Tools/Scripts/filter-build-webkit (150271 => 150272)
--- trunk/Tools/Scripts/filter-build-webkit 2013-05-17 17:30:59 UTC (rev 150271)
+++ trunk/Tools/Scripts/filter-build-webkit 2013-05-17 17:34:24 UTC (rev 150272)
@@ -1,6 +1,6 @@
#!/usr/bin/perl -w
-# Copyright (C) 2011 Apple Inc. All rights reserved.
+# Copyright (C) 2011, 2012, 2013 Apple Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
@@ -71,13 +71,16 @@
# Defined in VCSUtils.
sub possiblyColored($$);
+# Global variables used only in global scope.
+my $outputPath = "&STDOUT";
my $showHelp;
-my $outputPath = "&STDOUT";
-my $outputFormat = "text";
-my $useColor = -t STDOUT;
-my $unfilteredOutputPath = "build.log";
-my $logUnfilteredOutput;
+# Global variables used in global and subroutine scope.
+our $logUnfilteredOutput;
+our $outputFormat = "text";
+our $unfilteredOutputPath = "build.log";
+our $useColor = -t STDOUT;
+
sub usageAndExit()
{
print STDERR <<__END__;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
