Title: [150311] trunk/Source/WebCore
- Revision
- 150311
- Author
- ch.du...@sisa.samsung.com
- Date
- 2013-05-17 17:16:19 -0700 (Fri, 17 May 2013)
Log Message
Get rid of Custom code for Audio global constructor
https://bugs.webkit.org/show_bug.cgi?id=116343
Reviewed by Geoffrey Garen.
Remove custom code for Audio global constructor. It is no longer needed
now that the the bindings generator no longer require custom code for
named constructors and now that [EnabledAtRuntime] extended attribute is
supported for global constructors.
HTMLAudioElement global constructors are now automatically generated.
No new tests, no behavior change for layout tests.
* bindings/js/JSDOMWindowCustom.cpp:
* html/HTMLAudioElement.idl:
* page/DOMWindow.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (150310 => 150311)
--- trunk/Source/WebCore/ChangeLog 2013-05-18 00:05:10 UTC (rev 150310)
+++ trunk/Source/WebCore/ChangeLog 2013-05-18 00:16:19 UTC (rev 150311)
@@ -1,3 +1,23 @@
+2013-05-17 Christophe Dumez <ch.du...@sisa.samsung.com>
+
+ Get rid of Custom code for Audio global constructor
+ https://bugs.webkit.org/show_bug.cgi?id=116343
+
+ Reviewed by Geoffrey Garen.
+
+ Remove custom code for Audio global constructor. It is no longer needed
+ now that the the bindings generator no longer require custom code for
+ named constructors and now that [EnabledAtRuntime] extended attribute is
+ supported for global constructors.
+
+ HTMLAudioElement global constructors are now automatically generated.
+
+ No new tests, no behavior change for layout tests.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ * html/HTMLAudioElement.idl:
+ * page/DOMWindow.idl:
+
2013-05-17 Alexey Proskuryakov <a...@apple.com>
<rdar://problem/13819878> Disable SharedWorker when in multiple web process model
Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (150310 => 150311)
--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2013-05-18 00:05:10 UTC (rev 150310)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2013-05-18 00:16:19 UTC (rev 150311)
@@ -533,15 +533,6 @@
return getDOMConstructor<JSImageConstructor>(exec, this);
}
-#if ENABLE(VIDEO)
-JSValue JSDOMWindow::audio(ExecState* exec) const
-{
- if (!MediaPlayer::isAvailable())
- return jsUndefined();
- return getDOMConstructor<JSHTMLAudioElementNamedConstructor>(exec, this);
-}
-#endif
-
// Custom functions
JSValue JSDOMWindow::open(ExecState* exec)
Modified: trunk/Source/WebCore/html/HTMLAudioElement.idl (150310 => 150311)
--- trunk/Source/WebCore/html/HTMLAudioElement.idl 2013-05-18 00:05:10 UTC (rev 150310)
+++ trunk/Source/WebCore/html/HTMLAudioElement.idl 2013-05-18 00:16:19 UTC (rev 150311)
@@ -24,7 +24,7 @@
*/
[
- NoInterfaceObject,
+ EnabledAtRuntime,
Conditional=VIDEO,
NamedConstructor=Audio([Default=NullString] optional DOMString src)
] interface HTMLAudioElement : HTMLMediaElement {
Modified: trunk/Source/WebCore/page/DOMWindow.idl (150310 => 150311)
--- trunk/Source/WebCore/page/DOMWindow.idl 2013-05-18 00:05:10 UTC (rev 150310)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2013-05-18 00:16:19 UTC (rev 150311)
@@ -322,8 +322,6 @@
#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
// Additional constructors.
[CustomGetter, CustomConstructor] attribute HTMLImageElementNamedConstructor Image; // Usable with new operator
- [CustomGetter, Conditional=VIDEO] attribute HTMLAudioElementNamedConstructor Audio; // Usable with the new operator
- [Conditional=VIDEO] attribute HTMLAudioElementConstructor HTMLAudioElement;
// Mozilla has a separate XMLDocument object for XML documents.
// We just use Document for this.
attribute DocumentConstructor XMLDocument;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
