Diff
Modified: trunk/Source/WebCore/ChangeLog (150508 => 150509)
--- trunk/Source/WebCore/ChangeLog 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/ChangeLog 2013-05-22 12:04:35 UTC (rev 150509)
@@ -1,3 +1,36 @@
+2013-05-22 Christophe Dumez <ch.du...@sisa.samsung.com>
+
+ Have IDL interface names match their global constructor
+ https://bugs.webkit.org/show_bug.cgi?id=116520
+
+ Reviewed by Kentaro Hara.
+
+ Have IDL interface names match their global constructor name on DOMWindow.idl
+ using [InterfaceName] extended attribute. This affects in particular webkit
+ prefixed constructors. This is mandated by Web IDL specification:
+ http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces
+
+ As a consequence, we can now get rid of [NoInterfaceObject] extended attribute
+ for those interfaces and have their global constructors automatically generated
+ by the bindings generator.
+
+ No new tests, no behavior change for layout tests.
+
+ * Modules/mediasource/MediaSource.idl:
+ * Modules/mediasource/SourceBuffer.idl:
+ * Modules/mediasource/SourceBufferList.idl:
+ * Modules/mediastream/MediaStream.idl:
+ * Modules/mediastream/RTCPeerConnection.idl:
+ * Modules/speech/SpeechGrammar.idl:
+ * Modules/speech/SpeechGrammarList.idl:
+ * Modules/speech/SpeechRecognition.idl:
+ * Modules/speech/SpeechRecognitionError.idl:
+ * Modules/speech/SpeechRecognitionEvent.idl:
+ * Modules/webaudio/OfflineAudioContext.idl:
+ * Modules/webaudio/PannerNode.idl:
+ * dom/ShadowRoot.idl:
+ * page/DOMWindow.idl:
+
2013-05-21 Mihai Tica <mit...@adobe.com>
Update the background blending implementation to match the changes done
Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/mediasource/MediaSource.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -29,12 +29,12 @@
*/
[
- NoInterfaceObject,
Conditional=MEDIA_SOURCE,
ActiveDOMObject,
EventTarget,
Constructor,
- CallWith=ScriptExecutionContext
+ CallWith=ScriptExecutionContext,
+ InterfaceName=WebKitMediaSource
] interface MediaSource {
// All the source buffers created by this object.
readonly attribute SourceBufferList sourceBuffers;
Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -29,8 +29,8 @@
*/
[
- NoInterfaceObject,
- Conditional=MEDIA_SOURCE
+ Conditional=MEDIA_SOURCE,
+ InterfaceName=WebKitSourceBuffer
] interface SourceBuffer {
// Returns the time ranges buffered.
Modified: trunk/Source/WebCore/Modules/mediasource/SourceBufferList.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/mediasource/SourceBufferList.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBufferList.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -29,11 +29,11 @@
*/
[
- NoInterfaceObject,
Conditional=MEDIA_SOURCE,
IndexedGetter,
EventTarget,
- CallWith=ScriptExecutionContext
+ CallWith=ScriptExecutionContext,
+ InterfaceName=WebKitSourceBufferList
] interface SourceBufferList {
readonly attribute unsigned long length;
SourceBuffer item(unsigned long index);
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/mediastream/MediaStream.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -23,14 +23,14 @@
*/
[
- NoInterfaceObject,
Conditional=MEDIA_STREAM,
EventTarget,
Constructor,
Constructor(MediaStream stream),
Constructor(MediaStreamTrack[] tracks),
CallWith=ScriptExecutionContext,
- SkipVTableValidation
+ SkipVTableValidation,
+ InterfaceName=webkitMediaStream
] interface MediaStream {
// DEPRECATED
readonly attribute DOMString label;
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -29,13 +29,13 @@
*/
[
- NoInterfaceObject,
Conditional=MEDIA_STREAM,
ActiveDOMObject,
Constructor(Dictionary rtcIceServers, optional Dictionary mediaConstraints),
ConstructorRaisesException,
CallWith=ScriptExecutionContext,
- EventTarget
+ EventTarget,
+ InterfaceName=webkitRTCPeerConnection
] interface RTCPeerConnection {
void createOffer(RTCSessionDescriptionCallback successCallback, [Default=Undefined] optional RTCErrorCallback failureCallback, optional Dictionary mediaConstraints)
raises(DOMException);
Modified: trunk/Source/WebCore/Modules/speech/SpeechGrammar.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/speech/SpeechGrammar.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/speech/SpeechGrammar.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -24,10 +24,10 @@
*/
[
- NoInterfaceObject,
Conditional=SCRIPTED_SPEECH,
Constructor,
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ InterfaceName=webkitSpeechGrammar
] interface SpeechGrammar {
[URL,CallWith=ScriptExecutionContext] attribute DOMString src;
attribute float weight;
Modified: trunk/Source/WebCore/Modules/speech/SpeechGrammarList.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/speech/SpeechGrammarList.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/speech/SpeechGrammarList.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -24,11 +24,11 @@
*/
[
- NoInterfaceObject,
Conditional=SCRIPTED_SPEECH,
IndexedGetter,
Constructor,
- ImplementationLacksVTable
+ ImplementationLacksVTable,
+ InterfaceName=webkitSpeechGrammarList
] interface SpeechGrammarList {
readonly attribute unsigned long length;
SpeechGrammar item([IsIndex] unsigned long index);
Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognition.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/speech/SpeechRecognition.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognition.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -24,12 +24,12 @@
*/
[
- NoInterfaceObject,
Conditional=SCRIPTED_SPEECH,
ActiveDOMObject,
Constructor,
CallWith=ScriptExecutionContext,
EventTarget,
+ InterfaceName=webkitSpeechRecognition
] interface SpeechRecognition {
attribute SpeechGrammarList grammars;
attribute DOMString lang;
Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognitionError.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/speech/SpeechRecognitionError.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognitionError.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -24,9 +24,9 @@
*/
[
- NoInterfaceObject,
Conditional=SCRIPTED_SPEECH,
- ConstructorTemplate=Event
+ ConstructorTemplate=Event,
+ InterfaceName=webkitSpeechRecognitionError
] interface SpeechRecognitionError : Event {
[InitializedByEventConstructor] readonly attribute DOMString error;
[InitializedByEventConstructor] readonly attribute DOMString message;
Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognitionEvent.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/speech/SpeechRecognitionEvent.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognitionEvent.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -24,9 +24,9 @@
*/
[
- NoInterfaceObject,
Conditional=SCRIPTED_SPEECH,
ConstructorTemplate=Event,
+ InterfaceName=webkitSpeechRecognitionEvent
] interface SpeechRecognitionEvent : Event {
[InitializedByEventConstructor] readonly attribute unsigned long resultIndex;
[InitializedByEventConstructor] readonly attribute SpeechRecognitionResultList results;
Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -23,13 +23,13 @@
*/
[
- NoInterfaceObject,
Conditional=WEB_AUDIO,
EventTarget,
JSGenerateToJSObject,
Constructor(unsigned long numberOfChannels, unsigned long numberOfFrames, float sampleRate),
ConstructorRaisesException,
- CallWith=ScriptExecutionContext
+ CallWith=ScriptExecutionContext,
+ InterfaceName=webkitOfflineAudioContext
] interface OfflineAudioContext : AudioContext {
};
Modified: trunk/Source/WebCore/Modules/webaudio/PannerNode.idl (150508 => 150509)
--- trunk/Source/WebCore/Modules/webaudio/PannerNode.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/Modules/webaudio/PannerNode.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -23,9 +23,9 @@
*/
[
- NoInterfaceObject,
Conditional=WEB_AUDIO,
- JSGenerateToJSObject
+ JSGenerateToJSObject,
+ InterfaceName=webkitAudioPannerNode
] interface PannerNode : AudioNode {
// Panning model
const unsigned short EQUALPOWER = 0;
Modified: trunk/Source/WebCore/dom/ShadowRoot.idl (150508 => 150509)
--- trunk/Source/WebCore/dom/ShadowRoot.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/dom/ShadowRoot.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -25,9 +25,9 @@
*/
[
- NoInterfaceObject,
Conditional=SHADOW_DOM,
- JSGenerateToJSObject
+ JSGenerateToJSObject,
+ InterfaceName=WebKitShadowRoot
] interface ShadowRoot : DocumentFragment {
readonly attribute Element activeElement;
attribute boolean applyAuthorStyles;
Modified: trunk/Source/WebCore/page/DOMWindow.idl (150508 => 150509)
--- trunk/Source/WebCore/page/DOMWindow.idl 2013-05-22 11:42:40 UTC (rev 150508)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2013-05-22 12:04:35 UTC (rev 150509)
@@ -337,21 +337,7 @@
[Conditional=INDEXED_DATABASE] attribute IDBTransactionConstructor webkitIDBTransaction;
// Constructors whose name does not match the interface name.
- // FIXME: Remove these once [ImplementedAs] is used and once constructor names match interface names.
- [Conditional=SHADOW_DOM] attribute ShadowRootConstructor WebKitShadowRoot;
- [Conditional=MEDIA_SOURCE] attribute MediaSourceConstructor WebKitMediaSource;
- [Conditional=MEDIA_SOURCE] attribute SourceBufferConstructor WebKitSourceBuffer;
- [Conditional=MEDIA_SOURCE] attribute SourceBufferListConstructor WebKitSourceBufferList;
[Conditional=WEB_AUDIO, CustomGetter] attribute AudioContextConstructor webkitAudioContext;
- [Conditional=WEB_AUDIO] attribute OfflineAudioContextConstructor webkitOfflineAudioContext;
- [Conditional=WEB_AUDIO] attribute PannerNodeConstructor webkitAudioPannerNode;
- [Conditional=MEDIA_STREAM] attribute MediaStreamConstructor webkitMediaStream;
- [Conditional=MEDIA_STREAM] attribute RTCPeerConnectionConstructor webkitRTCPeerConnection;
- [Conditional=SCRIPTED_SPEECH] attribute SpeechGrammarConstructor webkitSpeechGrammar;
- [Conditional=SCRIPTED_SPEECH] attribute SpeechGrammarListConstructor webkitSpeechGrammarList;
- [Conditional=SCRIPTED_SPEECH] attribute SpeechRecognitionConstructor webkitSpeechRecognition;
- [Conditional=SCRIPTED_SPEECH] attribute SpeechRecognitionErrorConstructor webkitSpeechRecognitionError;
- [Conditional=SCRIPTED_SPEECH] attribute SpeechRecognitionEventConstructor webkitSpeechRecognitionEvent;
#endif // defined(LANGUAGE_JAVASCRIPT)
};
