Title: [150629] trunk/Source/WebKit/blackberry
- Revision
- 150629
- Author
- commit-qu...@webkit.org
- Date
- 2013-05-23 23:26:26 -0700 (Thu, 23 May 2013)
Log Message
[BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
https://bugs.webkit.org/show_bug.cgi?id=115245
Patch by Xiaobo Wang <xiaobw...@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.
PR 330917.
Internally reviewed by Arvid Nilsson.
1. Suspend/resumeRootLayerCommit when notified app activation state
change.
2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
start root layer commit timer, so that there's a commit even if
BackingStore got disabled/removed.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (150628 => 150629)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-05-24 06:23:20 UTC (rev 150628)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2013-05-24 06:26:26 UTC (rev 150629)
@@ -5024,6 +5024,13 @@
{
m_activationState = activationState;
+#if USE(ACCELERATED_COMPOSITING)
+ if (activationState == ActivationActive)
+ resumeRootLayerCommit();
+ else
+ suspendRootLayerCommit();
+#endif
+
#if ENABLE(PAGE_VISIBILITY_API)
setPageVisibilityState();
#endif
@@ -5673,6 +5680,9 @@
m_suspendRootLayerCommit = false;
m_needsCommit = true;
+ // PR 330917, explicitly start root layer commit timer, so that there's a commit
+ // even if BackingStore got disabled/removed.
+ scheduleRootLayerCommit();
}
bool WebPagePrivate::needsOneShotDrawingSynchronization()
Modified: trunk/Source/WebKit/blackberry/ChangeLog (150628 => 150629)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-05-24 06:23:20 UTC (rev 150628)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-05-24 06:26:26 UTC (rev 150629)
@@ -1,3 +1,23 @@
+2013-05-23 Xiaobo Wang <xiaobw...@blackberry.com>
+
+ [BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
+ https://bugs.webkit.org/show_bug.cgi?id=115245
+
+ Reviewed by Rob Buis.
+
+ PR 330917.
+ Internally reviewed by Arvid Nilsson.
+
+ 1. Suspend/resumeRootLayerCommit when notified app activation state
+ change.
+ 2. Schedule root layer commit in resumeRootLayerCommit() to explicitly
+ start root layer commit timer, so that there's a commit even if
+ BackingStore got disabled/removed.
+
+ * Api/WebPage.cpp:
+ (BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
+ (BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
+
2013-05-23 Andy Chen <andc...@blackberry.com>
[BlackBerry] Need to forward the opener frame url to client when creating a new window
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
