Title: [150699] trunk/Source
- Revision
- 150699
- Author
- akl...@apple.com
- Date
- 2013-05-25 19:27:32 -0700 (Sat, 25 May 2013)
Log Message
Remove Document::getFocusableNodes().
<http://webkit.org/b/116773>
Reviewed by Joseph Pecoraro.
Source/WebCore:
This was added in r42191 and there are no remaining clients of the API.
* dom/Document.cpp:
* dom/Document.h:
* WebCore.exp.in:
Source/WebKit/mac:
Remove the private _focusableNodes API on DOMDocument, it has no clients.
* DOM/WebDOMOperations.mm:
* DOM/WebDOMOperationsPrivate.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (150698 => 150699)
--- trunk/Source/WebCore/ChangeLog 2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebCore/ChangeLog 2013-05-26 02:27:32 UTC (rev 150699)
@@ -1,5 +1,18 @@
2013-05-25 Andreas Kling <akl...@apple.com>
+ Remove Document::getFocusableNodes().
+ <http://webkit.org/b/116773>
+
+ Reviewed by Joseph Pecoraro.
+
+ This was added in r42191 and there are no remaining clients of the API.
+
+ * dom/Document.cpp:
+ * dom/Document.h:
+ * WebCore.exp.in:
+
+2013-05-25 Andreas Kling <akl...@apple.com>
+
Move Node::focusDelegate() to Element.
<http://webkit.org/b/116768>
Modified: trunk/Source/WebCore/WebCore.exp.in (150698 => 150699)
--- trunk/Source/WebCore/WebCore.exp.in 2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebCore/WebCore.exp.in 2013-05-26 02:27:32 UTC (rev 150699)
@@ -1051,7 +1051,6 @@
__ZN7WebCore8Document14setFocusedNodeEN3WTF10PassRefPtrINS_4NodeEEENS_14FocusDirectionE
__ZN7WebCore8Document16isPageBoxVisibleEi
__ZN7WebCore8Document16shortcutIconURLsEv
-__ZN7WebCore8Document17getFocusableNodesERN3WTF6VectorINS1_6RefPtrINS_4NodeEEELm0ENS1_15CrashOnOverflowEEE
__ZN7WebCore8Document20styleResolverChangedENS_23StyleResolverUpdateFlagE
__ZN7WebCore8Document22createDocumentFragmentEv
__ZN7WebCore8Document23didAddWheelEventHandlerEv
Modified: trunk/Source/WebCore/dom/Document.cpp (150698 => 150699)
--- trunk/Source/WebCore/dom/Document.cpp 2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebCore/dom/Document.cpp 2013-05-26 02:27:32 UTC (rev 150699)
@@ -3459,17 +3459,7 @@
updateStyleIfNeeded();
return !focusChangeBlocked;
}
-
-void Document::getFocusableNodes(Vector<RefPtr<Node> >& nodes)
-{
- updateLayout();
- for (Node* node = firstChild(); node; node = NodeTraversal::next(node)) {
- if (node->isFocusable())
- nodes.append(node);
- }
-}
-
void Document::setCSSTarget(Element* n)
{
if (m_cssTarget)
Modified: trunk/Source/WebCore/dom/Document.h (150698 => 150699)
--- trunk/Source/WebCore/dom/Document.h 2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebCore/dom/Document.h 2013-05-26 02:27:32 UTC (rev 150699)
@@ -675,8 +675,6 @@
UserActionElementSet& userActionElements() { return m_userActionElements; }
const UserActionElementSet& userActionElements() const { return m_userActionElements; }
- void getFocusableNodes(Vector<RefPtr<Node> >&);
-
// The m_ignoreAutofocus flag specifies whether or not the document has been changed by the user enough
// for WebCore to ignore the autofocus attribute on any form controls
bool ignoreAutofocus() const { return m_ignoreAutofocus; };
Modified: trunk/Source/WebKit/mac/ChangeLog (150698 => 150699)
--- trunk/Source/WebKit/mac/ChangeLog 2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-05-26 02:27:32 UTC (rev 150699)
@@ -1,3 +1,15 @@
+2013-05-25 Andreas Kling <akl...@apple.com>
+
+ Remove Document::getFocusableNodes().
+ <http://webkit.org/b/116773>
+
+ Reviewed by Joseph Pecoraro.
+
+ Remove the private _focusableNodes API on DOMDocument, it has no clients.
+
+ * DOM/WebDOMOperations.mm:
+ * DOM/WebDOMOperationsPrivate.h:
+
2013-05-25 Simon Fraser <simon.fra...@apple.com>
Unprefix Page Visibility API
Modified: trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm (150698 => 150699)
--- trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm 2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebKit/mac/DOM/WebDOMOperations.mm 2013-05-26 02:27:32 UTC (rev 150699)
@@ -183,20 +183,6 @@
@end
-@implementation DOMDocument (WebDOMDocumentOperationsPrivate)
-
-- (NSArray *)_focusableNodes
-{
- Vector<RefPtr<Node> > nodes;
- core(self)->getFocusableNodes(nodes);
- NSMutableArray *array = [NSMutableArray arrayWithCapacity:nodes.size()];
- for (unsigned i = 0; i < nodes.size(); ++i)
- [array addObject:kit(nodes[i].get())];
- return array;
-}
-
-@end
-
@implementation DOMRange (WebDOMRangeOperations)
- (WebArchive *)webArchive
Modified: trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h (150698 => 150699)
--- trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h 2013-05-26 02:22:58 UTC (rev 150698)
+++ trunk/Source/WebKit/mac/DOM/WebDOMOperationsPrivate.h 2013-05-26 02:27:32 UTC (rev 150699)
@@ -33,10 +33,6 @@
+ (DOMElement *)_DOMElementFromJSContext:(JSContextRef)context value:(JSValueRef)value;
@end
-@interface DOMDocument (WebDOMDocumentOperationsPrivate)
-- (NSArray *)_focusableNodes;
-@end
-
@interface DOMHTMLInputElement (WebDOMHTMLInputElementOperationsPrivate)
- (void)_setAutofilled:(BOOL)autofilled;
@end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
