Title: [150768] trunk/Source/WebCore
Revision
150768
Author
wei...@apple.com
Date
2013-05-27 11:25:21 -0700 (Mon, 27 May 2013)

Log Message

When the background is completely transparent we should be conservative and use the default scrollbar style, not the light one
https://bugs.webkit.org/show_bug.cgi?id=116836
<rdar://problem/13949905>

Reviewed by Simon Fraser.

* page/FrameView.cpp:
(WebCore::FrameView::recalculateScrollbarOverlayStyle):
Don't use the light style when the background is completely transparent.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (150767 => 150768)


--- trunk/Source/WebCore/ChangeLog	2013-05-27 18:09:51 UTC (rev 150767)
+++ trunk/Source/WebCore/ChangeLog	2013-05-27 18:25:21 UTC (rev 150768)
@@ -1,3 +1,15 @@
+2013-05-27  Sam Weinig  <s...@webkit.org>
+
+        When the background is completely transparent we should be conservative and use the default scrollbar style, not the light one
+        https://bugs.webkit.org/show_bug.cgi?id=116836
+        <rdar://problem/13949905>
+
+        Reviewed by Simon Fraser.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::recalculateScrollbarOverlayStyle):
+        Don't use the light style when the background is completely transparent.
+
 2013-05-27  Patrick Gansterer  <par...@webkit.org>
 
         Use ICU_INCLUDE_DIRS in BlackBerry CMake files

Modified: trunk/Source/WebCore/page/FrameView.cpp (150767 => 150768)


--- trunk/Source/WebCore/page/FrameView.cpp	2013-05-27 18:09:51 UTC (rev 150767)
+++ trunk/Source/WebCore/page/FrameView.cpp	2013-05-27 18:25:21 UTC (rev 150768)
@@ -400,7 +400,7 @@
         // heuristic.
         double hue, saturation, lightness;
         backgroundColor.getHSL(hue, saturation, lightness);
-        if (lightness <= .5)
+        if (lightness <= .5 && backgroundColor.alpha() > 0)
             overlayStyle = ScrollbarOverlayStyleLight;
     }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to