Diff
Modified: trunk/Source/WebKit2/ChangeLog (151053 => 151054)
--- trunk/Source/WebKit2/ChangeLog 2013-05-31 23:32:29 UTC (rev 151053)
+++ trunk/Source/WebKit2/ChangeLog 2013-05-31 23:32:53 UTC (rev 151054)
@@ -12,6 +12,43 @@
be running on a page
https://bugs.webkit.org/show_bug.cgi?id=117090
+ Rubber-stamped by Anders Carlsson.
+
+ Follow-up to r151043 incorprating some feedback I got from Darin after I had already
+ committed the patch.
+
+ * UIProcess/API/C/mac/WKPagePrivateMac.cpp:
+ (callGetPlugInInformationBlockAndDispose):
+ Renamed to be less wordy.
+ (WKPageGetPlugInInformation):
+ Ditto.
+ * UIProcess/API/C/mac/WKPagePrivateMac.h:
+ Ditto.
+
+ * UIProcess/Plugins/PluginProcessManager.h:
+ * UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
+ (WebKit::PluginProcessManager::findPlugInProcessByID):
+ Renamed to not use "Cocoa method style" in non-Cocoa functions.
+ (WebKit::PluginProcessManager::findPlugInProcessByToken):
+ Ditto.
+
+ * UIProcess/WebPageProxy.h:
+ * UIProcess/mac/WebPageProxyMac.mm:
+ (WebKit::WebPageProxy::getPlugInInformation):
+ Reduce ref count churn and fix a variable name.
+ Updated for the change to findPlugInProcessByID.
+ (WebKit::WebPageProxy::containsPlugInCallback):
+ Updated for the change to findPlugInProcessByToken.
+
+ * WebProcess/Plugins/PDF/SimplePDFPlugin.h:
+ Move the override of a virtual function to the private section.
+
+2013-05-31 Jessie Berlin <jber...@apple.com>
+
+ Need the ability to get the information for a plug-in with a particular process id that may
+ be running on a page
+ https://bugs.webkit.org/show_bug.cgi?id=117090
+
Reviewed by Anders Carlsson.
* UIProcess/API/C/mac/WKPagePrivateMac.cpp:
Modified: trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp (151053 => 151054)
--- trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp 2013-05-31 23:32:29 UTC (rev 151053)
+++ trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.cpp 2013-05-31 23:32:53 UTC (rev 151054)
@@ -47,14 +47,14 @@
return webPageProxy->process()->context()->isURLKnownHSTSHost(toImpl(url)->string(), privateBrowsingEnabled);
}
-static void callGetInformationForPlugInWithProcessIDBlockAndDispose(WKDictionaryRef resultValue, WKErrorRef error, void* context)
+static void callGetPlugInInformationBlockAndDispose(WKDictionaryRef resultValue, WKErrorRef error, void* context)
{
- WKPageGetInformationForPlugInWithProcessIDBlock block = (WKPageGetInformationForPlugInWithProcessIDBlock)context;
+ WKPageGetPlugInInformationBlock block = (WKPageGetPlugInInformationBlock)context;
block(resultValue, error);
Block_release(block);
}
-void WKPageGetInformationForPlugInWithProcessID(WKPageRef pageRef, pid_t plugInProcessID, WKPageGetInformationForPlugInWithProcessIDBlock block)
+void WKPageGetPlugInInformation(WKPageRef pageRef, pid_t plugInProcessID, WKPageGetPlugInInformationBlock block)
{
- toImpl(pageRef)->getInformationForPlugInWithProcessID(plugInProcessID, DictionaryCallback::create(Block_copy(block), callGetInformationForPlugInWithProcessIDBlockAndDispose));
+ toImpl(pageRef)->getPlugInInformation(plugInProcessID, DictionaryCallback::create(Block_copy(block), callGetPlugInInformationBlockAndDispose));
}
Modified: trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h (151053 => 151054)
--- trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h 2013-05-31 23:32:29 UTC (rev 151053)
+++ trunk/Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h 2013-05-31 23:32:53 UTC (rev 151054)
@@ -35,8 +35,8 @@
WK_EXPORT pid_t WKPageGetProcessIdentifier(WKPageRef page);
WK_EXPORT bool WKPageIsURLKnownHSTSHost(WKPageRef page, WKURLRef url);
-typedef void (^WKPageGetInformationForPlugInWithProcessIDBlock)(WKDictionaryRef, WKErrorRef);
-WK_EXPORT void WKPageGetInformationForPlugInWithProcessID(WKPageRef, pid_t plugInProcessID, WKPageGetInformationForPlugInWithProcessIDBlock);
+typedef void (^WKPageGetPlugInInformationBlock)(WKDictionaryRef, WKErrorRef);
+WK_EXPORT void WKPageGetPlugInInformation(WKPageRef, pid_t plugInProcessID, WKPageGetPlugInInformationBlock);
#ifdef __cplusplus
}
Modified: trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h (151053 => 151054)
--- trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h 2013-05-31 23:32:29 UTC (rev 151053)
+++ trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.h 2013-05-31 23:32:53 UTC (rev 151054)
@@ -63,8 +63,8 @@
#if PLATFORM(MAC)
void setProcessSuppressionEnabled(bool);
- PluginProcessProxy* plugInProcessWithProcessID(pid_t plugInProcessID) const;
- PluginProcessProxy* plugInProcessWithToken(uint64_t plugInProcessToken) const;
+ PluginProcessProxy* findPlugInProcessByID(pid_t plugInProcessID) const;
+ PluginProcessProxy* findPlugInProcessByToken(uint64_t plugInProcessToken) const;
#endif
private:
Modified: trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessManagerMac.mm (151053 => 151054)
--- trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessManagerMac.mm 2013-05-31 23:32:29 UTC (rev 151053)
+++ trunk/Source/WebKit2/UIProcess/Plugins/mac/PluginProcessManagerMac.mm 2013-05-31 23:32:53 UTC (rev 151054)
@@ -39,7 +39,7 @@
m_pluginProcesses[i]->setProcessSuppressionEnabled(processSuppressionEnabled);
}
-PluginProcessProxy* PluginProcessManager::plugInProcessWithProcessID(pid_t plugInProcessID) const
+PluginProcessProxy* PluginProcessManager::findPlugInProcessByID(pid_t plugInProcessID) const
{
for (size_t i = 0; i < m_pluginProcesses.size(); ++i) {
if (m_pluginProcesses[i]->processIdentifier() == plugInProcessID)
@@ -48,7 +48,7 @@
return 0;
}
-PluginProcessProxy* PluginProcessManager::plugInProcessWithToken(uint64_t plugInProcessToken) const
+PluginProcessProxy* PluginProcessManager::findPlugInProcessByToken(uint64_t plugInProcessToken) const
{
for (size_t i = 0; i < m_pluginProcesses.size(); ++i) {
if (m_pluginProcesses[i]->pluginProcessToken() == plugInProcessToken)
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (151053 => 151054)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2013-05-31 23:32:29 UTC (rev 151053)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h 2013-05-31 23:32:53 UTC (rev 151054)
@@ -538,7 +538,7 @@
ColorSpaceData colorSpace();
- void getInformationForPlugInWithProcessID(pid_t plugInProcessID, PassRefPtr<DictionaryCallback>);
+ void getPlugInInformation(pid_t plugInProcessID, PassRefPtr<DictionaryCallback>);
void containsPlugInCallback(bool containsPlugIn, uint64_t plugInToken, uint64_t callbackID);
#endif
Modified: trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm (151053 => 151054)
--- trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm 2013-05-31 23:32:29 UTC (rev 151053)
+++ trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm 2013-05-31 23:32:53 UTC (rev 151054)
@@ -459,7 +459,7 @@
m_pageClient->setPluginComplexTextInputState(pluginComplexTextInputIdentifier, static_cast<PluginComplexTextInputState>(pluginComplexTextInputState));
}
-void WebPageProxy::getInformationForPlugInWithProcessID(pid_t plugInProcessID, PassRefPtr<DictionaryCallback> prpCallback)
+void WebPageProxy::getPlugInInformation(pid_t plugInProcessID, PassRefPtr<DictionaryCallback> prpCallback)
{
RefPtr<DictionaryCallback> callback = prpCallback;
if (!isValid()) {
@@ -467,13 +467,13 @@
return;
}
- PluginProcessProxy* pluginProcessProxy = PluginProcessManager::shared().plugInProcessWithProcessID(plugInProcessID);
- if (!pluginProcessProxy)
+ PluginProcessProxy* plugInProcessProxy = PluginProcessManager::shared().findPlugInProcessByID(plugInProcessID);
+ if (!plugInProcessProxy)
callback->performCallbackWithReturnValue(0);
uint64_t callbackID = callback->callbackID();
- m_plugInInformationCallbacks.set(callbackID, callback.get());
- m_process->send(Messages::WebPage::ContainsPluginViewsWithPluginProcessToken(pluginProcessProxy->pluginProcessToken(), callbackID), m_pageID);
+ m_plugInInformationCallbacks.set(callbackID, callback.release());
+ m_process->send(Messages::WebPage::ContainsPluginViewsWithPluginProcessToken(plugInProcessProxy->pluginProcessToken(), callbackID), m_pageID);
}
void WebPageProxy::containsPlugInCallback(bool containsPlugIn, uint64_t plugInToken, uint64_t callbackID)
@@ -489,7 +489,7 @@
return;
}
- PluginProcessProxy* plugInProcessProxy = PluginProcessManager::shared().plugInProcessWithToken(plugInToken);
+ PluginProcessProxy* plugInProcessProxy = PluginProcessManager::shared().findPlugInProcessByToken(plugInToken);
ASSERT(plugInProcessProxy);
ImmutableDictionary::MapType map;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.h (151053 => 151054)
--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.h 2013-05-31 23:32:29 UTC (rev 151053)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/SimplePDFPlugin.h 2013-05-31 23:32:53 UTC (rev 151054)
@@ -191,8 +191,6 @@
virtual String getSelectionString() const OVERRIDE { return String(); }
- virtual uint64_t plugInProcessToken() const OVERRIDE { return 0; }
-
WebCore::IntSize m_scrollOffset;
private:
@@ -204,6 +202,8 @@
virtual bool shouldAlwaysAutoStart() const OVERRIDE { return true; }
+ virtual uint64_t plugInProcessToken() const OVERRIDE { return 0; }
+
WebCore::IntSize m_size;
WebCore::KURL m_sourceURL;
