Title: [151447] trunk/Source/WebKit2
- Revision
- 151447
- Author
- jer.no...@apple.com
- Date
- 2013-06-11 11:48:08 -0700 (Tue, 11 Jun 2013)
Log Message
Do not filter cookies requested through the CookieStorageShim.
https://bugs.webkit.org/show_bug.cgi?id=117511
<rdar://problem/13603433>
Reviewed by Beth Dakin.
Since the shim function is called when the underlying media engine is
creating an HTTPRequest, use CookieRequestHeaderFieldValue (which does
not filter out HTTP-only cookies) rather than CookiesForDOM (which does).
* Shared/mac/CookieStorageShim.cpp:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (151446 => 151447)
--- trunk/Source/WebKit2/ChangeLog 2013-06-11 18:33:36 UTC (rev 151446)
+++ trunk/Source/WebKit2/ChangeLog 2013-06-11 18:48:08 UTC (rev 151447)
@@ -1,3 +1,18 @@
+2013-06-11 Jer Noble <jer.no...@apple.com>
+
+ Do not filter cookies requested through the CookieStorageShim.
+ https://bugs.webkit.org/show_bug.cgi?id=117511
+ <rdar://problem/13603433>
+
+ Reviewed by Beth Dakin.
+
+ Since the shim function is called when the underlying media engine is
+ creating an HTTPRequest, use CookieRequestHeaderFieldValue (which does
+ not filter out HTTP-only cookies) rather than CookiesForDOM (which does).
+
+ * Shared/mac/CookieStorageShim.cpp:
+ (WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
+
2013-06-11 Seokju Kwon <seokju.k...@gmail.com>
Remove leftover wxWebkit code
Modified: trunk/Source/WebKit2/Shared/mac/CookieStorageShim.cpp (151446 => 151447)
--- trunk/Source/WebKit2/Shared/mac/CookieStorageShim.cpp 2013-06-11 18:33:36 UTC (rev 151446)
+++ trunk/Source/WebKit2/Shared/mac/CookieStorageShim.cpp 2013-06-11 18:48:08 UTC (rev 151447)
@@ -47,7 +47,7 @@
{
String cookies;
KURL firstPartyForCookiesURL;
- if (!WebProcess::shared().networkConnection()->connection()->sendSync(Messages::NetworkConnectionToWebProcess::CookiesForDOM(false, firstPartyForCookiesURL, inRequestURL), Messages::NetworkConnectionToWebProcess::CookiesForDOM::Reply(cookies), 0))
+ if (!WebProcess::shared().networkConnection()->connection()->sendSync(Messages::NetworkConnectionToWebProcess::CookieRequestHeaderFieldValue(false, firstPartyForCookiesURL, inRequestURL), Messages::NetworkConnectionToWebProcess::CookiesForDOM::Reply(cookies), 0))
return 0;
RetainPtr<CFStringRef> cfCookies = cookies.createCFString();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
