Diff
Modified: trunk/Source/WebCore/ChangeLog (151486 => 151487)
--- trunk/Source/WebCore/ChangeLog 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/ChangeLog 2013-06-12 06:05:58 UTC (rev 151487)
@@ -1,3 +1,28 @@
+2013-06-11 Christophe Dumez <ch.du...@sisa.samsung.com>
+
+ Unreviewed, rolling out r151378.
+ http://trac.webkit.org/changeset/151378
+ https://bugs.webkit.org/show_bug.cgi?id=117400
+
+ Decreased IDL readability a bit.
+
+ * Modules/encryptedmedia/MediaKeys.idl:
+ * Modules/mediastream/RTCIceCandidate.idl:
+ * Modules/mediastream/RTCPeerConnection.idl:
+ * Modules/mediastream/RTCSessionDescription.idl:
+ * Modules/webaudio/OfflineAudioContext.idl:
+ * Modules/websockets/WebSocket.idl:
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateConstructorDefinition):
+ * bindings/scripts/IDLAttributes.txt:
+ * bindings/scripts/test/TestInterface.idl:
+ * bindings/scripts/test/TestNamedConstructor.idl:
+ * css/WebKitCSSMatrix.idl:
+ * html/HTMLOptionElement.idl:
+ * page/EventSource.idl:
+ * workers/SharedWorker.idl:
+ * workers/Worker.idl:
+
2013-06-11 Ryosuke Niwa <rn...@webkit.org>
Have to invalidate the mute button when changing the volume
Modified: trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.idl (151486 => 151487)
--- trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/Modules/encryptedmedia/MediaKeys.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -26,7 +26,7 @@
[
Conditional=ENCRYPTED_MEDIA_V2,
Constructor(DOMString keySystem),
- RaisesException,
+ ConstructorRaisesException,
] interface MediaKeys {
[CallWith=ScriptExecutionContext, RaisesException] MediaKeySession createSession([Default=Undefined] optional DOMString type, [Default=Undefined] optional Uint8Array initData);
Modified: trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.idl (151486 => 151487)
--- trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/Modules/mediastream/RTCIceCandidate.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -31,7 +31,7 @@
[
Conditional=MEDIA_STREAM,
Constructor(Dictionary dictionary),
- RaisesException
+ ConstructorRaisesException
] interface RTCIceCandidate {
readonly attribute DOMString candidate;
readonly attribute DOMString sdpMid;
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl (151486 => 151487)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -32,7 +32,7 @@
Conditional=MEDIA_STREAM,
ActiveDOMObject,
Constructor(Dictionary rtcIceServers, optional Dictionary mediaConstraints),
- RaisesException,
+ ConstructorRaisesException,
CallWith=ScriptExecutionContext,
EventTarget,
InterfaceName=webkitRTCPeerConnection
Modified: trunk/Source/WebCore/Modules/mediastream/RTCSessionDescription.idl (151486 => 151487)
--- trunk/Source/WebCore/Modules/mediastream/RTCSessionDescription.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/Modules/mediastream/RTCSessionDescription.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -31,7 +31,7 @@
[
Conditional=MEDIA_STREAM,
Constructor(Dictionary dictionary),
- RaisesException
+ ConstructorRaisesException
] interface RTCSessionDescription {
[SetterRaisesException] attribute DOMString type;
[SetterRaisesException] attribute DOMString sdp;
Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl (151486 => 151487)
--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -27,7 +27,7 @@
EventTarget,
JSGenerateToJSObject,
Constructor(unsigned long numberOfChannels, unsigned long numberOfFrames, float sampleRate),
- RaisesException,
+ ConstructorRaisesException,
CallWith=ScriptExecutionContext,
InterfaceName=webkitOfflineAudioContext
] interface OfflineAudioContext : AudioContext {
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.idl (151486 => 151487)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -37,7 +37,7 @@
Constructor(DOMString url),
Constructor(DOMString url, sequence<DOMString> protocols),
Constructor(DOMString url, DOMString protocol),
- RaisesException,
+ ConstructorRaisesException,
CallWith=ScriptExecutionContext,
EventTarget,
JSNoStaticTables,
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (151486 => 151487)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2013-06-12 06:05:58 UTC (rev 151487)
@@ -4165,7 +4165,7 @@
GenerateArgumentsCountCheck($outputArray, $function, $interface);
- if ($function->signature->extendedAttributes->{"RaisesException"} || $interface->extendedAttributes->{"RaisesException"}) {
+ if ($function->signature->extendedAttributes->{"RaisesException"} || $interface->extendedAttributes->{"ConstructorRaisesException"}) {
$implIncludes{"ExceptionCode.h"} = 1;
push(@$outputArray, " ExceptionCode ec = 0;\n");
}
@@ -4192,7 +4192,7 @@
$index++;
}
- if ($interface->extendedAttributes->{"RaisesException"}) {
+ if ($interface->extendedAttributes->{"ConstructorRaisesException"}) {
push(@constructorArgList, "ec");
}
my $constructorArg = join(", ", @constructorArgList);
@@ -4202,7 +4202,7 @@
push(@$outputArray, " RefPtr<${interfaceName}> object = ${interfaceName}::create(${constructorArg});\n");
}
- if ($interface->extendedAttributes->{"RaisesException"}) {
+ if ($interface->extendedAttributes->{"ConstructorRaisesException"}) {
push(@$outputArray, " if (ec) {\n");
push(@$outputArray, " setDOMException(exec, ec);\n");
push(@$outputArray, " return JSValue::encode(JSValue());\n");
Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (151486 => 151487)
--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt 2013-06-12 06:05:58 UTC (rev 151487)
@@ -28,6 +28,7 @@
Conditional=*
Constructor
ConstructorConditional=*
+ConstructorRaisesException
ConstructorTemplate=Event|TypedArray
Custom
CustomCall
Modified: trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl (151486 => 151487)
--- trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -34,7 +34,7 @@
Conditional=Condition1|Condition2,
CallWith=ScriptExecutionContext,
Constructor(DOMString str1, [Default=Undefined] optional DOMString str2),
- RaisesException,
+ ConstructorRaisesException,
ConstructorConditional=TEST_INTERFACE,
ImplementationLacksVTable
] interface TestInterface {
Modified: trunk/Source/WebCore/bindings/scripts/test/TestNamedConstructor.idl (151486 => 151487)
--- trunk/Source/WebCore/bindings/scripts/test/TestNamedConstructor.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/bindings/scripts/test/TestNamedConstructor.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -31,6 +31,6 @@
[
ActiveDOMObject,
NamedConstructor=Audio(DOMString str1, [Default=Undefined] optional DOMString str2, [Default=NullString] optional DOMString str3),
- RaisesException
+ ConstructorRaisesException
] interface TestNamedConstructor {
};
Modified: trunk/Source/WebCore/css/WebKitCSSMatrix.idl (151486 => 151487)
--- trunk/Source/WebCore/css/WebKitCSSMatrix.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/css/WebKitCSSMatrix.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -26,7 +26,7 @@
// Introduced in DOM Level ?:
[
Constructor([Default=NullString] optional DOMString cssValue),
- RaisesException,
+ ConstructorRaisesException,
] interface WebKitCSSMatrix {
// These attributes are simple aliases for certain elements of the 4x4 matrix
Modified: trunk/Source/WebCore/html/HTMLOptionElement.idl (151486 => 151487)
--- trunk/Source/WebCore/html/HTMLOptionElement.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/html/HTMLOptionElement.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -21,7 +21,7 @@
[
JSGenerateToNativeObject,
NamedConstructor=Option([Default=NullString] optional DOMString data, [Default=NullString] optional DOMString value, [Default=Undefined] optional boolean defaultSelected, [Default=Undefined] optional boolean selected),
- RaisesException
+ ConstructorRaisesException
] interface HTMLOptionElement : HTMLElement {
[Reflect] attribute boolean disabled;
readonly attribute HTMLFormElement form;
Modified: trunk/Source/WebCore/page/EventSource.idl (151486 => 151487)
--- trunk/Source/WebCore/page/EventSource.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/page/EventSource.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -34,7 +34,7 @@
ActiveDOMObject,
Constructor(DOMString url, optional Dictionary eventSourceInit),
CallWith=ScriptExecutionContext,
- RaisesException,
+ ConstructorRaisesException,
EventTarget,
JSNoStaticTables
] interface EventSource {
Modified: trunk/Source/WebCore/workers/SharedWorker.idl (151486 => 151487)
--- trunk/Source/WebCore/workers/SharedWorker.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/workers/SharedWorker.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -34,7 +34,7 @@
Conditional=SHARED_WORKERS,
CustomConstructor(DOMString scriptURL, [Default=NullString] optional DOMString name),
CallWith=ScriptExecutionContext,
- RaisesException,
+ ConstructorRaisesException,
JSCustomMarkFunction,
JSGenerateToNativeObject,
JSGenerateToJSObject
Modified: trunk/Source/WebCore/workers/Worker.idl (151486 => 151487)
--- trunk/Source/WebCore/workers/Worker.idl 2013-06-12 05:29:35 UTC (rev 151486)
+++ trunk/Source/WebCore/workers/Worker.idl 2013-06-12 06:05:58 UTC (rev 151487)
@@ -29,7 +29,7 @@
Conditional=WORKERS,
CustomConstructor(DOMString scriptUrl),
CallWith=ScriptExecutionContext,
- RaisesException,
+ ConstructorRaisesException,
JSGenerateToNativeObject,
JSGenerateToJSObject
] interface Worker : AbstractWorker {
