Title: [151719] trunk
- Revision
- 151719
- Author
- rn...@webkit.org
- Date
- 2013-06-18 21:11:32 -0700 (Tue, 18 Jun 2013)
Log Message
Input type range slider is not updated when min or max are changed
https://bugs.webkit.org/show_bug.cgi?id=117778
Reviewed by Kent Tamura.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/089c7a0ba2d85b9b59632c2603fbc6472b310be1.
Test: fast/forms/range/range-change-min-max.html
* html/RangeInputType.cpp:
(WebCore::RangeInputType::minOrMaxAttributeChanged):
LayoutTests:
* fast/forms/range/range-change-min-max-expected.html: Added.
* fast/forms/range/range-change-min-max.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (151718 => 151719)
--- trunk/LayoutTests/ChangeLog 2013-06-19 03:37:20 UTC (rev 151718)
+++ trunk/LayoutTests/ChangeLog 2013-06-19 04:11:32 UTC (rev 151719)
@@ -1,3 +1,13 @@
+2013-06-18 Ryosuke Niwa <rn...@webkit.org>
+
+ Input type range slider is not updated when min or max are changed
+ https://bugs.webkit.org/show_bug.cgi?id=117778
+
+ Reviewed by Kent Tamura.
+
+ * fast/forms/range/range-change-min-max-expected.html: Added.
+ * fast/forms/range/range-change-min-max.html: Added.
+
2013-06-18 Benjamin Poulain <bpoul...@apple.com>
[WK2] Media elements never fail to load
Added: trunk/LayoutTests/fast/forms/range/range-change-min-max-expected.html (0 => 151719)
--- trunk/LayoutTests/fast/forms/range/range-change-min-max-expected.html (rev 0)
+++ trunk/LayoutTests/fast/forms/range/range-change-min-max-expected.html 2013-06-19 04:11:32 UTC (rev 151719)
@@ -0,0 +1,6 @@
+<!DOCTYPE html>
+<html>
+<body>
+<input type="range" id="test" value="100" min="80" max="140">
+</body>
+</html>
Added: trunk/LayoutTests/fast/forms/range/range-change-min-max.html (0 => 151719)
--- trunk/LayoutTests/fast/forms/range/range-change-min-max.html (rev 0)
+++ trunk/LayoutTests/fast/forms/range/range-change-min-max.html 2013-06-19 04:11:32 UTC (rev 151719)
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+<body>
+<input type="range" id="test" value="100" min="0" max="200">
+<script>
+var test = document.getElementById("test");
+test.offsetWidth; // Force layout.
+test.min = 80;
+test.max = 140;
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (151718 => 151719)
--- trunk/Source/WebCore/ChangeLog 2013-06-19 03:37:20 UTC (rev 151718)
+++ trunk/Source/WebCore/ChangeLog 2013-06-19 04:11:32 UTC (rev 151719)
@@ -1,5 +1,19 @@
2013-06-18 Ryosuke Niwa <rn...@webkit.org>
+ Input type range slider is not updated when min or max are changed
+ https://bugs.webkit.org/show_bug.cgi?id=117778
+
+ Reviewed by Kent Tamura.
+
+ Merge https://chromium.googlesource.com/chromium/blink/+/089c7a0ba2d85b9b59632c2603fbc6472b310be1.
+
+ Test: fast/forms/range/range-change-min-max.html
+
+ * html/RangeInputType.cpp:
+ (WebCore::RangeInputType::minOrMaxAttributeChanged):
+
+2013-06-18 Ryosuke Niwa <rn...@webkit.org>
+
Remove two superfluous overrides of supportsFocus
https://bugs.webkit.org/show_bug.cgi?id=117770
Modified: trunk/Source/WebCore/html/RangeInputType.cpp (151718 => 151719)
--- trunk/Source/WebCore/html/RangeInputType.cpp 2013-06-19 03:37:20 UTC (rev 151718)
+++ trunk/Source/WebCore/html/RangeInputType.cpp 2013-06-19 04:11:32 UTC (rev 151719)
@@ -299,7 +299,8 @@
// Sanitize the value.
if (element()->hasDirtyValue())
element()->setValue(element()->value());
- element()->setNeedsStyleRecalc();
+
+ sliderThumbElementOf(element())->setPositionFromValue();
}
void RangeInputType::setValue(const String& value, bool valueChanged, TextFieldEventBehavior eventBehavior)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
