Title: [152179] trunk/Tools
- Revision
- 152179
- Author
- commit-qu...@webkit.org
- Date
- 2013-06-28 11:07:44 -0700 (Fri, 28 Jun 2013)
Log Message
[EFL] back/forward keyboard shortcuts are non-intuitive
https://bugs.webkit.org/show_bug.cgi?id=118193
Patch by Balazs Kelemen <b.kele...@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.
Changed shortcuts for go-back/go-forward to alt+left and alt+right.
* EWebLauncher/main.c:
(on_key_down):
* MiniBrowser/efl/main.c:
(on_key_down):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (152178 => 152179)
--- trunk/Tools/ChangeLog 2013-06-28 18:00:53 UTC (rev 152178)
+++ trunk/Tools/ChangeLog 2013-06-28 18:07:44 UTC (rev 152179)
@@ -1,3 +1,17 @@
+2013-06-28 Balazs Kelemen <b.kele...@samsung.com>
+
+ [EFL] back/forward keyboard shortcuts are non-intuitive
+ https://bugs.webkit.org/show_bug.cgi?id=118193
+
+ Reviewed by Christophe Dumez.
+
+ Changed shortcuts for go-back/go-forward to alt+left and alt+right.
+
+ * EWebLauncher/main.c:
+ (on_key_down):
+ * MiniBrowser/efl/main.c:
+ (on_key_down):
+
2013-06-28 Roger Fong <roger_f...@apple.com>
Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
Modified: trunk/Tools/EWebLauncher/main.c (152178 => 152179)
--- trunk/Tools/EWebLauncher/main.c 2013-06-28 18:00:53 UTC (rev 152178)
+++ trunk/Tools/EWebLauncher/main.c 2013-06-28 18:07:44 UTC (rev 152179)
@@ -494,12 +494,14 @@
NULL
};
static int currentEncoding = -1;
- Eina_Bool ctrlPressed = evas_key_modifier_is_set(evas_key_modifier_get(e), "Control");
+ const Evas_Modifier *mod = evas_key_modifier_get(e);
+ Eina_Bool ctrlPressed = evas_key_modifier_is_set(mod, "Control");
+ Eina_Bool altPressed = evas_key_modifier_is_set(mod, "Alt");
if (!strcmp(ev->key, "Escape")) {
closeWindow(app->ee);
- } else if (!strcmp(ev->key, "F1")) {
- info("Back (F1) was pressed");
+ } else if (!strcmp(ev->key, "Left") && altPressed) {
+ info("Back (Alt+Left) was pressed");
if (ewk_view_back_possible(obj)) {
Ewk_History *history = ewk_view_history_get(obj);
Eina_List *list = ewk_history_back_list_get(history);
@@ -508,8 +510,8 @@
ewk_view_back(obj);
} else
info("Back ignored: No back history");
- } else if (!strcmp(ev->key, "F2")) {
- info("Forward (F2) was pressed");
+ } else if (!strcmp(ev->key, "Right") && altPressed) {
+ info("Forward (Alt+Right) was pressed");
if (ewk_view_forward_possible(obj)) {
Ewk_History *history = ewk_view_history_get(obj);
Eina_List *list = ewk_history_forward_list_get(history);
Modified: trunk/Tools/MiniBrowser/efl/main.c (152178 => 152179)
--- trunk/Tools/MiniBrowser/efl/main.c 2013-06-28 18:00:53 UTC (rev 152178)
+++ trunk/Tools/MiniBrowser/efl/main.c 2013-06-28 18:07:44 UTC (rev 152179)
@@ -391,14 +391,16 @@
NULL
};
static int currentEncoding = -1;
- Eina_Bool ctrlPressed = evas_key_modifier_is_set(evas_key_modifier_get(e), "Control");
+ const Evas_Modifier *mod = evas_key_modifier_get(e);
+ Eina_Bool ctrlPressed = evas_key_modifier_is_set(mod, "Control");
+ Eina_Bool altPressed = evas_key_modifier_is_set(mod, "Alt");
- if (!strcmp(ev->key, "F1")) {
- info("Back (F1) was pressed");
+ if (!strcmp(ev->key, "Left") && altPressed) {
+ info("Back (Alt+Left) was pressed");
if (!ewk_view_back(ewk_view))
info("Back ignored: No back history");
- } else if (!strcmp(ev->key, "F2")) {
- info("Forward (F2) was pressed");
+ } else if (!strcmp(ev->key, "Right") && altPressed) {
+ info("Forward (Alt+Right) was pressed");
if (!ewk_view_forward(ewk_view))
info("Forward ignored: No forward history");
} else if (!strcmp(ev->key, "F3")) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
