Title: [152298] trunk/Tools
Revision
152298
Author
[email protected]
Date
2013-07-02 09:50:49 -0700 (Tue, 02 Jul 2013)

Log Message

[ATK] Leak: leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118297

Fixed memory leak.

Patch by Brian Holt <[email protected]> on 2013-07-02
Reviewed by Christophe Dumez.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringValue):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (152297 => 152298)


--- trunk/Tools/ChangeLog	2013-07-02 16:26:03 UTC (rev 152297)
+++ trunk/Tools/ChangeLog	2013-07-02 16:50:49 UTC (rev 152298)
@@ -1,3 +1,15 @@
+2013-07-02  Brian Holt  <[email protected]>
+
+        [ATK] Leak: leaks in AccessibilityUIElement
+        https://bugs.webkit.org/show_bug.cgi?id=118297
+
+        Fixed memory leak.
+
+        Reviewed by Christophe Dumez.
+
+        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+        (AccessibilityUIElement::stringValue):
+
 2013-07-02  Byungwoo Lee  <[email protected]>
 
         Fix WebKitTestRunner crashes.

Modified: trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp (152297 => 152298)


--- trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp	2013-07-02 16:26:03 UTC (rev 152297)
+++ trunk/Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp	2013-07-02 16:50:49 UTC (rev 152298)
@@ -420,9 +420,9 @@
     if (!m_element || !ATK_IS_TEXT(m_element))
         return JSStringCreateWithCharacters(0, 0);
 
-    gchar* text = atk_text_get_text(ATK_TEXT(m_element), 0, -1);
-    GOwnPtr<gchar> axValue(g_strdup_printf("AXValue: %s", replaceCharactersForResults(text)));
-    g_free(text);
+    GOwnPtr<gchar> text(atk_text_get_text(ATK_TEXT(m_element), 0, -1));
+    GOwnPtr<gchar> textWithReplacedCharacters(replaceCharactersForResults(text.get()));
+    GOwnPtr<gchar> axValue(g_strdup_printf("AXValue: %s", textWithReplacedCharacters.get()));
 
     return JSStringCreateWithUTF8CString(axValue.get());
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to