Title: [152426] trunk/Source
Revision
152426
Author
bfulg...@apple.com
Date
2013-07-05 15:17:27 -0700 (Fri, 05 Jul 2013)

Log Message

[Windows] Identify OS-level at build-time.
https://bugs.webkit.org/show_bug.cgi?id=118428

Reviewed by Anders Carlsson.

../WebCore: 

* DerivedSources.make: Activate legible output features if present.
* WebCorePrefix.h: Activate MSVC 2010 workarounds for CGFloat if
building with VS2010.
* config.h: Activate legible output features if present.

../WTF: 

* WTF.vcxproj/WTFGenerated.make: Check for Legible Output featurs
and set build environment as appropriate.
* wtf/Platform.h: Activate Legible Output features if present.

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (152425 => 152426)


--- trunk/Source/WTF/ChangeLog	2013-07-05 21:33:44 UTC (rev 152425)
+++ trunk/Source/WTF/ChangeLog	2013-07-05 22:17:27 UTC (rev 152426)
@@ -1,3 +1,14 @@
+2013-07-05  Brent Fulgham  <bfulg...@apple.com>
+
+        [Windows] Identify OS-level at build-time.
+        https://bugs.webkit.org/show_bug.cgi?id=118428
+
+        Reviewed by Anders Carlsson.
+
+        * WTF.vcxproj/WTFGenerated.make: Check for Legible Output featurs
+        and set build environment as appropriate.
+        * wtf/Platform.h: Activate Legible Output features if present.
+
 2013-07-05  Mikhail Pozdnyakov  <mikhail.pozdnya...@intel.com>
 
         A lot of code duplication within StringImpl 'equal' functions

Modified: trunk/Source/WTF/WTF.vcxproj/WTFGenerated.make (152425 => 152426)


--- trunk/Source/WTF/WTF.vcxproj/WTFGenerated.make	2013-07-05 21:33:44 UTC (rev 152425)
+++ trunk/Source/WTF/WTF.vcxproj/WTFGenerated.make	2013-07-05 22:17:27 UTC (rev 152426)
@@ -1,4 +1,4 @@
-all:
+all: WTFHeaderDetection.h
     touch "%ConfigurationBuildDir%\buildfailed"
     bash build-generated-files.sh "%ConfigurationBuildDir%" "$(WEBKIT_LIBRARIES)" "$(DEBUGSUFFIX)"
 !IF "$(OFFICIAL_BUILD)"!="1"
@@ -10,4 +10,14 @@
 
 clean:
     -del "%ConfigurationBuildDir%\buildfailed"
+    -del "%ConfigurationBuildDir%\include\private\wtf\WTFHeaderDetection.h"
     copy-files.cmd clean
+
+# Header detection
+WTFHeaderDetection.h: WTFGenerated.make
+    -mkdir "%ConfigurationBuildDir%\include\private\wtf
+    <<testOSXLevel.cmd
+IF EXIST "%ConfigurationBuildDir%\include\private\wtf\$@" exit
+echo "" > "%ConfigurationBuildDir%\include\private\wtf\$@"
+IF EXIST "$(WEBKIT_LIBRARIES)/include/AVFoundationCF/AVCFPlayerItemLegibleOutput.h" (echo #define __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ 1090 > "%ConfigurationBuildDir%\include\private\wtf\$@")
+<<

Modified: trunk/Source/WTF/wtf/Platform.h (152425 => 152426)


--- trunk/Source/WTF/wtf/Platform.h	2013-07-05 21:33:44 UTC (rev 152425)
+++ trunk/Source/WTF/wtf/Platform.h	2013-07-05 22:17:27 UTC (rev 152426)
@@ -625,6 +625,9 @@
 #define HAVE_SYS_TIMEB_H 1
 #define HAVE_ALIGNED_MALLOC 1
 #define HAVE_ISDEBUGGERPRESENT 1
+
+#include <WTF/WTFHeaderDetection.h>
+
 #endif
 
 #if OS(WINDOWS)
@@ -960,11 +963,11 @@
 #define WTF_USE_COREMEDIA 1
 #endif
 
-#if PLATFORM(MAC) && !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
+#if (PLATFORM(MAC) || (OS(WINDOWS) && USE(CG))) && !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1080
 #define HAVE_AVFOUNDATION_MEDIA_SELECTION_GROUP 1
 #endif
 
-#if PLATFORM(MAC) && !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+#if (PLATFORM(MAC) || (OS(WINDOWS) && USE(CG))) && !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
 #define HAVE_AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT 1
 #endif
 

Modified: trunk/Source/WebCore/ChangeLog (152425 => 152426)


--- trunk/Source/WebCore/ChangeLog	2013-07-05 21:33:44 UTC (rev 152425)
+++ trunk/Source/WebCore/ChangeLog	2013-07-05 22:17:27 UTC (rev 152426)
@@ -1,3 +1,15 @@
+2013-07-05  Brent Fulgham  <bfulg...@apple.com>
+
+        [Windows] Identify OS-level at build-time.
+        https://bugs.webkit.org/show_bug.cgi?id=118428
+
+        Reviewed by Anders Carlsson.
+
+        * DerivedSources.make: Activate legible output features if present.
+        * WebCorePrefix.h: Activate MSVC 2010 workarounds for CGFloat if
+        building with VS2010.
+        * config.h: Activate legible output features if present.
+
 2013-07-05  Tim Horton  <timothy_hor...@apple.com>
 
         [wk2] Add API to lock the scroll position at the top or bottom of the page

Modified: trunk/Source/WebCore/DerivedSources.make (152425 => 152426)


--- trunk/Source/WebCore/DerivedSources.make	2013-07-05 21:33:44 UTC (rev 152425)
+++ trunk/Source/WebCore/DerivedSources.make	2013-07-05 22:17:27 UTC (rev 152426)
@@ -1117,6 +1117,6 @@
 all : WebCoreHeaderDetection.h
 
 WebCoreHeaderDetection.h : DerivedSources.make
-	if [ -f "$(WEBKIT_LIBRARIES)/include/AVFoundationCF/AVCFBase.h" ]||[ -f "$(WEBKITLIBRARIESDIR)/include/AVFoundationCF/AVCFBase.h" ]; then echo "#define HAVE_AVCF 1" > $@; else echo > $@; fi
+	if [ -f "$(WEBKIT_LIBRARIES)/include/AVFoundationCF/AVCFPlayerItemLegibleOutput.h" ]||[ -f "$(WEBKITLIBRARIESDIR)/include/AVFoundationCF/AVCFPlayerItemLegibleOutput.h" ]; then echo "#define HAVE_AVCF_LEGIBLE_OUTPUT 1" > $@; else echo > $@; fi
 
 endif # Windows_NT

Modified: trunk/Source/WebCore/WebCorePrefix.h (152425 => 152426)


--- trunk/Source/WebCore/WebCorePrefix.h	2013-07-05 21:33:44 UTC (rev 152425)
+++ trunk/Source/WebCore/WebCorePrefix.h	2013-07-05 22:17:27 UTC (rev 152426)
@@ -138,15 +138,23 @@
 #if USE(CG)
 
 #if defined(_MSC_VER) && _MSC_VER <= 1600
+
+#include <WebCore/WebCoreHeaderDetection.h>
+
+#if HAVE(AVCF_LEGIBLE_OUTPUT)
 // These must be defined before including CGFloat.h
 // This can be removed once we move to VS2012 or newer
 #include <wtf/ExportMacros.h>
 #include <wtf/MathExtras.h>
 
 #define isnan _isnan
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+#include <CoreGraphics/CGFloat.h>
+#endif
 #include <CoreGraphics/CoreGraphics.h>
 #undef isnan
 #endif
+#endif
 
 // FIXME <rdar://problem/8208868> Remove support for obsolete ColorSync API, CoreServices header in CoreGraphics
 // We can remove this once the new ColorSync APIs are available in an internal Safari SDK.

Modified: trunk/Source/WebCore/config.h (152425 => 152426)


--- trunk/Source/WebCore/config.h	2013-07-05 21:33:44 UTC (rev 152425)
+++ trunk/Source/WebCore/config.h	2013-07-05 22:17:27 UTC (rev 152426)
@@ -136,7 +136,13 @@
 
 // FIXME: Move this to _javascript_Core/wtf/Platform.h, which is where we define WTF_USE_AVFOUNDATION on the Mac.
 // https://bugs.webkit.org/show_bug.cgi?id=67334
-#if PLATFORM(WIN) && HAVE(AVCF)
+#if PLATFORM(WIN)
 #define WTF_USE_AVFOUNDATION 1
+
+#if HAVE(AVCF_LEGIBLE_OUTPUT)
+#define HAVE_AVFOUNDATION_MEDIA_SELECTION_GROUP 1
+#define HAVE_AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT 1
 #endif
 
+#endif
+
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to