Title: [153651] trunk/Tools
- Revision
- 153651
- Author
- [email protected]
- Date
- 2013-08-02 08:52:39 -0700 (Fri, 02 Aug 2013)
Log Message
[EFL] REGRESSION after r153432: some accessibility tests crash.
https://bugs.webkit.org/show_bug.cgi?id=119333
Patch by Mario Sanchez Prada <[email protected]> on 2013-08-02
Reviewed by Gustavo Noronha Silva.
Add missing null-check to avoid dereferencing a non-existent parent.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::attributesOfElement): Ditto.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (153650 => 153651)
--- trunk/Tools/ChangeLog 2013-08-02 15:40:57 UTC (rev 153650)
+++ trunk/Tools/ChangeLog 2013-08-02 15:52:39 UTC (rev 153651)
@@ -1,3 +1,15 @@
+2013-08-02 Mario Sanchez Prada <[email protected]>
+
+ [EFL] REGRESSION after r153432: some accessibility tests crash.
+ https://bugs.webkit.org/show_bug.cgi?id=119333
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Add missing null-check to avoid dereferencing a non-existent parent.
+
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+ (WTR::attributesOfElement): Ditto.
+
2013-08-02 Patrick Gansterer <[email protected]>
Add --rmdir option to git svn dcommit
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (153650 => 153651)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-08-02 15:40:57 UTC (rev 153650)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-08-02 15:52:39 UTC (rev 153651)
@@ -292,7 +292,8 @@
// For the parent we print its role and its name, if available.
builder.append("AXParent: ");
AccessibilityUIElement* parent = element->parentElement().get();
- if (AtkObject* atkParent = parent->platformUIElement().get()) {
+ AtkObject* atkParent = parent ? parent->platformUIElement().get() : 0;
+ if (atkParent) {
builder.append(roleToString(atk_object_get_role(atkParent)));
const char* parentName = atk_object_get_name(atkParent);
if (parentName && g_utf8_strlen(parentName, -1))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
