Title: [153661] trunk/Source/WebCore
- Revision
- 153661
- Author
- rn...@webkit.org
- Date
- 2013-08-02 12:34:49 -0700 (Fri, 02 Aug 2013)
Log Message
FormAssociatedElement shouldn't create out-of-tree FormAttributeTargetObserver
https://bugs.webkit.org/show_bug.cgi?id=119309
Reviewed by Kent Tamura.
Merge https://chromium.googlesource.com/chromium/blink/+/6fbdcbf311de539107bc28711b3f7a527176e97b.
I'm not merging the test since the attached test case only works when the shadow DOM API is enabled.
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore::FormAssociatedElement::resetFormAttributeTargetObserver):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153660 => 153661)
--- trunk/Source/WebCore/ChangeLog 2013-08-02 18:52:52 UTC (rev 153660)
+++ trunk/Source/WebCore/ChangeLog 2013-08-02 19:34:49 UTC (rev 153661)
@@ -1,3 +1,18 @@
+2013-08-02 Ryosuke Niwa <rn...@webkit.org>
+
+ FormAssociatedElement shouldn't create out-of-tree FormAttributeTargetObserver
+ https://bugs.webkit.org/show_bug.cgi?id=119309
+
+ Reviewed by Kent Tamura.
+
+ Merge https://chromium.googlesource.com/chromium/blink/+/6fbdcbf311de539107bc28711b3f7a527176e97b.
+
+ I'm not merging the test since the attached test case only works when the shadow DOM API is enabled.
+
+ * html/FormAssociatedElement.cpp:
+ (WebCore::FormAssociatedElement::formAttributeChanged):
+ (WebCore::FormAssociatedElement::resetFormAttributeTargetObserver):
+
2013-08-02 Christophe Dumez <ch.du...@sisa.samsung.com>
compareDocumentPosition() should report PRECEDING or FOLLOWING information even if nodes are disconnected
Modified: trunk/Source/WebCore/html/FormAssociatedElement.cpp (153660 => 153661)
--- trunk/Source/WebCore/html/FormAssociatedElement.cpp 2013-08-02 18:52:52 UTC (rev 153660)
+++ trunk/Source/WebCore/html/FormAssociatedElement.cpp 2013-08-02 19:34:49 UTC (rev 153661)
@@ -179,7 +179,8 @@
m_formAttributeTargetObserver = nullptr;
} else {
resetFormOwner();
- resetFormAttributeTargetObserver();
+ if (element->inDocument())
+ resetFormAttributeTargetObserver();
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
